Commit Graph

1593 Commits

Author SHA1 Message Date
Quincy Morgan
1821c3e955 Update fixes UI for icons, link styling, and non-actionable fixes
Fix several bugs
2019-02-14 15:56:04 -05:00
Quincy Morgan
c7e861c0ca Merge branch 'master' into validation 2019-02-14 12:16:23 -05:00
Bryan Housel
c292a32a66 Better message padding, remove double tooltip 2019-02-13 13:47:00 -05:00
Quincy Morgan
9007ccb8fd Disable preset buttons for hidden layers 2019-02-12 14:43:04 -05:00
Quincy Morgan
a46fb8043b Add terms to various shop presets (close #5849) 2019-02-12 09:31:08 -05:00
Bryan Housel
81bd734849 WIP uiEntityIssues cleanups, simplify
fixes are still not being applied properly
2019-02-11 20:44:02 -05:00
Quincy Morgan
7dc1328f6d Revert "Add field for bridge:structure key that requires bridge not equal to no in order to appear"
This reverts commit 28a353f1fa.
2019-02-11 15:33:14 -05:00
Quincy Morgan
28a353f1fa Add field for bridge:structure key that requires bridge not equal to no in order to appear
Update railway presets to use field inheritance
2019-02-11 15:19:45 -05:00
Bryan Housel
ac23ac8fd2 Periods in non-sentence message headings look strange 2019-02-11 13:30:28 -05:00
Quincy Morgan
149e1b3e4d Removed unused string 2019-02-11 11:41:18 -05:00
Quincy Morgan
47ec58e5fc Don't zoom to the end vertex when continuing a disconnected highway if it is already visible
Add separate fixes for continuing a disconnected highway from the start and end vertices
Highlight the vertex that will be continued
2019-02-11 11:29:34 -05:00
Quincy Morgan
db319e8ff5 Merge branch 'master' into validation 2019-02-11 07:59:29 -05:00
SilentSpike
24022416cb Fix negative number of trips in ImproveOSM issues
See https://github.com/openstreetmap/iD/pull/5739#issuecomment-460786055
2019-02-09 16:31:37 +00:00
Bryan Housel
6ff381cb28 Drop "from this key" jargon 2019-02-08 17:01:54 -05:00
Quincy Morgan
d3bbdfab7e Merge branch 'master' into validation 2019-02-07 07:01:36 -05:00
Bryan Housel
043b827cc7 Remove linear water_hazard and lateral_water_hazard presets
From reviewing wiki, these seem like not a thing - they are always areas.
re: https://wiki.openstreetmap.org/wiki/Tag:leisure%3Dgolf_course
2019-02-06 22:07:07 -05:00
Bryan Housel
ce3b33e374 Add style for golf walking paths and cartpaths
Also
- use field inheritance to simplify presets
- rename multipurpose to "Golf Cartpath / Service Road"
  (I think users would understand this better)
- add `maxspeed` to "Golf Cartpath / Service Road"
2019-02-06 21:56:22 -05:00
Quincy Morgan
33d02cdba0 Add different messages for no tags vs. no descriptive tags warnings
Add warning for relation without a "type" tag
2019-02-06 09:38:33 -05:00
Quincy Morgan
6383fa7ea0 Merge branch 'master' into validation 2019-02-06 08:58:13 -05:00
Quincy Morgan
011f82239b Add new icons for Butcher, Cheese Shop, Copy Store, Dairy Shop, and Mexican Restaurant presets
Add Chess Table and Mexican Fast Food presets
2019-02-06 08:55:59 -05:00
Quincy Morgan
c1df48ce0f Simplify crossing ways warning message 2019-02-05 17:25:34 -05:00
Quincy Morgan
bfefea422b Use iD's area tag logic for the tag_suggests_area validation 2019-02-05 13:55:59 -05:00
Quincy Morgan
7dd337383a Add quick fix for connecting the endpoints of a line where tags suggest area if it won't create self-intersection 2019-02-05 12:16:46 -05:00
Quincy Morgan
3808685ee3 Rewrote tag as disconnected fix undo message to be more consistent 2019-02-05 11:29:09 -05:00
Quincy Morgan
d09e76ccad Merge branch 'master' into validation 2019-02-05 11:18:59 -05:00
Quincy Morgan
23ab1b66fb Revert "Update places of worship to use field inheritance"
This reverts commit 44d4f2378d.
2019-02-05 11:06:31 -05:00
Quincy Morgan
7763626b02 Add access_simple field to library preset
Update Website field placeholder to use https
2019-02-05 10:22:43 -05:00
Quincy Morgan
44d4f2378d Update places of worship to use field inheritance
Add website to defaults fields for places of worship
Add presets for common place of worship denominations
2019-02-05 10:16:22 -05:00
Quincy Morgan
0934db48dd Don't count vertices toward many deletions warnings
Lower threshold for triggering many deletions warnings
2019-02-05 09:12:43 -05:00
Quincy Morgan
ca8c91563b Add issue count to section title in entity editor
Remove redundant string
2019-02-04 16:48:54 -05:00
Quincy Morgan
d3946894e8 Standardize deprecated_tag and missing_tag rule type ids
Run crossing_ways before disconnected_way
Break out crossing_ways issue creation into a separate function
2019-02-04 16:29:29 -05:00
Quincy Morgan
db5af39134 Tweak no issues info text 2019-02-04 13:40:08 -05:00
Quincy Morgan
190fc4f434 Add message to the issues pane for when there are no issues 2019-02-04 12:06:25 -05:00
Quincy Morgan
872cfe045e Sorted validation text alphabetically 2019-02-04 11:37:09 -05:00
Quincy Morgan
977e667453 Remove non-functional issue options from UI 2019-02-04 11:15:05 -05:00
Quincy Morgan
d76c33187b Fix pane list tooltip placement
Improve edited features tooltip
2019-02-04 11:02:31 -05:00
Quincy Morgan
a0558102d6 Add correct tags to crossing highway/railway and highway/waterway connection during quick fix
Remove unused fix text
2019-02-04 09:57:47 -05:00
Quincy Morgan
6514f645d1 Add error and warning count to the list titles
Hide error and warnings lists when there are no errors or warnings
2019-02-04 09:28:01 -05:00
Quincy Morgan
8c51411ad6 Merge branch 'master' into validation 2019-02-04 08:58:10 -05:00
SilentSpike
03a5c26e74 Refer to ImproveOSM QA as detections 2019-02-01 22:51:05 +00:00
SilentSpike
d82757c392 Include node in turn restriction description
Clarifies some cases where geometry could be unclear with previous
message.
2019-02-01 22:51:04 +00:00
SilentSpike
60128b0402 Fix one-way error positioning and description
The direction of travel in the description was misleading as the way
segment wasn't necessary linear and so the direction could change as you
travel along the way. This is more explicit as it specifies the detected
start/end nodes (also useful to show that it's not the whole way that
might be one-way).

The position is now taken as the central node in the `feature.points`
list (or the average of the central two when there are an even number of
points).
2019-02-01 22:51:03 +00:00
SilentSpike
4157cb1f25 Update QA help string 2019-02-01 22:51:03 +00:00
SilentSpike
31091f1159 Add direction of travel to oneway errors 2019-02-01 22:50:59 +00:00
SilentSpike
214cf41019 Use more generic classes for errors 2019-02-01 22:50:57 +00:00
SilentSpike
39880e559b Add direction of travel to turn restriction errors 2019-02-01 22:50:56 +00:00
SilentSpike
bea6f4dcfd Use point averages for locations 2019-02-01 22:50:56 +00:00
SilentSpike
ca290b5101 Add details to error messages 2019-02-01 22:50:55 +00:00
SilentSpike
4f2646d567 Add basic title + description UI 2019-02-01 22:50:54 +00:00
SilentSpike
4d89810721 Add ImproveOSM service
Only processing one-way errors for now
2019-02-01 22:50:54 +00:00