Commit Graph

2345 Commits

Author SHA1 Message Date
Quincy Morgan 2aa285c378 Merge branch 'master' into validation 2019-02-05 16:38:02 -05:00
Quincy Morgan 26dd7a4148 Use error for missing tags on all newly added features 2019-02-05 16:19:43 -05:00
Bryan Housel b87ae4e98b Exclude existing keys from auto-completion in raw tag editor
(closes #3625)
2019-02-05 16:14:18 -05:00
SilentSpike 78111955dd Fix user URL on ImproveOSM comments 2019-02-05 21:06:19 +00:00
Quincy Morgan 1055c239ed Merge branch 'master' into validation 2019-02-05 16:03:19 -05:00
Quincy Morgan beab323b20 Use warning severity for missing_tag validation if the user has not edited the feature 2019-02-05 15:58:20 -05:00
SilentSpike c095600635 Use more appropriate new comment header string 2019-02-05 20:44:04 +00:00
SilentSpike 5fc87fb0a4 Pacify eslint
(I really need to start running npm test more often before pushing)
2019-02-05 20:23:02 +00:00
SilentSpike f7bef29b92 Fix date conversion on ImproveOSM comments 2019-02-05 20:03:55 +00:00
SilentSpike fa87ed75ae Display ImproveOSM comments oldest to newest 2019-02-05 19:57:22 +00:00
SilentSpike 2c7b689b47 Add comments display to ImproveOSM issues 2019-02-05 19:52:44 +00:00
Bryan Housel 51af1f3b13 Don't re-sort the keys in the raw tag editor when tabbing
(closes #5857)
2019-02-05 14:52:13 -05:00
SilentSpike 28bb12b7ae Add function to retrieve ImproveOSM comments
Just need to have the UI make this call and use the data next.
2019-02-05 19:31:30 +00:00
Quincy Morgan bfefea422b Use iD's area tag logic for the tag_suggests_area validation 2019-02-05 13:55:59 -05:00
Quincy Morgan 4f68e71094 Merge endpoints rather than add segment if ends are close together in tag_suggest_area fix 2019-02-05 13:21:39 -05:00
Quincy Morgan 7dd337383a Add quick fix for connecting the endpoints of a line where tags suggest area if it won't create self-intersection 2019-02-05 12:16:46 -05:00
SilentSpike 448119324f Add ability to comment on ImproveOSM issues 2019-02-05 17:11:37 +00:00
Quincy Morgan a80aaf65db Improve performance when checking way for self-intersection when drawing 2019-02-05 11:42:45 -05:00
Quincy Morgan 8771a33716 Merge branch 'master' into validation 2019-02-05 11:30:24 -05:00
Bryan Housel e71eddd138 Merge branch 'unify' of https://github.com/SilentSpike/iD into SilentSpike-unify 2019-02-05 10:41:08 -05:00
Quincy Morgan 0934db48dd Don't count vertices toward many deletions warnings
Lower threshold for triggering many deletions warnings
2019-02-05 09:12:43 -05:00
Quincy Morgan a23954d886 Fix issue where preset reset buttons would not initially work 2019-02-05 08:24:34 -05:00
Quincy Morgan 7329d1301a Fix issues where save button would not enable and save blocker tooltip would not disappear 2019-02-04 19:08:43 -05:00
Quincy Morgan c39c584b52 Fix false positive for deprecated tag validation 2019-02-04 18:36:42 -05:00
SilentSpike b55830485d Fix use of old variable name 2019-02-04 22:55:47 +00:00
Quincy Morgan ca8c91563b Add issue count to section title in entity editor
Remove redundant string
2019-02-04 16:48:54 -05:00
Quincy Morgan d3946894e8 Standardize deprecated_tag and missing_tag rule type ids
Run crossing_ways before disconnected_way
Break out crossing_ways issue creation into a separate function
2019-02-04 16:29:29 -05:00
Quincy Morgan 01c4c46918 Improve crossing ways validation performance by reducing garbage collection 2019-02-04 15:41:22 -05:00
Quincy Morgan 4921a32be1 Improve performance of crossing ways validation 2019-02-04 15:22:07 -05:00
Quincy Morgan 451704ca7b Remove check to see if ways were already checked in the crossing ways validation 2019-02-04 15:07:37 -05:00
SilentSpike 781558e56b Remove redundant source property 2019-02-04 18:40:06 +00:00
Quincy Morgan ac7dba082f Merge branch 'master' into validation 2019-02-04 13:35:21 -05:00
Quincy Morgan bfb5285dc9 Fix tests and lint warnings 2019-02-04 13:34:27 -05:00
SilentSpike ddf44377e8 Fix errors without templates not working 2019-02-04 18:12:21 +00:00
Bryan Housel 7fe0380d7d Make sure icon fill colors can be overridden 2019-02-04 13:01:35 -05:00
SilentSpike d7147996ed Merge remote-tracking branch 'upstream/master' into unify 2019-02-04 17:17:17 +00:00
Quincy Morgan b3d49f0978 Merge branch 'master' into validation 2019-02-04 12:10:45 -05:00
Quincy Morgan 190fc4f434 Add message to the issues pane for when there are no issues 2019-02-04 12:06:25 -05:00
SilentSpike 450c549ea5 Remove old error type files 2019-02-04 16:54:07 +00:00
SilentSpike 40af841d53 Fix sidebar preview for new generic errors 2019-02-04 16:54:07 +00:00
SilentSpike 3ed13e9a4a Convert KeepRight to use generic error type 2019-02-04 16:54:07 +00:00
SilentSpike 20ed8b50c9 Add generic QA error
I've converted the improveOSM errors to use this new generic QA error
structure which should allow for more general code to be used in
behaviour and UI.

Sidebar preview is currently broken, but will be fixed shortly.
2019-02-04 16:53:59 +00:00
Quincy Morgan c2d72cf434 Make sure the vertex is visible when using the "continue this feature" quick fix for disconnected way 2019-02-04 11:30:48 -05:00
Quincy Morgan 977e667453 Remove non-functional issue options from UI 2019-02-04 11:15:05 -05:00
Quincy Morgan 2677a88df4 Zoom to ways and relations upon clicking on their issues in the issues pane 2019-02-04 10:27:35 -05:00
Andreas Haessler 82ea58d943 Add default value to number field 2019-02-04 15:59:08 +01:00
Quincy Morgan a0558102d6 Add correct tags to crossing highway/railway and highway/waterway connection during quick fix
Remove unused fix text
2019-02-04 09:57:47 -05:00
Quincy Morgan 6514f645d1 Add error and warning count to the list titles
Hide error and warnings lists when there are no errors or warnings
2019-02-04 09:28:01 -05:00
Quincy Morgan 8c51411ad6 Merge branch 'master' into validation 2019-02-04 08:58:10 -05:00
Bryan Housel e4e0d9d13a Add oneway icon for ImproveOSM oneway markers 2019-02-03 23:55:16 -05:00