ecc217f5d8
Add validation rule to flag impossible oneway highways and waterways ( close #6216 )
2019-04-26 12:04:43 -07:00
d01bb78707
Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys ( close #6237 )
2019-04-24 13:45:59 -07:00
2ebbb68604
Restore tooltips on rule checkboxes, separate 'tip' and 'reference'
...
Reference will show on clicking info button, and can contain more
useful information than a tooltip can.
2019-04-19 13:24:55 -04:00
01d2e3eaf3
Replace validator tooltip with reference function, add tag diff
2019-04-16 17:07:53 -04:00
294ce00211
substitute 'info' for 'data' (so I can use 'info' for an info drawer)
2019-04-15 16:56:21 -04:00
6508edf820
Avoid anonymous functions as validators
...
Givnig them names makes it easier to understand in the profiler
2019-04-05 09:50:22 -04:00
8b1c0551cc
WIP: understand state held by the validator, avoid translations
...
- Make sure all state variables prefixed with `_`
- Add explicit `init`/`reset` methods
(graph/entity refs should never persist through a save to OSM)
- Thinking of how best cache validation results
2019-04-05 09:28:36 -04:00
d5d4323c02
Replace "Use different layers" non-actionable quick fix with actionable quick fixes for setting a higher or lower layer ( close #5943 )
2019-04-01 11:52:04 -04:00
d075dac2be
Add crossing=unmarked when connecting ambiguous crossings highways
2019-03-14 09:46:45 -04:00
5ce788f6a3
Add bus_guideway as whitelisted value for checking crossing highways
2019-03-05 10:06:50 -05:00
604ff29593
Use whitelist instead of blacklist for affected highways in crossing ways validation
2019-03-05 10:01:16 -05:00
7d8453b1fb
Remove service road exception for adding highway=crossing during crossing way fix (re: #5976 )
2019-02-26 08:12:42 -05:00
7f58454958
Don't tag connection nodes of paths crossing service or track roads as highway=crossing in crossing ways quick fix (re: #5976 )
2019-02-25 11:39:03 -05:00
10e73fc15c
Explicitly include certain railways for crossing validation instead of excluding some
...
Don't flag abandoned or razed railway crossings
2019-02-21 15:09:13 -05:00
02d3097d8d
Fix a cacheing issue
2019-02-21 13:34:51 -05:00
51972ea78f
Cache issues in crossing ways validation to avoid checking the same pairs twice
2019-02-21 11:49:31 -05:00
2d6c49b92b
Ignore proposed features for crossings ways, almost junction, and disconnected way validations ( close #5922 )
2019-02-21 10:14:25 -05:00
cdc4557da5
Minor performance improvement in crossing ways by removing use of lodash and avoiding a concat within a reduce
2019-02-20 09:50:53 -05:00
ba68d921fe
Add icons for crossing ways fixes and almost junction connection fix
2019-02-20 09:02:05 -05:00
6d397e89c6
Account for waterway bridges and implicit layers in crossing ways validation
2019-02-19 15:28:27 -05:00
f536706763
Refactor crossing ways validation for performance
2019-02-19 14:40:54 -05:00
b766f82cbd
Improve crossing ways performance slightly by avoiding clone
2019-02-19 13:25:02 -05:00
12a44421c3
Account for indoor features in crossing ways validation
...
Recommend using an appropriate structure/layer/level for crossing ways validation
Flag crossing highways on different levels but without bridges or tunnels
2019-02-19 11:43:05 -05:00
66db6f3f2c
Make building crossing validation only create one issue per feature pair (re: #5891 )
2019-02-18 10:43:19 -05:00
94cb9faaa2
Don't check for self-intersection in the crossing ways validation
2019-02-18 10:16:22 -05:00
7021985aec
Don't suggest connection fix for highway-building crossings (re: #5891 )
2019-02-18 10:12:47 -05:00
397097ac1f
Tweak issue and fix strings
...
Different strings for one vs. a combination of deprecated tags
2019-02-15 14:24:11 -05:00
1821c3e955
Update fixes UI for icons, link styling, and non-actionable fixes
...
Fix several bugs
2019-02-14 15:56:04 -05:00
c4fe42653a
s/coordinates/loc and replace legacy names in tests
...
In iD codebase `loc` is usually a single coordinate pair
and `coordinates` is usually an array of pairs
2019-02-12 21:18:25 -05:00
14896b0ce5
Documentation, and move validation type up to top of each file
2019-02-12 16:07:08 -05:00
251a83ff7a
Nitpicky code formatting stuff
...
- no multiline var declaration
- squish together and alphabatize imports
- linebreaks for readability
2019-02-11 13:55:58 -05:00
a6e05b8ac5
Rename for consistency - these are called "annotations" elsewhere
2019-02-11 13:36:02 -05:00
6a9bb2d138
Add crossing tags when connecting paths crossing roads with the quick fix
2019-02-11 12:03:56 -05:00
55f71f5a7d
Replace Set objects in crossing ways validation
2019-02-08 09:20:41 -05:00
5b8fea9e87
Use existing nodes where possible in the crossing ways connection fix
...
Fix a lint warning
2019-02-06 15:03:29 -05:00
d3946894e8
Standardize deprecated_tag and missing_tag rule type ids
...
Run crossing_ways before disconnected_way
Break out crossing_ways issue creation into a separate function
2019-02-04 16:29:29 -05:00
01c4c46918
Improve crossing ways validation performance by reducing garbage collection
2019-02-04 15:41:22 -05:00
4921a32be1
Improve performance of crossing ways validation
2019-02-04 15:22:07 -05:00
451704ca7b
Remove check to see if ways were already checked in the crossing ways validation
2019-02-04 15:07:37 -05:00
bfb5285dc9
Fix tests and lint warnings
2019-02-04 13:34:27 -05:00
a0558102d6
Add correct tags to crossing highway/railway and highway/waterway connection during quick fix
...
Remove unused fix text
2019-02-04 09:57:47 -05:00
973697b8ba
Run all validators in the validations folder if not manually run
...
Remove ValidationIssueType and ValidationIssueSeverity objects
2019-02-01 13:38:17 -05:00
46f3cea33a
Reorganize validation code
...
Rename IssueManager to coreValidator
Rename disconnected highway to disconnected way
Rename highway almost junction to almost junction
Rename mapcss checks to maprules
Rename deprecated tags to deprecated tag
2019-02-01 11:20:51 -05:00
e60dafa540
Fix crossing ways validation - geoChooseEdge takes projected loc
2019-01-30 23:40:17 -05:00
957eb28242
Don't run other validators if feature is missing tags
...
Don't run disconnected highway check if there is an almost junction issue already
Only run way validators on ways
2019-01-30 17:59:23 -05:00
6aea578f92
Make validation functions take a single entity rather than an array of them
...
Pass context into validation functions directly rather than initializer
Don't initiate validation functions for every pass
2019-01-30 16:39:37 -05:00
49d62721d8
Fix background layer UI bugs
...
Add semicolon
2019-01-30 16:10:01 -05:00
fedad280b4
Use different messages for crossing tunnels and bridges if they are connectable
2019-01-29 14:30:42 -05:00
ccfba8ba0d
Don't validate crossing ways with area tags
...
Don't show connection fix for highway/waterway intersection if the highway is a major road
2019-01-29 13:44:37 -05:00
742147c62b
Don't validate water areas or specific highway, waterway, or railway features
2019-01-29 13:31:02 -05:00
Quincy Morgan