ac4cec1429
Add sidebar preview for ImproveOSM errors
2019-02-01 22:50:57 +00:00
214cf41019
Use more generic classes for errors
2019-02-01 22:50:57 +00:00
39880e559b
Add direction of travel to turn restriction errors
2019-02-01 22:50:56 +00:00
9600d67fc6
Differentiate missing geometry errors by colour
2019-02-01 22:50:56 +00:00
bea6f4dcfd
Use point averages for locations
2019-02-01 22:50:56 +00:00
ca290b5101
Add details to error messages
2019-02-01 22:50:55 +00:00
23a4d71410
Handle turn restriction errors
2019-02-01 22:50:55 +00:00
4f2646d567
Add basic title + description UI
2019-02-01 22:50:54 +00:00
4d89810721
Add ImproveOSM service
...
Only processing one-way errors for now
2019-02-01 22:50:54 +00:00
58e31bc45a
initial update to draw modes and hover behavior
...
ref #5811
2019-02-01 17:34:40 -05:00
5a309fd57a
Merge branch 'master' into validation
2019-02-01 16:47:10 -05:00
9d8a0b7843
Merge pull request #5836 from openstreetmap/5829
...
do not close image viewer if street level imagery layers are still rendered
2019-02-01 16:42:31 -05:00
251d83f86c
Show warnings and errors in different lists in the issues pane
2019-02-01 16:38:48 -05:00
19cc6399fe
Merge branch 'master' into validation
2019-02-01 15:20:38 -05:00
9785021f44
Rename simpleMultipolygon functions to oldMultipolygon
...
Return old_multipolygon validation issues for the relations as well as the outer ways
Remove console logging
Don't run missing_tag validation for relations with old_multipolygon issues
2019-02-01 15:19:28 -05:00
7f837c7e0c
no need to generate service variable
...
ref #5929
2019-02-01 14:01:17 -05:00
ec1a42ad39
clean up & remove hideViewer for openstreetcam
...
ref #5829
2019-02-01 13:59:04 -05:00
d894521143
just don't close viewer...
...
ref #5829
2019-02-01 13:55:10 -05:00
973697b8ba
Run all validators in the validations folder if not manually run
...
Remove ValidationIssueType and ValidationIssueSeverity objects
2019-02-01 13:38:17 -05:00
ce8d16a220
initial commit...hide parts, not entire viewer
...
ref #5829
2019-02-01 11:49:30 -05:00
d1fca87d79
Replace Edit Documentation link with pencil icon
...
(closes #5753 )
2019-02-01 11:49:03 -05:00
46f3cea33a
Reorganize validation code
...
Rename IssueManager to coreValidator
Rename disconnected highway to disconnected way
Rename highway almost junction to almost junction
Rename mapcss checks to maprules
Rename deprecated tags to deprecated tag
2019-02-01 11:20:51 -05:00
e60dafa540
Fix crossing ways validation - geoChooseEdge takes projected loc
2019-01-30 23:40:17 -05:00
957eb28242
Don't run other validators if feature is missing tags
...
Don't run disconnected highway check if there is an almost junction issue already
Only run way validators on ways
2019-01-30 17:59:23 -05:00
09bc2a6e6c
Merge branch 'master' into validation
2019-01-30 16:44:14 -05:00
6aea578f92
Make validation functions take a single entity rather than an array of them
...
Pass context into validation functions directly rather than initializer
Don't initiate validation functions for every pass
2019-01-30 16:39:37 -05:00
49d62721d8
Fix background layer UI bugs
...
Add semicolon
2019-01-30 16:10:01 -05:00
77c4d41855
Restore many deletions warning with tooltip and nicer message
...
Add tooltips back to issues pane list
Fix crash when restoring without having loaded the edited area
2019-01-30 15:48:06 -05:00
7138acc652
Properly export areaKeys, fix preset and maprules tests
2019-01-30 15:29:37 -05:00
5b93ee0f7a
Run validation upon data restore after page reload
2019-01-30 13:40:02 -05:00
19a2a60bf4
Add tooltip to disabled upload button to specify what is blocking the upload
2019-01-30 13:20:56 -05:00
4048cdaf3b
Merge branch 'master' into validation
2019-01-30 10:30:14 -05:00
17bbc3d5a2
Slightly improve suggestion placement, preset search performance
...
- avoid lodash _filter when native filter is ok for arrays
- for suggestions use `originalName` instead of adding/removing the en-dash
- bump up importance of leading suggestions, but do a strict leading search
more on that last point:
For normal presets, we count a string as leading if it follows a space.
e.g. "office" will match "Law Office"
We don't really want this for suggestion presets though
e.g. "bell" should not match "Taco Bell"
2019-01-29 21:56:23 -05:00
6df2c24b14
Add Continue and Delete quick fixes for disconnected highway issue
2019-01-29 16:45:28 -05:00
0b19d5f93a
Merge branch master into validation
2019-01-29 14:51:59 -05:00
94c8f9f9f7
Update text for features to edit
2019-01-29 14:48:18 -05:00
fedad280b4
Use different messages for crossing tunnels and bridges if they are connectable
2019-01-29 14:30:42 -05:00
7aea67fcfe
Merge pull request #5745 from jguthrie100/stop_merge_overlapping_self
...
Add check to stop joining ways if resulting way intersects itself
2019-01-29 14:07:34 -05:00
0f41913b04
pacify eslint
2019-01-29 14:04:36 -05:00
a2212a732b
Merge pull request #5816 from SilentSpike/mapillary-icon
...
Fix street imagery hover and selection behaviour
2019-01-29 13:59:28 -05:00
ccfba8ba0d
Don't validate crossing ways with area tags
...
Don't show connection fix for highway/waterway intersection if the highway is a major road
2019-01-29 13:44:37 -05:00
742147c62b
Don't validate water areas or specific highway, waterway, or railway features
2019-01-29 13:31:02 -05:00
b1e5b4f3ec
Check to see if ways can be connected before offering that quick fix
2019-01-29 13:05:11 -05:00
907c4d9616
Rename fix function from action to onClick
2019-01-29 12:18:02 -05:00
80c7aedb39
Fix bug with issues pane
2019-01-29 11:59:01 -05:00
fcc7606089
Update crossing_ways fix to not use the context within the action
2019-01-29 11:47:24 -05:00
226c4f88e1
Re-run validation automatically upon merging fetched remote data into the history
2019-01-29 11:10:12 -05:00
2051dc4ca8
Update id of remove generic name fix
2019-01-29 10:45:48 -05:00
f89c18e65d
Added quick fix for tag_suggest_area validation to remove the suggesting tags
2019-01-29 10:40:08 -05:00
b48445b29a
Make the first issue's fix list appear by default
2019-01-29 09:56:44 -05:00
SilentSpike