55f71f5a7d
Replace Set objects in crossing ways validation
2019-02-08 09:20:41 -05:00
1564f73de6
Merge branch 'master' into validation
2019-02-07 20:51:21 -05:00
a363f5175f
Fix tabbing beyond last row of raw tag editor in Firefox
...
(closes #5847 )
- removed the stopPropagation from the combobox keydown handler
to make sure that the raw_tag_editor keydown handler will run
- increased timeout from 1ms to 10ms for Firefox
This is related to Firefox's newish time budgeting approach that they
started using around Firefox 55. As a result, very fast timers (<4ms?)
may run synchronously instead of yielding and running asynchronously
https://blog.wanderview.com/blog/2017/03/13/firefox-52-settimeout-changes/
(note similar code in ui/fields/combo.js to delay focus changes and
redraws 10ms after the tag changes and other events have completed)
2019-02-07 15:56:49 -05:00
02790fcc5c
Also make sure you can delete the new row in the raw tag editor
...
(re #5840 )
2019-02-07 15:04:16 -05:00
2aa409d5a9
Fix crash when deleting rows in raw tag editor
...
(closes #5840 )
This didn't always trigger a crash, but it can. It attempted to remove the
row containing the key/value input fields, however this ilne is unnecessary
because the change event will trigger a redraw and d3 will handle the removing
milliseconds later.
2019-02-07 14:10:04 -05:00
d2735ab40c
Fix misspelling
2019-02-07 13:41:06 -05:00
3875ea565b
Remove mvt querystring parameter that we never used
2019-02-07 10:48:19 -05:00
bb0a47b255
Remove kr and keepRight for styles used generically
...
(it was weird to see these classes in improveOSM components)
2019-02-07 10:35:50 -05:00
f4b9abe474
Merge pull request #5867 from SilentSpike/iOSM-comments
...
Add comments to ImproveOSM issues
2019-02-07 09:46:57 -05:00
d3bbdfab7e
Merge branch 'master' into validation
2019-02-07 07:01:36 -05:00
ce3b33e374
Add style for golf walking paths and cartpaths
...
Also
- use field inheritance to simplify presets
- rename multipurpose to "Golf Cartpath / Service Road"
(I think users would understand this better)
- add `maxspeed` to "Golf Cartpath / Service Road"
2019-02-06 21:56:22 -05:00
a702281fb6
Add "remove" tooltip to raw tag editor remove button
2019-02-06 15:56:12 -05:00
7036523bfc
Merge branch 'master' into validation
2019-02-06 15:37:03 -05:00
5b8fea9e87
Use existing nodes where possible in the crossing ways connection fix
...
Fix a lint warning
2019-02-06 15:03:29 -05:00
e0a41656a1
Allow value to be entered before key in raw tag editor
...
(closes #5872 )
This commit also hardens the 'key=value' splitting behavior to actually
check the split result length and avoid overwriting a readonly key
(re: #5024 )
2019-02-06 15:03:03 -05:00
50fcff6ec9
Only check the edge nodes for almost junction merge fix
2019-02-06 14:12:19 -05:00
7765baf03b
Make merge threshold consistent for almost_junction and tag_suggests_area connection fixes
2019-02-06 13:12:58 -05:00
88ecbcc069
Make the tag_suggests_area connection fix always use the location of the first node
2019-02-06 13:10:22 -05:00
703d560a94
Merge branch 'master' into validation
2019-02-06 12:49:59 -05:00
b25d75a6cc
Use existing nodes where possible in almost junction connection fix
2019-02-06 12:47:12 -05:00
8545ebde8e
Add self-intersection check before flagging almost junction issues
2019-02-06 11:29:58 -05:00
640730d38b
Change focus to existing key instead of suffixing it with _1
...
(re: #3625 , re: #2896 )
2019-02-06 10:29:09 -05:00
21967d2654
Show the area preset browser rather than editor upon selecting multipolygon from the relation preset browser
2019-02-06 09:48:45 -05:00
33d02cdba0
Add different messages for no tags vs. no descriptive tags warnings
...
Add warning for relation without a "type" tag
2019-02-06 09:38:33 -05:00
0aa3ce2cee
Fix issue with Issues section appearance if the sidebar was loaded with the section closed
2019-02-05 16:57:34 -05:00
a566d58f81
Fix error on ImproveOSM issues with no comments
2019-02-05 21:48:06 +00:00
0346d8060f
Retrieve ImproveOSM comments only once
...
This additionally fixes the comment box not clearing on submission as I
wasn't updating the error in the cache (to remove the newComment
property).
2019-02-05 21:46:17 +00:00
2aa285c378
Merge branch 'master' into validation
2019-02-05 16:38:02 -05:00
26dd7a4148
Use error for missing tags on all newly added features
2019-02-05 16:19:43 -05:00
b87ae4e98b
Exclude existing keys from auto-completion in raw tag editor
...
(closes #3625 )
2019-02-05 16:14:18 -05:00
78111955dd
Fix user URL on ImproveOSM comments
2019-02-05 21:06:19 +00:00
1055c239ed
Merge branch 'master' into validation
2019-02-05 16:03:19 -05:00
beab323b20
Use warning severity for missing_tag validation if the user has not edited the feature
2019-02-05 15:58:20 -05:00
c095600635
Use more appropriate new comment header string
2019-02-05 20:44:04 +00:00
5fc87fb0a4
Pacify eslint
...
(I really need to start running npm test more often before pushing)
2019-02-05 20:23:02 +00:00
f7bef29b92
Fix date conversion on ImproveOSM comments
2019-02-05 20:03:55 +00:00
fa87ed75ae
Display ImproveOSM comments oldest to newest
2019-02-05 19:57:22 +00:00
2c7b689b47
Add comments display to ImproveOSM issues
2019-02-05 19:52:44 +00:00
51af1f3b13
Don't re-sort the keys in the raw tag editor when tabbing
...
(closes #5857 )
2019-02-05 14:52:13 -05:00
28bb12b7ae
Add function to retrieve ImproveOSM comments
...
Just need to have the UI make this call and use the data next.
2019-02-05 19:31:30 +00:00
bfefea422b
Use iD's area tag logic for the tag_suggests_area validation
2019-02-05 13:55:59 -05:00
4f68e71094
Merge endpoints rather than add segment if ends are close together in tag_suggest_area fix
2019-02-05 13:21:39 -05:00
7dd337383a
Add quick fix for connecting the endpoints of a line where tags suggest area if it won't create self-intersection
2019-02-05 12:16:46 -05:00
448119324f
Add ability to comment on ImproveOSM issues
2019-02-05 17:11:37 +00:00
a80aaf65db
Improve performance when checking way for self-intersection when drawing
2019-02-05 11:42:45 -05:00
8771a33716
Merge branch 'master' into validation
2019-02-05 11:30:24 -05:00
e71eddd138
Merge branch 'unify' of https://github.com/SilentSpike/iD into SilentSpike-unify
2019-02-05 10:41:08 -05:00
0934db48dd
Don't count vertices toward many deletions warnings
...
Lower threshold for triggering many deletions warnings
2019-02-05 09:12:43 -05:00
a23954d886
Fix issue where preset reset buttons would not initially work
2019-02-05 08:24:34 -05:00
7329d1301a
Fix issues where save button would not enable and save blocker tooltip would not disappear
2019-02-04 19:08:43 -05:00
Quincy Morgan