64f2d913e8
remove unused entities from test
2018-12-17 17:39:47 -05:00
8f33a85a12
make collection.index function to handle failing tests
2018-12-17 17:16:10 -05:00
d8de9e785e
do not add found presets to recent
2018-12-17 14:56:33 -05:00
74a19a6d7f
remove a comment
2018-12-17 12:55:00 -05:00
e0e6f5b918
remove non-used util class
2018-12-17 12:52:21 -05:00
743be30a76
Use water fill pattern for fountain area
2018-12-15 16:33:06 +02:00
89a128f14c
Allow directly specified fill pattern for entire tag (not using for anything as of yet)
2018-12-15 15:58:39 +02:00
b92592b6b4
Add fill pattern for reservoir
2018-12-15 15:32:48 +02:00
43cea82d6f
Make sure when selecting to restore the sidebar to select mode
...
(closes #5603 )
2018-12-14 17:31:10 -05:00
d87b1822f7
add/make visible weakly matched presets
2018-12-14 15:42:25 -05:00
f627f1e659
make all presets visible on init!!
2018-12-14 13:29:17 -05:00
1b51b8bc57
adding tests and updating/fixing external presets logic
2018-12-14 13:23:58 -05:00
e5aa8a7058
Simplify setPattern
2018-12-14 12:57:28 -05:00
a61cdc8208
Removed unused function
2018-12-13 17:29:59 -08:00
a4b2924e4e
Merge branch 'master' into field-prerequisite-tags
2018-12-13 17:23:54 -08:00
c897331cd1
presets test w/build
2018-12-13 13:30:38 -05:00
96e44be69c
merge 2.12.2
2018-12-13 11:22:32 -05:00
f3e6459191
working on preset visibility
2018-12-13 11:16:24 -05:00
eb14a9ed53
v2.12.2
2018-12-13 10:28:31 -05:00
cd74e4e063
Fix broken member role dropdown for members that are not downloaded
...
(closes #5592 )
2018-12-12 16:53:20 -05:00
f45e97d727
Variable cleanups
2018-12-12 16:13:32 -05:00
d28b269b4c
Speed up the scrolling on Firefox Linux too
...
(re: #5512 )
This just changes
`detected.os === 'win'` to `detected.os !== 'mac'`
2018-12-12 15:45:55 -05:00
17615da0ea
Listen to both change and blur for role switcher, compare old v new
...
(closes #5449 )
2018-12-12 15:27:14 -05:00
e08bfb2add
Simplify accept/cancel event dispatchers, store datum in _choice
2018-12-12 15:26:18 -05:00
84f96574d7
Add index property to cloned object, not actual member object
...
(closes #5458 )
This code was adding an `index` property to each member in the relation.
Although the `index` property is ignored by the code that saves to OSM,
the extra property would make the member changed when compared by
`coreDifference`.
2018-12-12 02:07:03 -05:00
c635389c1a
Fix handling of semicolon delimited values in numeric field
...
(closes #5438 )
2018-12-12 01:11:34 -05:00
fc1f7e4d46
Trigger a change event when accepting combo option with return, tab
...
(closes #4900 , closes #5449 )
Some browsers need an explicit `change` event triggered on the input field
when a value has been changed by the combo and accepted by pressing return
or tab. This was only an issue on combos that aren't part of uiFields,
since the uiFields are all setup to respond to `change`,`input`,`blur` etc.
2018-12-11 23:25:47 -05:00
ec51ebb026
Fix flexbox of raw membership editor new row
...
(closes #5589 )
2018-12-11 21:54:25 -05:00
3de03439e2
Use user's locale for fetching wikidata label/description
...
(closes #5563 )
2018-12-11 19:02:29 -05:00
9aceb8f725
Fix lazy instantiation of the fields
...
They are shown either if `_show=true` or `isPresent()`
2018-12-11 19:01:23 -05:00
13b1a9a629
If imagery becomes invalid, remove it from imagery_used
...
(closes #4827 )
2018-12-11 17:49:15 -05:00
577e0c6503
Don't add "None" to imagery_used tag when other imagery was used
...
(closes #5565 )
2018-12-11 16:37:52 -05:00
0d958f04c1
Don't try to render a field that's not yet shown
2018-12-11 16:37:36 -05:00
ddf10d00aa
Merge branch 'combobox-perf'
2018-12-11 16:12:00 -05:00
39b3f1df68
Avoid creating comboboxes
...
(closes #5568 )
Several strategies in here:
- Move uiCombobox() from inside the render function to class variable
- Don't render stuff like the raw tag editor when it's collapsed
- Don't show as many fields/combos on hover
- Don't instantiate fields (like universal/more) until they're actually shown
- Bind the combo on enter selection not on update selection
2018-12-11 16:07:00 -05:00
222b3f1b04
Don't render contents of collapsed sections
...
(speeds things up if raw tag editor is hidden)
2018-12-11 15:19:29 -05:00
a868284aba
Merge pull request #5584 from RudyTheDev/traffic_calming_area_grass
...
Grass surface rendering for traffic calming areas
2018-12-11 01:22:44 -05:00
6732ca6eda
Comboboxes no longer show on focus.. update tests
2018-12-11 01:19:51 -05:00
ff646fa2c8
Dispatch a 'cancel' event if the user hits escape
2018-12-11 00:09:55 -05:00
6cf1d63b48
Make sure dropdown doesn't remain visible
...
(closes #5575 )
Also improves keyboard navigation, and adds some scrollintoview
workarounds to make sure that the selected option is visible
while also not causing the whole page to move.
2018-12-10 23:54:06 -05:00
15a54cab17
Use context.container instead of passing it in
2018-12-10 14:14:27 -05:00
e5dedeff8b
Move lib/d3.combobox.js -> ui/combobox.js
...
As with other things from this lib/ folder, little original code remains
and turning these things into reusable d3 plugins is not a priority.
2018-12-10 12:38:21 -05:00
54a4546306
WIP to avoid _wrapper state variable, move towards combobox singleton
2018-12-10 12:15:50 -05:00
34cdb129c6
Add grass surface rendering for traffic calming areas
2018-12-10 17:41:53 +02:00
5c9f9ac012
Always show save count 0.. makes responsivness easier
...
(closes #5576 )
2018-12-09 23:31:52 -05:00
5471b909e2
Added mechanism for displaying fields conditionally based on tags
2018-12-09 20:11:31 -08:00
4285f2f5c0
Added "moreFields" property to the field schema
...
The "Add field" dropdown can now be used to add preset-specific fields in addition to universal fields
2018-12-09 13:51:57 -08:00
cbcafaee15
Make sure sidebar is expanded before entering walkthrough or saving
...
(closes #5574 )
2018-12-08 10:03:43 -05:00
7fd06f69b8
Use .select instead of .selectAll to propagate the bound data
...
(closes #5573 )
2018-12-07 17:46:14 -05:00
d574bfcd77
Disable autocomplete on the localized field
...
(closes #5558 )
2018-12-07 17:19:02 -05:00
Max Grossman