Quincy Morgan
be6e69c2e2
Always flag tags as incomplete rather than outdated when the changes are purely additive
2019-11-25 11:14:59 -05:00
Quincy Morgan
9f8e88a2ff
Don't cache point-as-vertex extraction fix
2019-11-25 10:49:16 -05:00
Quincy Morgan
6f09c3f4cc
Flag unknown roads that are also members of relations
2019-11-22 17:51:39 -05:00
Quincy Morgan
b62162b191
Add check to ensure osm service is available before calling isDataLoaded
2019-11-22 16:08:41 -05:00
Quincy Morgan
62865db740
Fix issue where crossing ways layer fix would set layer tag as a number instead of a string (re: #6911 )
2019-11-22 15:50:40 -05:00
Quincy Morgan
22266c66b1
Suggest noexit fix for almost junctions even if the endpoint has uninteresting tags
2019-11-22 15:47:34 -05:00
Quincy Morgan
7945f5d6ff
Don't flag missing tags for nodes on unloaded tiles
2019-11-22 15:32:27 -05:00
Quincy Morgan
59f0c04e13
Don't flag unclosed parts of multipolygons with undownloaded members (re: #2223 )
2019-11-22 15:00:43 -05:00
Quincy Morgan
45ac186a68
Flag unclosed multipolygon parts ( close #2223 )
2019-11-22 14:55:51 -05:00
Quincy Morgan
588fa36a3a
Restore fixes for generic name warnings
2019-11-21 11:53:40 -05:00
Quincy Morgan
7cd57789fe
Improve "add a bridge/tunnel" fix variable names somewhat (re: #7055 )
...
Add a minimum structure length as derived from the crossing feature's width
2019-11-20 16:58:42 -05:00
Quincy Morgan
ff6eb88957
Update add a bridge/tunnel fix icons
2019-11-20 16:04:10 -05:00
Quincy Morgan
e791b7514c
Use existing vertices for "add a bridge/tunnel" endpoints if the edge is too short to add a new vertex (re: #7055 )
...
Avoid creating very short edges from splitting too close to another node when adding a bridge or tunnel via fix
Fix possible "entity not found" error
2019-11-20 15:44:14 -05:00
Quincy Morgan
5640d7867a
Simplify some "add bridge or tunnel" fix code (re: #7055 )
...
Add endpoint to actionSplit to get the created ways after running the action
Change "Use bridge" or "tunnel" fix labels to "Add a bridge" or "tunnel"
Add layer tags on structure feature when adding a bridge or tunnel via a fix
Select all components of the split way when adding a bridge or tunnel via a fix
Don't recommend adding a bridge to a waterway
Don't show "change layers" fixes along with "add structure" fixes
Don't split or change the tags of coincident ways when adding a bridge or tunnel
2019-11-20 13:09:27 -05:00
Katarzyna Król
5ed22cce21
create bridge or tunnel when crossed ways
2019-11-20 12:54:43 -05:00
Quincy Morgan
d2c73f8a86
Restore fixes for very close vertices issues
2019-11-18 12:07:48 -05:00
Quincy Morgan
96c8bcb152
Add tooltip to delete feature fix explaining if it's disabled ( close #6588 )
2019-11-13 14:52:57 -05:00
Quincy Morgan
24c72b64d1
Load issue fixes dynamically instead of cacheing them ( close #7037 )
2019-11-13 14:35:01 -05:00
Quincy Morgan
c32cca2a71
Add additional comment to close nodes validation
2019-11-11 15:34:55 +01:00
Quincy Morgan
bc39b0eb25
Don't flag nonstandard brands with a matching not:brand:wikidata tag ( close #6577 )
2019-11-11 14:56:05 +01:00
Quincy Morgan
40edee1275
Don't flag very close nodes with different house or unit numbers ( close #6998 )
2019-11-11 13:40:37 +01:00
Quincy Morgan
e85b6b9c45
Include default field values when upgrading a preset with a specific replacement ( close #7033 )
2019-11-11 13:25:49 +01:00
Quincy Morgan
538829d171
Don't flag nonstandard brands from incompatible countries ( close #6513 )
2019-11-07 19:08:50 +01:00
Bryan Housel
3886f2dad8
Merge branch '2.15-building-crossing-layers' into 2.x
2019-10-24 15:15:06 -04:00
Quincy Morgan
769c95af55
Add non-actionable fix suggestion for "Fix Me" request issues
2019-10-14 11:03:49 +02:00
Quincy Morgan
56f31adcf1
Always sort the entity issues list deterministically
...
Don't skip validations just because a different validation produced issues
2019-10-12 17:01:03 +02:00
Quincy Morgan
abd94a940f
Show non-actionable "Connect this feature" fix for disconnected roads and paths with both ends as noexits
...
Correctly reverse the "continue" fix icons for the right-to-left layout
2019-10-11 17:04:45 +02:00
Quincy Morgan
d7bde50649
Locate impossible way issues at the questionable node, not at the center of the way's extent
2019-10-10 15:08:54 +02:00
Quincy Morgan
bd1e1b34ff
Add subtypes to crossing_ways validation warnings
...
Allow the `indoor` tag to indicate a crossing feature is indoors
2019-10-09 15:24:42 +02:00
Quincy Morgan
a3d6097d40
Rename "Fix Me" Requests validation rule to more general Help Requests
...
Add subtypes to almost_junction and disconnected_way validation rules
Add additional validation documentation (re: #6100 )
2019-10-09 15:00:28 +02:00
Quincy Morgan
d57807478e
Start validation documentation (re: #6100 )
...
Add subtypes to close_nodes and unsquare_way validations
2019-10-09 12:43:38 +02:00
Quincy Morgan
7251a2ab90
Make "edited issues" mean "issues the user created" instead of "issues for features edited by the user"
...
Only include issues created by the user in the "warnings" changeset tags
Include counts of issues resolved by the user in the changeset tags (close #6459 )
Don't include "fixme" issue counts in "warnings" changeset tags since they're not created by the user (close #6658 )
Don't cache crossing ways issues at the rule level
2019-10-04 16:50:44 +02:00
Quincy Morgan
badde3d583
Add warning for features with names that equal values in their not:name tag ( close #6411 )
2019-10-04 11:06:27 +02:00
Quincy Morgan
f5995dffb0
Cherry pick crossing buildings fix
2019-10-03 20:09:49 +02:00
Quincy Morgan
0dc890a9ee
Show more specific message when nonstandard brand has simply incomplete tags ( close #6909 )
2019-10-03 15:25:18 +02:00
Quincy Morgan
9ccace9022
Don't warn about websites missing http:// or https:// ( close #6831 )
2019-10-01 18:34:20 +02:00
Quincy Morgan
6a515576f1
Add an "Extract this point" quick fix for points-as-vertices validation warnings (re: #6319 )
2019-10-01 18:21:03 +02:00
Quincy Morgan
525916da74
Recategorize tags_suggests_area validation rule into mismatched_geometry rule
...
Warn about points tagged as vertices and vertices tagged as points (close #6319 )
2019-09-26 10:56:30 +02:00
Quincy Morgan
b8b8c66d02
Warn when multilingual feature names appear to be generic ( close #6876 )
2019-09-24 13:22:02 +02:00
Quincy Morgan
1abcc7fccf
Show warning for elevator nodes that are disconnected from the highway network ( close #6812 )
...
Simplify disconnected way validation code
2019-09-13 15:17:48 -04:00
Quincy Morgan
16747cf888
Cherry pick generic brand name fix
2019-08-15 13:49:02 -05:00
Quincy Morgan
070cfec7c7
Specify that connecting waterways and highways with the fix will add a ford ( close #6734 )
2019-08-09 09:34:35 -05:00
Quincy Morgan
5984f6b118
Don't flag google books as an incompatible data source ( close #6556 )
2019-07-09 09:58:39 -04:00
Quincy Morgan
8003e7b3d3
Allow the layer and level tag to differentiate very close points ( close #6612 )
2019-07-05 10:17:15 -04:00
Bryan Housel
ca2c6b1098
Allow for some tags (takeaway) to be kept thru a NSI upgrade
...
(closes #6530 , closes #6581 )
2019-06-30 01:42:43 -04:00
Bryan Housel
2307125842
Remove existing NSI keys before upgrading to a NSI preset
...
(closes #6575 )
2019-06-30 01:24:42 -04:00
Quincy Morgan
b10ae96d62
Don't suggest adding nonsquare=yes to physically unsquare buildings ( close #6332 )
2019-06-16 18:47:32 -04:00
Quincy Morgan
67f7995559
Avoid stale "connect endpoints" fix for "tags imply area" that could cause invalid areas ( close #6525 )
...
Lower match score for man_made/bridge preset
2019-06-12 09:31:06 -04:00
Quincy Morgan
2eff493d37
Add outdated tags validation issue subtype for noncanonical brands
...
Add specific warning message for noncanonical brands (close #6443 )
Don't allow autofixing noncanonical brand issues
2019-06-10 11:39:42 -04:00
SilentSpike
f402748706
Fix email validation for unicode characters
...
Also fix format validation for lists with excess whitespace (6494#issuecomment-499620002).
2019-06-10 11:02:56 -04:00
