Quincy Morgan
6e0f5c6823
Allow adding vertex-only features from the serach-to-add field
...
Allow favoriting vertex presets
Don't allow adding vertex-only presets as points
Rename Other preset to Vertex
2019-03-04 17:38:08 -05:00
Quincy Morgan
e7ae433467
Merge branch 'master' into add-feature-search-bar
2019-03-02 10:55:32 -05:00
Bryan Housel
3f8911c149
Merge pull request #5999 from openstreetmap/squarish
...
Improve orthogonalization action
2019-03-01 23:28:23 -05:00
Bryan Housel
fab6bd1d33
Support orthogonalizing a single vertex, add tests
...
(closes #2205 )
2019-03-01 23:20:50 -05:00
Bryan Housel
2227c46338
Switch "Square" keyboard shortcut to Q
...
So it doesn't conflict with "Straighten"
(sorry in advance for all the disruption this will cause)
2019-03-01 09:35:35 -05:00
Bryan Housel
b47ab4ac50
Change orthogonalize to support degenerate shapes, non-closed ways
...
Also adds a handful of useful vector math functions to geo module
2019-02-28 22:52:45 -05:00
Quincy Morgan
b6effd6ed0
Add initial search bar UI element
2019-02-28 11:19:40 -05:00
Quincy Morgan
2da011c3ca
Remove unused string
...
Don't show preset browser when adding a favorite point
Don't automatically open the sidebar when selecting a non-new feature
2019-02-27 12:20:23 -05:00
Quincy Morgan
4fabb4aac8
Nicen favorite preset mode button tooltips
2019-02-27 12:03:10 -05:00
Quincy Morgan
ff439ac5b3
Rename "add to favorites" tooltip to "favorite"
2019-02-26 15:32:55 -05:00
Quincy Morgan
a3424aa4b1
Merge branch 'master' into squash-favorite-preset
2019-02-26 14:25:34 -05:00
Quincy Morgan
6aa1f86dfb
Add warning for multipolygon members with no set role ( close #5851 )
2019-02-25 17:46:50 -05:00
Quincy Morgan
b8ac9a7de3
Add toggle-able list of rules to the Issues pane ( close #5979 )
...
Toggling a rule off prevents the validation from running
2019-02-25 15:31:05 -05:00
Brian Hatchl
1faa6ad839
Favorite preset
2019-02-20 15:23:58 -05:00
Quincy Morgan
598827db87
Add quick fix to remove deprecated tags
2019-02-20 10:06:44 -05:00
Quincy Morgan
12a44421c3
Account for indoor features in crossing ways validation
...
Recommend using an appropriate structure/layer/level for crossing ways validation
Flag crossing highways on different levels but without bridges or tunnels
2019-02-19 11:43:05 -05:00
Quincy Morgan
397097ac1f
Tweak issue and fix strings
...
Different strings for one vs. a combination of deprecated tags
2019-02-15 14:24:11 -05:00
Quincy Morgan
1821c3e955
Update fixes UI for icons, link styling, and non-actionable fixes
...
Fix several bugs
2019-02-14 15:56:04 -05:00
Quincy Morgan
c7e861c0ca
Merge branch 'master' into validation
2019-02-14 12:16:23 -05:00
Bryan Housel
c292a32a66
Better message padding, remove double tooltip
2019-02-13 13:47:00 -05:00
Quincy Morgan
9007ccb8fd
Disable preset buttons for hidden layers
2019-02-12 14:43:04 -05:00
Bryan Housel
81bd734849
WIP uiEntityIssues cleanups, simplify
...
fixes are still not being applied properly
2019-02-11 20:44:02 -05:00
Bryan Housel
ac23ac8fd2
Periods in non-sentence message headings look strange
2019-02-11 13:30:28 -05:00
Quincy Morgan
149e1b3e4d
Removed unused string
2019-02-11 11:41:18 -05:00
Quincy Morgan
47ec58e5fc
Don't zoom to the end vertex when continuing a disconnected highway if it is already visible
...
Add separate fixes for continuing a disconnected highway from the start and end vertices
Highlight the vertex that will be continued
2019-02-11 11:29:34 -05:00
Quincy Morgan
db319e8ff5
Merge branch 'master' into validation
2019-02-11 07:59:29 -05:00
SilentSpike
24022416cb
Fix negative number of trips in ImproveOSM issues
...
See https://github.com/openstreetmap/iD/pull/5739#issuecomment-460786055
2019-02-09 16:31:37 +00:00
Bryan Housel
6ff381cb28
Drop "from this key" jargon
2019-02-08 17:01:54 -05:00
Quincy Morgan
33d02cdba0
Add different messages for no tags vs. no descriptive tags warnings
...
Add warning for relation without a "type" tag
2019-02-06 09:38:33 -05:00
Quincy Morgan
c1df48ce0f
Simplify crossing ways warning message
2019-02-05 17:25:34 -05:00
Quincy Morgan
bfefea422b
Use iD's area tag logic for the tag_suggests_area validation
2019-02-05 13:55:59 -05:00
Quincy Morgan
7dd337383a
Add quick fix for connecting the endpoints of a line where tags suggest area if it won't create self-intersection
2019-02-05 12:16:46 -05:00
Quincy Morgan
3808685ee3
Rewrote tag as disconnected fix undo message to be more consistent
2019-02-05 11:29:09 -05:00
Quincy Morgan
0934db48dd
Don't count vertices toward many deletions warnings
...
Lower threshold for triggering many deletions warnings
2019-02-05 09:12:43 -05:00
Quincy Morgan
ca8c91563b
Add issue count to section title in entity editor
...
Remove redundant string
2019-02-04 16:48:54 -05:00
Quincy Morgan
d3946894e8
Standardize deprecated_tag and missing_tag rule type ids
...
Run crossing_ways before disconnected_way
Break out crossing_ways issue creation into a separate function
2019-02-04 16:29:29 -05:00
Quincy Morgan
db5af39134
Tweak no issues info text
2019-02-04 13:40:08 -05:00
Quincy Morgan
190fc4f434
Add message to the issues pane for when there are no issues
2019-02-04 12:06:25 -05:00
Quincy Morgan
872cfe045e
Sorted validation text alphabetically
2019-02-04 11:37:09 -05:00
Quincy Morgan
977e667453
Remove non-functional issue options from UI
2019-02-04 11:15:05 -05:00
Quincy Morgan
d76c33187b
Fix pane list tooltip placement
...
Improve edited features tooltip
2019-02-04 11:02:31 -05:00
Quincy Morgan
a0558102d6
Add correct tags to crossing highway/railway and highway/waterway connection during quick fix
...
Remove unused fix text
2019-02-04 09:57:47 -05:00
Quincy Morgan
6514f645d1
Add error and warning count to the list titles
...
Hide error and warnings lists when there are no errors or warnings
2019-02-04 09:28:01 -05:00
Quincy Morgan
8c51411ad6
Merge branch 'master' into validation
2019-02-04 08:58:10 -05:00
SilentSpike
03a5c26e74
Refer to ImproveOSM QA as detections
2019-02-01 22:51:05 +00:00
SilentSpike
d82757c392
Include node in turn restriction description
...
Clarifies some cases where geometry could be unclear with previous
message.
2019-02-01 22:51:04 +00:00
SilentSpike
60128b0402
Fix one-way error positioning and description
...
The direction of travel in the description was misleading as the way
segment wasn't necessary linear and so the direction could change as you
travel along the way. This is more explicit as it specifies the detected
start/end nodes (also useful to show that it's not the whole way that
might be one-way).
The position is now taken as the central node in the `feature.points`
list (or the average of the central two when there are an even number of
points).
2019-02-01 22:51:03 +00:00
SilentSpike
4157cb1f25
Update QA help string
2019-02-01 22:51:03 +00:00
SilentSpike
31091f1159
Add direction of travel to oneway errors
2019-02-01 22:50:59 +00:00
SilentSpike
214cf41019
Use more generic classes for errors
2019-02-01 22:50:57 +00:00