Commit Graph

11594 Commits

Author SHA1 Message Date
Bryan Housel bfbab475df Upgrade to name-suggestion-index 3.0.1
Also includes presets for
- amenity=prep_school
- office=financial_advisor
2019-05-20 22:12:05 -04:00
Bryan Housel a6a9c85475 Add brand field to amenity=social_centre
(re: https://github.com/osmlab/name-suggestion-index/pull/2639)
2019-05-20 21:30:25 -04:00
Bryan Housel e1331016d1 Merge pull request #6386 from openstreetmap/configurable-squareness
Allow user to adjust the threshold for the unsquare building warning
2019-05-20 21:04:30 -04:00
Bryan Housel 2f0e0dffdb Merge pull request #6389 from openstreetmap/wikidata-style
Support special styling for Wikidata-tagged features
2019-05-20 18:05:29 -04:00
Bryan Housel 69a25fd6aa Move locking code from input and localized up to uiField
Also adjust styles some more for wikidata tagged items
2019-05-20 17:50:50 -04:00
Quincy Morgan 8b0bbd2f9a Add wheelchair field to kerb presets
Recommend adding barrier=kerb to features with just a kerb tag
2019-05-20 16:17:55 -04:00
Quincy Morgan 460f136819 Lower default threshold for unsquare building detection to 5 degrees
Use the detection threshold for the action when fixing unsquare buildings
Don't disallow unsquare autofixing based on maximum angle
Disallow unsquare autofixing for features with wikidata tags
Don't toggle rule when selecting degree threshold field in Safari
Apply the change when pressing enter in the degree threshold field
Select the input when clicking the degree threshold field
Use the min or max threshold instead of the default when an input is out of bounds
2019-05-20 15:48:01 -04:00
Bryan Housel 06bdfbfb8a Use gray stroke on marker and lock icon on field for locked item 2019-05-20 15:36:10 -04:00
Quincy Morgan 39784cdd1f Merge in master 2019-05-20 14:38:52 -04:00
Quincy Morgan 4fb4f88e5a Fix issue where only the first page of mapillary results would be shown (close #6382) 2019-05-20 12:36:12 -04:00
Quincy Morgan e599488121 Lower the very close nodes warning threshold for buildings, building parts, and paths (re: #6374)
Flag very close nodes in indoor features but with an extremely small threshold
2019-05-20 11:21:50 -04:00
Bryan Housel 6eb73e7de6 Don't adjust map labels for wikidata tagged items 2019-05-20 10:55:23 -04:00
Quincy Morgan 289d31ce15 Update green fill CSS 2019-05-20 10:34:34 -04:00
Quincy Morgan d7d46d9365 Add green fill for landuse=recreation_ground 2019-05-20 10:30:18 -04:00
Bryan Housel df699b2dc1 Blacklist EOXAT2018CLOUDLESS, too low resolution 2019-05-20 08:46:21 -04:00
Quincy Morgan 78d3050587 Remove highway=incline and highway=incline_steep deprecations (re: #6392) 2019-05-20 08:45:52 -04:00
Bryan Housel e7b3354db7 Render wikidata tagged items with green stroke only 2019-05-20 00:35:41 -04:00
Bryan Housel 1c97e29b5d No idea why this test keeps failing.. 2019-05-19 22:55:41 -04:00
Bryan Housel e6dde01264 What will make you happy, mocha? 2019-05-19 21:51:33 -04:00
Bryan Housel 0f387c9fcd Include office key for name-suggestion-index matching
In anticipation of https://github.com/osmlab/name-suggestion-index/issues/2634
2019-05-19 21:42:57 -04:00
Bryan Housel b09b43f6d3 Trim the user's string when preset searching
(closes #6383)
2019-05-19 21:37:09 -04:00
Bryan Housel d68c49e66d Async tests running on dodgy Travis containers are not my friends
(closes #6391)

Default timeout of 2000 regularly exceeded, causing spurious test failures.
Even a random garbage collection pause can take more than 2 seconds.
2019-05-19 21:35:16 -04:00
Bryan Housel 0982379187 Don't offer to upgrade brands without a brand:wikidata tag 2019-05-19 00:16:05 -04:00
Bryan Housel 344aec206c Support special styling for wikidata-tagged features 2019-05-18 23:57:23 -04:00
Quincy Morgan 901e808c76 Deprecate leisure=recreation_ground in favor of the more popular landuse=recreation_ground 2019-05-18 17:05:11 -04:00
Bryan Housel 511f8ecc82 Allow user to adjust the threshold for the unsquare building warning 2019-05-18 15:44:29 -04:00
Quincy Morgan 62b32779d3 Add additional vertical padding to multicombo fields 2019-05-18 11:56:14 -04:00
Quincy Morgan 3f628294c0 Add more terms to Transit Shelter preset (close #6381) 2019-05-18 11:52:30 -04:00
Quincy Morgan 936822849a Don't consider "highway=raceway" as routable (#6385)
Update the icon for the raceway preset
2019-05-18 11:49:25 -04:00
Bryan Housel 03dd95e00f pacify eslint 2019-05-17 17:11:20 -04:00
Bryan Housel e97240e35e Allow natural=bay on lines
(closes #6379)
2019-05-17 15:46:20 -04:00
Bryan Housel 3c031f80ea Prioritize suggestion tags over preset tags
Before it was causing presets with special cuisine tags to not match
(e.g. `cuisine=donut;coffee`, `cuisine=ice_cream;burger`)
2019-05-17 12:41:56 -04:00
Bryan Housel e90199d61b Replace maki-ice_cream icon with better fas-ice_cream icon
Also add an unsearchable fast_food/_ice_cream preset
This is for brands like Dairy Queen and Freddy's.
fast_food place with ice cream focus, but also burgers, fries, etc.

The preset is unsearchable because we prefer for users to use the
amenity/ice_cream preset for tagging normal ice cream shops.
2019-05-17 12:37:29 -04:00
Bryan Housel f82241caa8 npm run imagery 2019-05-17 11:40:44 -04:00
Bryan Housel cc4991d111 Don't draw until we've set zoom/lat/long 2019-05-17 11:19:38 -04:00
Bryan Housel 1718a70064 Add "Online Retailer Outpost" preset for shop=outpost
(for name-suggestion-index Russian brand "Wildberries")
2019-05-17 11:08:09 -04:00
Bryan Housel f062570eef Merge pull request #6376 from openstreetmap/routing-island-validation
Flag routing islands
2019-05-17 10:21:51 -04:00
Bryan Housel ec920d24f0 Don't make landuse green by default 2019-05-17 10:11:34 -04:00
Bryan Housel 7a07506edc Skip ambiguous matches (like Target~(USA) vs Target~(Australia))
This also reorders the nsiKeys array to maybe match slightly quicker
2019-05-17 09:45:08 -04:00
Bryan Housel 94c5164fe2 Add ability to show the square threshold in the rule name 2019-05-17 02:15:20 -04:00
Bryan Housel 8d0fa289cf Include name-suggestion-index matcher in outdated_tags validator 2019-05-17 01:58:57 -04:00
Bryan Housel caecbffc18 Upgrade to name-suggestion-index v3.0.0
(closes: #6375, closes: #2032, re: 6361)
2019-05-17 01:01:33 -04:00
Quincy Morgan e697bdbeb1 Flag disconnected ferry routes
Flag disconnected highway multipolygon outer member ways
Let routing islands cross ferry routes
2019-05-17 00:15:53 -04:00
Quincy Morgan 07bc2821cd Flag entire routing islands as single issues 2019-05-16 22:40:25 -04:00
Bryan Housel bdb454e1b3 Remove utilCallWhenIdle, use requestIdleCallback/cancelIdleCallback
Places where a reset or connection switch would be problematic,
we can now cancel the callbacks.
2019-05-16 22:28:56 -04:00
Bryan Housel a8c6ab4d67 Move requestIdleCallback polyfill to id.js, remove utilIdleWorker
`utilIdleWorker` was only used one place.
It just processes a list in an idle callback.

I'm working towards removing the util functions for handling idle work.
We can still do `requestIdleCallback` work throughout the code, however
each place we use it needs to have a strategy for cancellation, which
the existing util functions don't allow for.
2019-05-16 21:19:25 -04:00
Bryan Housel ec0145de3a Prevent accidental loading of many tiles at low zoom
This could happen because `editable` was checked before the call was scheduled
not before the `loadTiles`.  The user can zoom out more while the call is deferred.
2019-05-16 16:44:19 -04:00
Bryan Housel aa7820b699 Don't treat new raw_tag_editor rows the same as deleted rows
(closes #6369)
2019-05-16 15:36:47 -04:00
Quincy Morgan 0ecf7c4d98 Merge branch 'master' of https://github.com/openstreetmap/iD 2019-05-16 14:52:56 -04:00
Quincy Morgan 961a79e4f2 Add photo overlays used during editing to the "source" changeset tag (close #6279) 2019-05-16 14:52:41 -04:00