Bryan Housel
e1331016d1
Merge pull request #6386 from openstreetmap/configurable-squareness
...
Allow user to adjust the threshold for the unsquare building warning
2019-05-20 21:04:30 -04:00
Bryan Housel
2f0e0dffdb
Merge pull request #6389 from openstreetmap/wikidata-style
...
Support special styling for Wikidata-tagged features
2019-05-20 18:05:29 -04:00
Bryan Housel
69a25fd6aa
Move locking code from input and localized up to uiField
...
Also adjust styles some more for wikidata tagged items
2019-05-20 17:50:50 -04:00
Quincy Morgan
460f136819
Lower default threshold for unsquare building detection to 5 degrees
...
Use the detection threshold for the action when fixing unsquare buildings
Don't disallow unsquare autofixing based on maximum angle
Disallow unsquare autofixing for features with wikidata tags
Don't toggle rule when selecting degree threshold field in Safari
Apply the change when pressing enter in the degree threshold field
Select the input when clicking the degree threshold field
Use the min or max threshold instead of the default when an input is out of bounds
2019-05-20 15:48:01 -04:00
Bryan Housel
06bdfbfb8a
Use gray stroke on marker and lock icon on field for locked item
2019-05-20 15:36:10 -04:00
Quincy Morgan
39784cdd1f
Merge in master
2019-05-20 14:38:52 -04:00
Quincy Morgan
4fb4f88e5a
Fix issue where only the first page of mapillary results would be shown ( close #6382 )
2019-05-20 12:36:12 -04:00
Quincy Morgan
e599488121
Lower the very close nodes warning threshold for buildings, building parts, and paths (re: #6374 )
...
Flag very close nodes in indoor features but with an extremely small threshold
2019-05-20 11:21:50 -04:00
Bryan Housel
6eb73e7de6
Don't adjust map labels for wikidata tagged items
2019-05-20 10:55:23 -04:00
Bryan Housel
0f387c9fcd
Include office key for name-suggestion-index matching
...
In anticipation of https://github.com/osmlab/name-suggestion-index/issues/2634
2019-05-19 21:42:57 -04:00
Bryan Housel
b09b43f6d3
Trim the user's string when preset searching
...
(closes #6383 )
2019-05-19 21:37:09 -04:00
Bryan Housel
0982379187
Don't offer to upgrade brands without a brand:wikidata tag
2019-05-19 00:16:05 -04:00
Bryan Housel
344aec206c
Support special styling for wikidata-tagged features
2019-05-18 23:57:23 -04:00
Bryan Housel
511f8ecc82
Allow user to adjust the threshold for the unsquare building warning
2019-05-18 15:44:29 -04:00
Quincy Morgan
936822849a
Don't consider "highway=raceway" as routable ( #6385 )
...
Update the icon for the raceway preset
2019-05-18 11:49:25 -04:00
Bryan Housel
cc4991d111
Don't draw until we've set zoom/lat/long
2019-05-17 11:19:38 -04:00
Bryan Housel
f062570eef
Merge pull request #6376 from openstreetmap/routing-island-validation
...
Flag routing islands
2019-05-17 10:21:51 -04:00
Bryan Housel
7a07506edc
Skip ambiguous matches (like Target~(USA) vs Target~(Australia))
...
This also reorders the nsiKeys array to maybe match slightly quicker
2019-05-17 09:45:08 -04:00
Bryan Housel
94c5164fe2
Add ability to show the square threshold in the rule name
2019-05-17 02:15:20 -04:00
Bryan Housel
8d0fa289cf
Include name-suggestion-index matcher in outdated_tags validator
2019-05-17 01:58:57 -04:00
Quincy Morgan
e697bdbeb1
Flag disconnected ferry routes
...
Flag disconnected highway multipolygon outer member ways
Let routing islands cross ferry routes
2019-05-17 00:15:53 -04:00
Quincy Morgan
07bc2821cd
Flag entire routing islands as single issues
2019-05-16 22:40:25 -04:00
Bryan Housel
bdb454e1b3
Remove utilCallWhenIdle, use requestIdleCallback/cancelIdleCallback
...
Places where a reset or connection switch would be problematic,
we can now cancel the callbacks.
2019-05-16 22:28:56 -04:00
Bryan Housel
a8c6ab4d67
Move requestIdleCallback polyfill to id.js, remove utilIdleWorker
...
`utilIdleWorker` was only used one place.
It just processes a list in an idle callback.
I'm working towards removing the util functions for handling idle work.
We can still do `requestIdleCallback` work throughout the code, however
each place we use it needs to have a strategy for cancellation, which
the existing util functions don't allow for.
2019-05-16 21:19:25 -04:00
Bryan Housel
ec0145de3a
Prevent accidental loading of many tiles at low zoom
...
This could happen because `editable` was checked before the call was scheduled
not before the `loadTiles`. The user can zoom out more while the call is deferred.
2019-05-16 16:44:19 -04:00
Bryan Housel
aa7820b699
Don't treat new raw_tag_editor rows the same as deleted rows
...
(closes #6369 )
2019-05-16 15:36:47 -04:00
Quincy Morgan
961a79e4f2
Add photo overlays used during editing to the "source" changeset tag ( close #6279 )
2019-05-16 14:52:41 -04:00
Quincy Morgan
fa0c05f8f7
Don't render deprecated basin and reservoir features the same as their modern counterparts
2019-05-16 12:35:19 -04:00
Bryan Housel
7be09db9ef
Don't try to change a key/value that's already about to be deleted
...
(closes #6366 )
2019-05-15 14:02:23 -04:00
Quincy Morgan
93a475c9a2
Correct issue with almost junction layer handling
2019-05-14 16:48:24 -04:00
Quincy Morgan
99565e8457
Don't flag crossing waterways and pier highways
2019-05-14 15:39:04 -04:00
Quincy Morgan
8bc634beac
Make the raw member display limit a single variable
2019-05-14 15:31:50 -04:00
Quincy Morgan
49bef3d277
Fix issue where entries in the raw member editor wouldn't update after downloading the member manually ( close #6358 )
2019-05-14 15:31:07 -04:00
Quincy Morgan
a9c30e840c
Revalidate immediately after running most fixes ( close #6354 )
...
Allow individual fixes to control revalidation
Don't allow fixes to run within a second of running any fix for that issue
2019-05-14 14:41:07 -04:00
Quincy Morgan
409968dfc2
Add index of tags that positively identify points or vertices, derived from the presets
...
Delete nodes that can only be vertices when deleting parent ways (close #6230 )
Allow snapping ways to nodes that cannot be positively identified as vertex-only
2019-05-14 12:09:44 -04:00
Quincy Morgan
4eedfa8b25
Don't allow autofixing unsquare buildings unless they are already very close to square
...
Allow autofixing buildings with tags
2019-05-13 16:28:08 -04:00
Quincy Morgan
bb4aa84a3b
Don't flag almost junction issues between features on different layers or levels ( close #6355 )
2019-05-13 13:03:34 -04:00
Quincy Morgan
401c3a5005
Fix issue with the Label field by changing the class name of form-field-label ( close #6344 )
2019-05-13 10:36:21 -04:00
Quincy Morgan
b4b91dcb9e
Revalidate the related entities of deleted entities when revalidating ( close #6345 )
2019-05-10 15:46:04 -04:00
Quincy Morgan
d1ad5a431f
Don't check if data is downloaded for operations in the walkthrough
2019-05-10 12:44:02 -04:00
Quincy Morgan
ea1773f953
Fix error upon starting the walkthrough from the Help pane
2019-05-10 12:34:24 -04:00
Quincy Morgan
36a564f453
Add explicit check for very close nodes with an identical location
2019-05-10 12:14:29 -04:00
Quincy Morgan
7a6949aa2e
Account for the width of open panes when centering the map on issues
2019-05-10 11:33:59 -04:00
Quincy Morgan
1bbd496dfe
When selecting an issue in the Issues pane, highlight the issue after selecting the feature
...
Use the same behavior when selecting an issue in the commit sidebar as in the issues pane
2019-05-10 10:18:46 -04:00
Quincy Morgan
8de10def2a
Use actionMergeNodes instead of operationMerge for the very close nodes issue fix ( close #6343 )
2019-05-10 09:12:11 -04:00
Quincy Morgan
ad744a75ef
Use "nonsquare" instead of "nosquare" for marking unsquare ways as physically unsquare (re: #6332 )
2019-05-09 19:11:11 -04:00
Quincy Morgan
7b441ab766
Don't flag unsquare buildings connected to building multipolygons
2019-05-09 18:06:40 -04:00
Quincy Morgan
58e6afd3ea
Don't flag very close nodes in boundaries
2019-05-09 17:50:22 -04:00
Quincy Morgan
f264cc47f0
Don't flag almost junctions when endpoint is building or parking entrance
...
Include issues for disabled rules in entity issues
2019-05-09 14:38:19 -04:00
Quincy Morgan
0e7a63f5c5
Add quick fix to unsquare way validation to tag a way as having unsquare corners ( close #6332 )
2019-05-09 12:04:18 -04:00