Quincy Morgan
977e667453
Remove non-functional issue options from UI
2019-02-04 11:15:05 -05:00
Quincy Morgan
2677a88df4
Zoom to ways and relations upon clicking on their issues in the issues pane
2019-02-04 10:27:35 -05:00
Quincy Morgan
6514f645d1
Add error and warning count to the list titles
...
Hide error and warnings lists when there are no errors or warnings
2019-02-04 09:28:01 -05:00
Quincy Morgan
8c51411ad6
Merge branch 'master' into validation
2019-02-04 08:58:10 -05:00
SilentSpike
9403f71140
Track closed ImproveOSM errors via coordinates
2019-02-01 23:31:08 +00:00
SilentSpike
183dda5999
Pacify eslint
2019-02-01 22:51:04 +00:00
SilentSpike
ee5f9f3bf2
Use consistent short service name
2019-02-01 22:51:02 +00:00
SilentSpike
54e02ec28d
Introduce new container icon for errors
...
As per my last commit, this icon differentiates errors from points and
still allows us to specifiy icons for errors to differentiate them amongst
eachother.
I learned quite a bit about SVGs and using them in HTML while
implementing this 😝 Had some issues getting the icon to center in the
header so resorted to using a flexbox instead of absolute positioning
being used elsewhere.
2019-02-01 22:51:02 +00:00
SilentSpike
9d2792836f
Add ImproveOSM error resolution
2019-02-01 22:50:58 +00:00
SilentSpike
ac4cec1429
Add sidebar preview for ImproveOSM errors
2019-02-01 22:50:57 +00:00
SilentSpike
214cf41019
Use more generic classes for errors
2019-02-01 22:50:57 +00:00
SilentSpike
9600d67fc6
Differentiate missing geometry errors by colour
2019-02-01 22:50:56 +00:00
SilentSpike
ca290b5101
Add details to error messages
2019-02-01 22:50:55 +00:00
SilentSpike
23a4d71410
Handle turn restriction errors
2019-02-01 22:50:55 +00:00
SilentSpike
4f2646d567
Add basic title + description UI
2019-02-01 22:50:54 +00:00
SilentSpike
4d89810721
Add ImproveOSM service
...
Only processing one-way errors for now
2019-02-01 22:50:54 +00:00
Quincy Morgan
251d83f86c
Show warnings and errors in different lists in the issues pane
2019-02-01 16:38:48 -05:00
Quincy Morgan
19cc6399fe
Merge branch 'master' into validation
2019-02-01 15:20:38 -05:00
Bryan Housel
d1fca87d79
Replace Edit Documentation link with pencil icon
...
(closes #5753 )
2019-02-01 11:49:03 -05:00
Quincy Morgan
46f3cea33a
Reorganize validation code
...
Rename IssueManager to coreValidator
Rename disconnected highway to disconnected way
Rename highway almost junction to almost junction
Rename mapcss checks to maprules
Rename deprecated tags to deprecated tag
2019-02-01 11:20:51 -05:00
Quincy Morgan
49d62721d8
Fix background layer UI bugs
...
Add semicolon
2019-01-30 16:10:01 -05:00
Quincy Morgan
77c4d41855
Restore many deletions warning with tooltip and nicer message
...
Add tooltips back to issues pane list
Fix crash when restoring without having loaded the edited area
2019-01-30 15:48:06 -05:00
Quincy Morgan
19a2a60bf4
Add tooltip to disabled upload button to specify what is blocking the upload
2019-01-30 13:20:56 -05:00
Quincy Morgan
94c8f9f9f7
Update text for features to edit
2019-01-29 14:48:18 -05:00
Quincy Morgan
907c4d9616
Rename fix function from action to onClick
2019-01-29 12:18:02 -05:00
Quincy Morgan
80c7aedb39
Fix bug with issues pane
2019-01-29 11:59:01 -05:00
Quincy Morgan
b48445b29a
Make the first issue's fix list appear by default
2019-01-29 09:56:44 -05:00
Quincy Morgan
0866110d77
Merge branch 'master' into validation
2019-01-29 09:16:06 -05:00
Bryan Housel
af8fb1d758
Show combobox if we are moving from a different active combobox
...
(closes #5752 )
Previously it would go down the `hide()` branch anytime an existing combobox
was active.
2019-01-28 16:22:37 -05:00
Bryan Housel
49442afe0c
In raw member editor, cancel combobox on blur if it hasn't been accepted
2019-01-28 15:41:50 -05:00
Bryan Housel
d0021f77ca
Handle possibility of combobox blurring without dispatching accept
2019-01-28 13:43:40 -05:00
Quincy Morgan
f25a80c48c
Merge branch 'master' into validation
2019-01-28 12:14:04 -05:00
Bryan Housel
87ddfa68dc
Revert 55715a482 - caused raw_tag_editor combos to not blur in Safari
2019-01-28 11:20:32 -05:00
Bryan Housel
b9444ab991
Restore hand cursor on dropdown carat
...
(closes #5769 )
This change allows pointer events to flow to the caret, and forwards
them back to the combo input. Also renames several event handlers
for clarity, and increases the double-click detection threshold.
2019-01-26 13:22:31 -05:00
Bryan Housel
18d71448be
pacify eslint
2019-01-25 16:23:46 -05:00
Bryan Housel
5d6e331635
Don't erase name field when tabbing from it
...
(closes #5760 )
2019-01-25 16:16:07 -05:00
Bryan Housel
55715a4827
Try to dispatch an accept event on blur
...
(re: #5752 - but does not close it)
2019-01-25 14:47:17 -05:00
Quincy Morgan
314e822a84
Merge master into validation
2019-01-25 10:03:40 -05:00
Quincy Morgan
f2f4c2d9c7
Make optional multiCombo fields appear if a value exists ( closes #5764 )
2019-01-25 09:43:07 -05:00
Quincy Morgan
decba8f215
Fix cycleway field to appear if "cycleway" tag present but not "cycleway:left" nor "cycleway:right" ( close #5756 )
2019-01-25 08:39:15 -05:00
Quincy Morgan
33ae009936
Clarify wording of old_multipolygon issue and tooltip
...
Add quick fix for old_multipolygon issue
2019-01-24 11:01:41 -05:00
Quincy Morgan
01e2370cbd
Add background color to the issue pane list
2019-01-24 08:37:46 -05:00
Quincy Morgan
7b288ef95d
Add basic zoom-to-clicked-issue behavior
2019-01-23 15:25:55 -05:00
Quincy Morgan
e69f2a0389
Merge branch 'master' into validation
2019-01-23 13:15:33 -05:00
Bryan Housel
fa1edc86a1
Another place where we should delimit name suggestion on en-dash
...
see 20bcfc573
2019-01-23 09:57:43 -05:00
Bryan Housel
20bcfc5730
Delimit name-suggestion-preset names on en-dash, not hyphen
...
To avoid conflicts with hyphenated names, or bilingual names
with hyphens in them (like used in Brussels)
2019-01-23 09:44:24 -05:00
Bryan Housel
4583e2d4d7
Make sure all combo event listeners can handle accept/cancel w/o datum
...
(re: #5637 , re: #5618 )
This can happen if the user enters a value that is not matched to
one of the combo suggestions.
Also make sure to set `this` to the input field. It might not be
already if the event was triggered from a keypress instead of a click.
2019-01-22 23:14:34 -05:00
Bryan Housel
0c7b9a631e
Improve combobox event handling and avoid overwriting typed data
...
(closes #5722 , re: #5637 , re: #5618 )
dispatched with a value() string instead of a datum, which
causes issues for code expecting a datum always.
(such as localized.js brand picker or "Add Field" combo)
Fix for this coming in next commit.
2019-01-22 22:26:27 -05:00
Quincy Morgan
1323ec3d5a
Map Data and Background panes no longer reload hidden sections
2019-01-21 15:52:58 -05:00
Quincy Morgan
35ac247ff0
Fixes an issue where panel sections wouldn't render when toggled if hidden on page load ( closes #5743 )
2019-01-21 15:22:50 -05:00