ea05d4e672
Unhighlight features when clicking issue quick fix ( close #6219 )
2019-04-26 16:26:19 -07:00
3fad3513c1
Don't zoom to the feature and remove hover-highlighting upon clicking the issue fix button in the issues pane
2019-04-26 16:05:10 -07:00
239c622044
Don't tag redundant ignored warnings counts on changesets
2019-04-26 13:02:13 -07:00
228af9a000
Move areaKeys and setAreaKeys to modules/osm/tags
2019-04-26 12:53:05 -07:00
ecc217f5d8
Add validation rule to flag impossible oneway highways and waterways ( close #6216 )
2019-04-26 12:04:43 -07:00
7d29a98a14
Add subtype to some validation issues
2019-04-25 10:35:27 -07:00
f2ca5316b0
Add total ignored warnings count to changeset tags (re: #6123 )
2019-04-25 09:34:07 -07:00
6eeaf94076
Show members of selected relations even when their feature layer is otherwise hidden ( close #6220 )
2019-04-24 17:28:56 -07:00
42de00e640
Add validation warning for "fixme" tags ( close #6214 )
2019-04-24 16:59:57 -07:00
aa91c2d768
Move old multipolygon warning into Outdated Tags rule ( close #6218 )
2019-04-24 15:46:50 -07:00
6a9c7b97a8
Don't flag websites on residential buildings
2019-04-24 15:21:49 -07:00
13f7e536dc
Move highway=road validation warning to the missing_tag validation rule (re: #6218 )
2019-04-24 15:19:57 -07:00
b30c91828f
Don't flag buildings with lots of nodes or buildings connected to other buildings as unsquare (re: #6215 )
2019-04-24 14:52:41 -07:00
d01bb78707
Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys ( close #6237 )
2019-04-24 13:45:59 -07:00
05949608aa
Support straightening of points
...
(closes #6217 )
- Split `actionStraighten` into `actionStraightenWay` and `actionStraightenNodes`
- Now `operationStraighten` chooses the correct action depending on selected entities
- Also move `getSmallestSurroundingRectangle` from `actionReflect` to `geo.js`
2019-04-24 01:55:43 -04:00
34fcd01f98
Add validation warning for unsquare buildings
2019-04-23 15:50:52 -07:00
a37ce90af7
Move "Fix All" from bottom of list to top
2019-04-23 17:42:14 -04:00
4948474118
Set the default validation filters to be My Edits / Everywhere (re: #6223 )
2019-04-23 10:34:10 -07:00
7e04175559
Add Enable All / Disable All validation rules links
...
(closes #5986 )
2019-04-23 13:01:15 -04:00
1d4770a3c6
Merge pull request #6211 from AndreasHae/feature/split-multiple-tags
...
Handle multiple tags when splitting up in tag editor
2019-04-23 11:05:03 -04:00
bd2a33d845
Merge branch 'validation_and_change_perf'
2019-04-23 01:30:26 -04:00
a3bc164c43
Redraw entity editor fields on addition, deletion too
...
This is important to make the turn restriction editor work
2019-04-23 01:07:38 -04:00
7dce4bb161
Avoid asking DOM if layers are classed disabled in map.editable
...
`map.editable` is hot code because it's called frequently by the `isHiddenX`
tests in `features.js`. It's much more efficient to just ask the osm layer
whether it is enabled, than to use D3 to find that layer in the DOM and check
whether it's classed `disabled`
2019-04-22 22:12:42 -04:00
61da61d7fd
Add missing button arg to modeDrawLine, ensure using current entities
2019-04-22 20:00:53 -04:00
3fe9d75f35
Fix issues with issue cache for entities that no longer exist
2019-04-22 19:35:23 -04:00
e04d860f62
Convert "Detach" operation into "Extract" operation that also works on areas ( close #6203 )
2019-04-22 14:46:01 -07:00
e49fdce215
Add missing semicolons
2019-04-22 23:43:55 +02:00
2596b97dbc
Do not use ES6 features
2019-04-22 16:38:33 +02:00
faa178797d
Handle multiple tags when splitting up
2019-04-22 16:22:59 +02:00
e4fc821eb0
Just use reduce
2019-04-22 09:49:17 -04:00
3557e3c711
Don't allow disconnecting a way if parts extend to undownloaded tiles
...
(re: #2248 , #4245 )
2019-04-20 00:02:46 -04:00
bbf4495f5c
pacify eslint
2019-04-19 23:44:49 -04:00
7c85cc997e
Merge branch 'master' into validation_and_change_perf
2019-04-19 22:44:04 -04:00
b566ef05b5
Add Option+W shortcut to toggle the OSM data layer ( close #6104 )
2019-04-19 14:51:53 -07:00
a892114351
Fix disconnection code test ( close #4245 )
2019-04-19 13:26:16 -07:00
51c1088c1b
Merge branch 'master' into validation_and_change_perf
2019-04-19 15:18:23 -04:00
130e9909f6
Allow disconnecting an entire way from other ways at once ( close #4245 )
2019-04-19 11:54:13 -07:00
b5c5a00abc
Get rid of the many_deletions validation 🔪
...
It just doesn't fit in with all of the other validations that work on
entities, and it's not an actionable warning anyway.
https://github.com/openstreetmap/iD/pull/6140#issuecomment-483014618
2019-04-19 13:33:29 -04:00
2ebbb68604
Restore tooltips on rule checkboxes, separate 'tip' and 'reference'
...
Reference will show on clicking info button, and can contain more
useful information than a tooltip can.
2019-04-19 13:24:55 -04:00
4d66cacb27
Nodes needs Array.length not Set.size
2019-04-19 11:04:41 -04:00
1092ddb125
Make sure to update the save count when restoring changes too
2019-04-19 10:56:00 -04:00
ae06e28f9b
Try to avoid style recalculation when typing on the comment box
...
I think this doesn't completely work.. It reduces the amount
of unnecessary DOM changes, but there are still some more.
2019-04-19 10:02:25 -04:00
ca02f7ed06
Must use context.graph to validate entities instead of validatedgraph
...
This is because all the validators use it, and it's the right thing to do.
As entites load from the OSM or are restored from history, the most
updated version of them will be in context.graph, not validatedGraph
2019-04-19 10:00:38 -04:00
c4209515a5
Only consider hiding features matched to a rule
...
(Fixes accidental hiding of vertices)
2019-04-18 19:26:17 -04:00
a56c1af725
pacify eslint
2019-04-18 19:26:05 -04:00
a55b4387fe
Make sure the notification badge starts out hidden
2019-04-18 19:06:23 -04:00
0eed80e1d2
Persist disabled rules in localStorage
2019-04-18 17:30:55 -04:00
2f695a9747
Add link to the PeWu history viewer to the History panel ( close #6202 )
2019-04-18 14:06:48 -07:00
7c8a6eac9d
Reintroduce disabled rules
...
- They still run, but results are excluded from lists
- Also make sure to revalidate/dispatch/update when toggling rules
2019-04-18 17:05:33 -04:00
a30051fd9c
Restore full screen ability
2019-04-18 10:37:22 -07:00
Quincy Morgan