Commit Graph

2593 Commits

Author SHA1 Message Date
Quincy Morgan
d09e76ccad Merge branch 'master' into validation 2019-02-05 11:18:59 -05:00
Quincy Morgan
23ab1b66fb Revert "Update places of worship to use field inheritance"
This reverts commit 44d4f2378d.
2019-02-05 11:06:31 -05:00
Quincy Morgan
7763626b02 Add access_simple field to library preset
Update Website field placeholder to use https
2019-02-05 10:22:43 -05:00
Quincy Morgan
44d4f2378d Update places of worship to use field inheritance
Add website to defaults fields for places of worship
Add presets for common place of worship denominations
2019-02-05 10:16:22 -05:00
Quincy Morgan
0934db48dd Don't count vertices toward many deletions warnings
Lower threshold for triggering many deletions warnings
2019-02-05 09:12:43 -05:00
Quincy Morgan
ca8c91563b Add issue count to section title in entity editor
Remove redundant string
2019-02-04 16:48:54 -05:00
Quincy Morgan
d3946894e8 Standardize deprecated_tag and missing_tag rule type ids
Run crossing_ways before disconnected_way
Break out crossing_ways issue creation into a separate function
2019-02-04 16:29:29 -05:00
Quincy Morgan
db5af39134 Tweak no issues info text 2019-02-04 13:40:08 -05:00
Quincy Morgan
ac7dba082f Merge branch 'master' into validation 2019-02-04 13:35:21 -05:00
Bryan Housel
b340b65df4 Improve "club" icons
(closes #5854)
2019-02-04 13:35:12 -05:00
Bryan Housel
002f3ba590 switch far-clock to temaki-clock (one less clock icon) 2019-02-04 13:16:19 -05:00
Quincy Morgan
190fc4f434 Add message to the issues pane for when there are no issues 2019-02-04 12:06:25 -05:00
Quincy Morgan
872cfe045e Sorted validation text alphabetically 2019-02-04 11:37:09 -05:00
Quincy Morgan
977e667453 Remove non-functional issue options from UI 2019-02-04 11:15:05 -05:00
Quincy Morgan
d76c33187b Fix pane list tooltip placement
Improve edited features tooltip
2019-02-04 11:02:31 -05:00
Quincy Morgan
a0558102d6 Add correct tags to crossing highway/railway and highway/waterway connection during quick fix
Remove unused fix text
2019-02-04 09:57:47 -05:00
Quincy Morgan
6514f645d1 Add error and warning count to the list titles
Hide error and warnings lists when there are no errors or warnings
2019-02-04 09:28:01 -05:00
Quincy Morgan
8c51411ad6 Merge branch 'master' into validation 2019-02-04 08:58:10 -05:00
Bryan Housel
96a15934ca Don't snake_case values for destination and destination:ref fields
(closes #5842)

But continue to snake_case the values for `destination:symbol`
2019-02-02 12:05:19 -05:00
SilentSpike
03a5c26e74 Refer to ImproveOSM QA as detections 2019-02-01 22:51:05 +00:00
SilentSpike
d82757c392 Include node in turn restriction description
Clarifies some cases where geometry could be unclear with previous
message.
2019-02-01 22:51:04 +00:00
SilentSpike
60128b0402 Fix one-way error positioning and description
The direction of travel in the description was misleading as the way
segment wasn't necessary linear and so the direction could change as you
travel along the way. This is more explicit as it specifies the detected
start/end nodes (also useful to show that it's not the whole way that
might be one-way).

The position is now taken as the central node in the `feature.points`
list (or the average of the central two when there are an even number of
points).
2019-02-01 22:51:03 +00:00
SilentSpike
4157cb1f25 Update QA help string 2019-02-01 22:51:03 +00:00
SilentSpike
31091f1159 Add direction of travel to oneway errors 2019-02-01 22:50:59 +00:00
SilentSpike
214cf41019 Use more generic classes for errors 2019-02-01 22:50:57 +00:00
SilentSpike
39880e559b Add direction of travel to turn restriction errors 2019-02-01 22:50:56 +00:00
SilentSpike
bea6f4dcfd Use point averages for locations 2019-02-01 22:50:56 +00:00
SilentSpike
ca290b5101 Add details to error messages 2019-02-01 22:50:55 +00:00
SilentSpike
4f2646d567 Add basic title + description UI 2019-02-01 22:50:54 +00:00
SilentSpike
4d89810721 Add ImproveOSM service
Only processing one-way errors for now
2019-02-01 22:50:54 +00:00
Quincy Morgan
5a309fd57a Merge branch 'master' into validation 2019-02-01 16:47:10 -05:00
Bryan Housel
491ec40435 Ditch the separate linear platform presets for public transport
(closes #5837)
2019-02-01 16:42:52 -05:00
Quincy Morgan
251d83f86c Show warnings and errors in different lists in the issues pane 2019-02-01 16:38:48 -05:00
Bryan Housel
e50b82d2ad Ditch the separate linear platform presets for public transport
(closes #5837)
2019-02-01 16:38:33 -05:00
Quincy Morgan
19cc6399fe Merge branch 'master' into validation 2019-02-01 15:20:38 -05:00
Bryan Housel
d1fca87d79 Replace Edit Documentation link with pencil icon
(closes #5753)
2019-02-01 11:49:03 -05:00
Quincy Morgan
46f3cea33a Reorganize validation code
Rename IssueManager to coreValidator
Rename disconnected highway to disconnected way
Rename highway almost junction to almost junction
Rename mapcss checks to maprules
Rename deprecated tags to deprecated tag
2019-02-01 11:20:51 -05:00
Bryan Housel
bde55bd7ee Update presets for new community index 2019-02-01 11:02:42 -05:00
Quincy Morgan
09bc2a6e6c Merge branch 'master' into validation 2019-01-30 16:44:14 -05:00
Quincy Morgan
77c4d41855 Restore many deletions warning with tooltip and nicer message
Add tooltips back to issues pane list
Fix crash when restoring without having loaded the edited area
2019-01-30 15:48:06 -05:00
Bryan Housel
71b2d2c6b7 Upgrade legacy symbols in tests
- iD.Context -> iD.coreContext
- iD.Graph -> iD.coreGraph
- iD.Node -> iD.osmNode
- iD.Way -> iD.osmWay
- iD.Relation -> iD.osmRelation
2019-01-30 15:43:02 -05:00
Quincy Morgan
19a2a60bf4 Add tooltip to disabled upload button to specify what is blocking the upload 2019-01-30 13:20:56 -05:00
Quincy Morgan
3782acfc88 Merge branch master into validation 2019-01-29 16:52:59 -05:00
Quincy Morgan
6df2c24b14 Add Continue and Delete quick fixes for disconnected highway issue 2019-01-29 16:45:28 -05:00
Bryan Housel
7e3f08b31a Restore missing paths_intersect string needed for #5745 2019-01-29 15:09:49 -05:00
Quincy Morgan
0b19d5f93a Merge branch master into validation 2019-01-29 14:51:59 -05:00
Quincy Morgan
94c8f9f9f7 Update text for features to edit 2019-01-29 14:48:18 -05:00
Quincy Morgan
fedad280b4 Use different messages for crossing tunnels and bridges if they are connectable 2019-01-29 14:30:42 -05:00
Bryan Housel
ad3f491116 Replace maki "M" museum icon
(closes #5751)
2019-01-29 13:51:34 -05:00
Quincy Morgan
742147c62b Don't validate water areas or specific highway, waterway, or railway features 2019-01-29 13:31:02 -05:00