Commit Graph

10363 Commits

Author SHA1 Message Date
Quincy Morgan
d09e76ccad Merge branch 'master' into validation 2019-02-05 11:18:59 -05:00
Quincy Morgan
23ab1b66fb Revert "Update places of worship to use field inheritance"
This reverts commit 44d4f2378d.
2019-02-05 11:06:31 -05:00
Quincy Morgan
7763626b02 Add access_simple field to library preset
Update Website field placeholder to use https
2019-02-05 10:22:43 -05:00
Quincy Morgan
44d4f2378d Update places of worship to use field inheritance
Add website to defaults fields for places of worship
Add presets for common place of worship denominations
2019-02-05 10:16:22 -05:00
greenkeeper[bot]
91285bc4f0 chore(package): update esm to version 3.2.1 2019-02-05 10:00:15 -05:00
Quincy Morgan
0934db48dd Don't count vertices toward many deletions warnings
Lower threshold for triggering many deletions warnings
2019-02-05 09:12:43 -05:00
Quincy Morgan
a23954d886 Fix issue where preset reset buttons would not initially work 2019-02-05 08:24:34 -05:00
Quincy Morgan
7329d1301a Fix issues where save button would not enable and save blocker tooltip would not disappear 2019-02-04 19:08:43 -05:00
Quincy Morgan
c39c584b52 Fix false positive for deprecated tag validation 2019-02-04 18:36:42 -05:00
Quincy Morgan
ca8c91563b Add issue count to section title in entity editor
Remove redundant string
2019-02-04 16:48:54 -05:00
Quincy Morgan
d3946894e8 Standardize deprecated_tag and missing_tag rule type ids
Run crossing_ways before disconnected_way
Break out crossing_ways issue creation into a separate function
2019-02-04 16:29:29 -05:00
Quincy Morgan
01c4c46918 Improve crossing ways validation performance by reducing garbage collection 2019-02-04 15:41:22 -05:00
Quincy Morgan
4921a32be1 Improve performance of crossing ways validation 2019-02-04 15:22:07 -05:00
Quincy Morgan
451704ca7b Remove check to see if ways were already checked in the crossing ways validation 2019-02-04 15:07:37 -05:00
Quincy Morgan
fae9d603eb Match commit errors section background color to primary error color 2019-02-04 13:45:12 -05:00
Quincy Morgan
db5af39134 Tweak no issues info text 2019-02-04 13:40:08 -05:00
Quincy Morgan
ac7dba082f Merge branch 'master' into validation 2019-02-04 13:35:21 -05:00
Bryan Housel
b340b65df4 Improve "club" icons
(closes #5854)
2019-02-04 13:35:12 -05:00
Quincy Morgan
bfb5285dc9 Fix tests and lint warnings 2019-02-04 13:34:27 -05:00
Bryan Housel
002f3ba590 switch far-clock to temaki-clock (one less clock icon) 2019-02-04 13:16:19 -05:00
Bryan Housel
2d7800582f Upgrade FontAwesome to 5.7 2019-02-04 13:06:51 -05:00
Bryan Housel
7fe0380d7d Make sure icon fill colors can be overridden 2019-02-04 13:01:35 -05:00
Quincy Morgan
b3d49f0978 Merge branch 'master' into validation 2019-02-04 12:10:45 -05:00
Quincy Morgan
190fc4f434 Add message to the issues pane for when there are no issues 2019-02-04 12:06:25 -05:00
Quincy Morgan
872cfe045e Sorted validation text alphabetically 2019-02-04 11:37:09 -05:00
Quincy Morgan
c2d72cf434 Make sure the vertex is visible when using the "continue this feature" quick fix for disconnected way 2019-02-04 11:30:48 -05:00
Quincy Morgan
977e667453 Remove non-functional issue options from UI 2019-02-04 11:15:05 -05:00
Quincy Morgan
d76c33187b Fix pane list tooltip placement
Improve edited features tooltip
2019-02-04 11:02:31 -05:00
Quincy Morgan
2677a88df4 Zoom to ways and relations upon clicking on their issues in the issues pane 2019-02-04 10:27:35 -05:00
Bryan Housel
3efd8dbe2d Merge pull request #5852 from AndreasHae/5844-lanes-preset-usability
Improve number field usability
2019-02-04 10:11:03 -05:00
Andreas Haessler
82ea58d943 Add default value to number field 2019-02-04 15:59:08 +01:00
Quincy Morgan
a0558102d6 Add correct tags to crossing highway/railway and highway/waterway connection during quick fix
Remove unused fix text
2019-02-04 09:57:47 -05:00
Quincy Morgan
6514f645d1 Add error and warning count to the list titles
Hide error and warnings lists when there are no errors or warnings
2019-02-04 09:28:01 -05:00
Quincy Morgan
8c51411ad6 Merge branch 'master' into validation 2019-02-04 08:58:10 -05:00
Bryan Housel
e4e0d9d13a Add oneway icon for ImproveOSM oneway markers 2019-02-03 23:55:16 -05:00
Bryan Housel
ebdf6431f7 Support classing of aerialway and piste, and adjust line widths
(closes #5843)
2019-02-02 15:32:36 -05:00
Bryan Housel
f1b5efc81a Revise the list of oneway aerialways (notably, drop yes)
(re: #5843)
2019-02-02 15:30:42 -05:00
Bryan Housel
96a15934ca Don't snake_case values for destination and destination:ref fields
(closes #5842)

But continue to snake_case the values for `destination:symbol`
2019-02-02 12:05:19 -05:00
Bryan Housel
6be72709d5 Adjust tag_classes perimeter overrides to style barriers as lines
(closes #5761)
2019-02-02 11:52:23 -05:00
Bryan Housel
3f2abbe7c6 Merge pull request #5739 from SilentSpike/ImproveOSM
Add ImproveOSM Q/A Layer
2019-02-01 20:03:36 -05:00
SilentSpike
9403f71140 Track closed ImproveOSM errors via coordinates 2019-02-01 23:31:08 +00:00
SilentSpike
c9e249ee6c Send only relevant query parameters 2019-02-01 23:14:54 +00:00
SilentSpike
e9397aa14f Fix incorrect usage of osm.userDetails callback
Javascript is not my usual domain so still getting used to how scope
works and working with callbacks. Believe this code is now written as
intended.

As a bonus a response status to the error update request which isn't the
expected 200 now returns before visibly removing the error and adding it
to the closed cache.
2019-02-01 22:51:05 +00:00
SilentSpike
03a5c26e74 Refer to ImproveOSM QA as detections 2019-02-01 22:51:05 +00:00
SilentSpike
21824e6377 Fix coincident errors
Potential for multiple missing turn restrictions on one node and I've
also seen a case of missing one-way along the same stretch of road in
opposite directions!

Missing geometry is tile based so can't really be coincident, but
doesn't hurt to check in case they happen to land on a one-way or turn
restriction.
2019-02-01 22:51:04 +00:00
SilentSpike
183dda5999 Pacify eslint 2019-02-01 22:51:04 +00:00
SilentSpike
d82757c392 Include node in turn restriction description
Clarifies some cases where geometry could be unclear with previous
message.
2019-02-01 22:51:04 +00:00
SilentSpike
60128b0402 Fix one-way error positioning and description
The direction of travel in the description was misleading as the way
segment wasn't necessary linear and so the direction could change as you
travel along the way. This is more explicit as it specifies the detected
start/end nodes (also useful to show that it's not the whole way that
might be one-way).

The position is now taken as the central node in the `feature.points`
list (or the average of the central two when there are an even number of
points).
2019-02-01 22:51:03 +00:00
SilentSpike
4157cb1f25 Update QA help string 2019-02-01 22:51:03 +00:00
SilentSpike
45ce4e4c57 Move turn restriction error position slightly 2019-02-01 22:51:02 +00:00