Commit Graph

2215 Commits

Author SHA1 Message Date
Quincy Morgan
0934db48dd Don't count vertices toward many deletions warnings
Lower threshold for triggering many deletions warnings
2019-02-05 09:12:43 -05:00
Quincy Morgan
a23954d886 Fix issue where preset reset buttons would not initially work 2019-02-05 08:24:34 -05:00
Quincy Morgan
7329d1301a Fix issues where save button would not enable and save blocker tooltip would not disappear 2019-02-04 19:08:43 -05:00
Quincy Morgan
c39c584b52 Fix false positive for deprecated tag validation 2019-02-04 18:36:42 -05:00
Quincy Morgan
ca8c91563b Add issue count to section title in entity editor
Remove redundant string
2019-02-04 16:48:54 -05:00
Quincy Morgan
d3946894e8 Standardize deprecated_tag and missing_tag rule type ids
Run crossing_ways before disconnected_way
Break out crossing_ways issue creation into a separate function
2019-02-04 16:29:29 -05:00
Quincy Morgan
01c4c46918 Improve crossing ways validation performance by reducing garbage collection 2019-02-04 15:41:22 -05:00
Quincy Morgan
4921a32be1 Improve performance of crossing ways validation 2019-02-04 15:22:07 -05:00
Quincy Morgan
451704ca7b Remove check to see if ways were already checked in the crossing ways validation 2019-02-04 15:07:37 -05:00
Quincy Morgan
ac7dba082f Merge branch 'master' into validation 2019-02-04 13:35:21 -05:00
Quincy Morgan
bfb5285dc9 Fix tests and lint warnings 2019-02-04 13:34:27 -05:00
Bryan Housel
7fe0380d7d Make sure icon fill colors can be overridden 2019-02-04 13:01:35 -05:00
Quincy Morgan
b3d49f0978 Merge branch 'master' into validation 2019-02-04 12:10:45 -05:00
Quincy Morgan
190fc4f434 Add message to the issues pane for when there are no issues 2019-02-04 12:06:25 -05:00
Quincy Morgan
c2d72cf434 Make sure the vertex is visible when using the "continue this feature" quick fix for disconnected way 2019-02-04 11:30:48 -05:00
Quincy Morgan
977e667453 Remove non-functional issue options from UI 2019-02-04 11:15:05 -05:00
Quincy Morgan
2677a88df4 Zoom to ways and relations upon clicking on their issues in the issues pane 2019-02-04 10:27:35 -05:00
Andreas Haessler
82ea58d943 Add default value to number field 2019-02-04 15:59:08 +01:00
Quincy Morgan
a0558102d6 Add correct tags to crossing highway/railway and highway/waterway connection during quick fix
Remove unused fix text
2019-02-04 09:57:47 -05:00
Quincy Morgan
6514f645d1 Add error and warning count to the list titles
Hide error and warnings lists when there are no errors or warnings
2019-02-04 09:28:01 -05:00
Quincy Morgan
8c51411ad6 Merge branch 'master' into validation 2019-02-04 08:58:10 -05:00
Bryan Housel
e4e0d9d13a Add oneway icon for ImproveOSM oneway markers 2019-02-03 23:55:16 -05:00
Bryan Housel
ebdf6431f7 Support classing of aerialway and piste, and adjust line widths
(closes #5843)
2019-02-02 15:32:36 -05:00
Bryan Housel
f1b5efc81a Revise the list of oneway aerialways (notably, drop yes)
(re: #5843)
2019-02-02 15:30:42 -05:00
Bryan Housel
6be72709d5 Adjust tag_classes perimeter overrides to style barriers as lines
(closes #5761)
2019-02-02 11:52:23 -05:00
SilentSpike
9403f71140 Track closed ImproveOSM errors via coordinates 2019-02-01 23:31:08 +00:00
SilentSpike
c9e249ee6c Send only relevant query parameters 2019-02-01 23:14:54 +00:00
SilentSpike
e9397aa14f Fix incorrect usage of osm.userDetails callback
Javascript is not my usual domain so still getting used to how scope
works and working with callbacks. Believe this code is now written as
intended.

As a bonus a response status to the error update request which isn't the
expected 200 now returns before visibly removing the error and adding it
to the closed cache.
2019-02-01 22:51:05 +00:00
SilentSpike
21824e6377 Fix coincident errors
Potential for multiple missing turn restrictions on one node and I've
also seen a case of missing one-way along the same stretch of road in
opposite directions!

Missing geometry is tile based so can't really be coincident, but
doesn't hurt to check in case they happen to land on a one-way or turn
restriction.
2019-02-01 22:51:04 +00:00
SilentSpike
183dda5999 Pacify eslint 2019-02-01 22:51:04 +00:00
SilentSpike
d82757c392 Include node in turn restriction description
Clarifies some cases where geometry could be unclear with previous
message.
2019-02-01 22:51:04 +00:00
SilentSpike
60128b0402 Fix one-way error positioning and description
The direction of travel in the description was misleading as the way
segment wasn't necessary linear and so the direction could change as you
travel along the way. This is more explicit as it specifies the detected
start/end nodes (also useful to show that it's not the whole way that
might be one-way).

The position is now taken as the central node in the `feature.points`
list (or the average of the central two when there are an even number of
points).
2019-02-01 22:51:03 +00:00
SilentSpike
45ce4e4c57 Move turn restriction error position slightly 2019-02-01 22:51:02 +00:00
SilentSpike
ee5f9f3bf2 Use consistent short service name 2019-02-01 22:51:02 +00:00
SilentSpike
54e02ec28d Introduce new container icon for errors
As per my last commit, this icon differentiates errors from points and
still allows us to specifiy icons for errors to differentiate them amongst
eachother.

I learned quite a bit about SVGs and using them in HTML while
implementing this 😝Had some issues getting the icon to center in the
header so resorted to using a flexbox instead of absolute positioning
being used elsewhere.
2019-02-01 22:51:02 +00:00
SilentSpike
5d907c1e16 Render errors like points with icons
This allows more diverse representation of the error subject at a glance
than relying on colour alone.

However, it would be good to have a generic error icon that can contain
icons which is differentiated from the point icon for clarity.

Sidebar header currently still uses the bolt icon until I figure out
how to deal with that. Also the font awesome icons don't seem to work,
perhaps there's additional code needed for those that I've missed.
2019-02-01 22:51:01 +00:00
SilentSpike
4a166d7a5b Use more descriptive key names 2019-02-01 22:51:01 +00:00
SilentSpike
88a59cb15f Stop hijacking the inflight cache
This could result in error updates getting aborted when new errors are
loaded as their individual ids are never going to match tile IDs (see
`abortUnwantedRequests` function).
2019-02-01 22:51:01 +00:00
SilentSpike
fe73b3df5a Improve error icon position and appearance 2019-02-01 22:51:00 +00:00
SilentSpike
3334abf776 Remove some unnecessary code 2019-02-01 22:51:00 +00:00
SilentSpike
31091f1159 Add direction of travel to oneway errors 2019-02-01 22:50:59 +00:00
SilentSpike
6bdd0cfa89 Fix missing semicolons 2019-02-01 22:50:58 +00:00
SilentSpike
3174db76b7 Fix north direction in some error descriptions 2019-02-01 22:50:58 +00:00
SilentSpike
9d2792836f Add ImproveOSM error resolution 2019-02-01 22:50:58 +00:00
SilentSpike
ac4cec1429 Add sidebar preview for ImproveOSM errors 2019-02-01 22:50:57 +00:00
SilentSpike
214cf41019 Use more generic classes for errors 2019-02-01 22:50:57 +00:00
SilentSpike
39880e559b Add direction of travel to turn restriction errors 2019-02-01 22:50:56 +00:00
SilentSpike
9600d67fc6 Differentiate missing geometry errors by colour 2019-02-01 22:50:56 +00:00
SilentSpike
bea6f4dcfd Use point averages for locations 2019-02-01 22:50:56 +00:00
SilentSpike
ca290b5101 Add details to error messages 2019-02-01 22:50:55 +00:00