Commit Graph

12628 Commits

Author SHA1 Message Date
SilentSpike d4723ec9e2 Read icons from qa_errors.json when building data
Also adds support for the following error types:
- Objects mapped as both node/area or way/area
- Power lines that lead to nowhere
- Extra nodes in power lines (which should only go from support to
support to endpoint)
- Power line supports with no power lines
2020-02-03 23:20:30 +00:00
SilentSpike 5afdfc527b Add support for more Osmose error types
- Missing parking access
- Malformed opening hours tagging
- Objects detected by Mapillary that aren't mapped
- Traffic sign information detected by Mapillary that isn't mapped

Mapillary errors add example code for special error type handling as
they don't need to request further details and can use piecewise
translation strings
2020-02-03 23:01:03 +00:00
SilentSpike b24b041335 Add Osmose issue detail fetching for UI
Must fetch details per-issue to get the associated OSM elements for
highlighting and use in the error description.

Also fixes URL for error closure.
2020-02-03 23:01:03 +00:00
SilentSpike ebd206595a Use Osmose tiles API endpoint instead of issues
- Simplifies our code a little bit
- Quick to provide and gives us the `item` + `class` without requesting
all other information (the two things needed to know the error type)
- Removed handling of associated elements for now, need to implement
fetching for that data on a per-issue basis when the UI loads
- Set things up for the possibility of using the provided translation
strings (need to determine if desirable)

See: https://github.com/osm-fr/osmose-frontend/issues/193
2020-02-03 23:01:03 +00:00
SilentSpike 680fdb6b54 Allow Osmose errors to use category for UI strings
Some error types don't require unique strings and can share common
strings among the category. This makes that possible as well as adding
support for some other types of error for demonstrative purposes.
2020-02-03 23:01:02 +00:00
SilentSpike d9ba63aa3f Fix leftover errors and unused definitions 2020-02-03 23:01:02 +00:00
SilentSpike 1fa888069d Fix resolution request for Osmose issues
- Remove leftover code that caused undefied variable error
- Change to a GET request
2020-02-03 23:01:02 +00:00
SilentSpike 947f9657db Port minor QoL tweaks to other QA services
Use of MouseEnter and MouseLeave is nicer for SVGs since it won't fire
multiple times (shouldn't happen hear anyway as only one element).

Triggering redraw after forcing related elements visible causes them to
render without having to pan manually.
2020-02-03 23:01:01 +00:00
SilentSpike af5b64a477 Allow translation with numerical token replacement
Just escapes the special regex characters when creating a new RegExp so
that numerical keys can be used (e.g. my use case of replacing an
arbitrary number of tokens from an array). Otherwise it is interpreted
as a repetition.
2020-02-03 23:01:01 +00:00
SilentSpike 09e7b23665 Add Osmose issues UI and filtering
Filters out errors not present in the data .json file to enable
selective support since Osmose has a wide variety of errors which may be
too advanced for iD.

Also added processing for the elements associated with an error for
forced visibility and highlighting.
2020-02-03 23:01:01 +00:00
SilentSpike e11d97b38c Add Osmose QA layer and service
Initial implementation - need to add UI for the errors and correctly set
up support for the desired error types provided by osmose.
2020-02-03 23:01:01 +00:00
Bryan Housel dff56c17d5 Upgrade fontawesome versions, to avoid pulling different svg files 2020-02-03 17:45:06 -05:00
Bryan Housel 6b2d236ecd Pass in the validator to the function 2020-02-03 17:40:56 -05:00
Bryan Housel cd5c3c54a4 Fix uiFieldWikipedia tests
- should be `iD.data.wmf_sitematrix` not `iD.data.wikipedia`
2020-02-03 17:26:04 -05:00
Bryan Housel eb0c297bbd Rewrite the issue gathering code to not use for..of 2020-02-03 17:25:34 -05:00
Quincy Morgan 13d8c078b4 Fix weak preset check 2020-02-03 13:58:34 -05:00
Quincy Morgan 3370bea588 Add derived data for #7289 2020-02-03 13:58:12 -05:00
Quincy Morgan 1fd3e15e6b Merge pull request #7289 from ToastHawaii/2.x
Add simple access to advertising
2020-02-03 13:37:35 -05:00
Bryan Housel 4aa4686e7f Fix test failures in localized and suspicious_names 2020-02-03 12:38:17 -05:00
Bryan Housel b2b2689fb2 Use the ES6 export for martinez-polygon-clipping 2020-02-03 12:38:17 -05:00
Quincy Morgan b4bc5305a1 Enable the issues section for multiple selected features (close #7324) 2020-02-03 12:17:14 -05:00
Quincy Morgan e7c3ba0fd7 Show the same fields for the same features in multiselection regardless of what order they were selected in 2020-02-03 11:13:29 -05:00
Quincy Morgan 4a5e988762 Leave a margin at the bottom of the inspector regardless of whether the relation membership section is shown 2020-02-03 10:47:23 -05:00
Quincy Morgan f4eb8fe484 Update fontawesome icons 2020-02-03 10:36:06 -05:00
Quincy Morgan 2cd425eebb Update country-coder to 3.1.0 (re: #7311) 2020-02-03 09:04:36 -05:00
Quincy Morgan 4627a158f8 Merge pull request #7323 from animesh-007/7296
added new preset, fixes #7296
2020-02-03 08:57:02 -05:00
animesh-007 54fa13be7e added new preset 2020-02-03 17:43:52 +05:30
Bryan Housel 06eac7c9d0 Don't bundle the nsi brands anymore, fetch from CDN at runtime
(re: #4994)
2020-02-01 17:40:56 -05:00
Bryan Housel 743dc0a83a Don't bundle the nsi brands anymore, fetch from CDN at runtime
(re: #4994)
2020-01-31 22:07:21 -05:00
Bryan Housel ab3b731d66 Merge pull request #7310 from animesh-007/7274-new
Added new preset, fixes #7274
2020-01-31 15:21:01 -05:00
Quincy Morgan 208f3d5d1c Add Incline field to rail presets
Use field inheritance for rail presets
2020-01-31 14:58:12 -05:00
animesh-007 813afc073e added new feature 2020-02-01 01:11:57 +05:30
Quincy Morgan 04bd811fde Merge pull request #7306 from openstreetmap/multiselection-field-editing
Enable field editing in multiselection
2020-01-31 14:36:42 -05:00
animesh-007 fb52e2d5b5 added new feature 2020-02-01 00:58:50 +05:30
Quincy Morgan 1c7a150854 Fix issue with fields in commit UI 2020-01-31 14:26:33 -05:00
Quincy Morgan 3f5374e154 Deprecate tunnel=1 2020-01-31 14:12:26 -05:00
Quincy Morgan 2783408fc3 Add tooltips to mixed values in semicombo, multicombo, and radio fields 2020-01-31 14:07:16 -05:00
Quincy Morgan af928e3dc1 Support radio fields during multiselections 2020-01-31 13:02:30 -05:00
Quincy Morgan 8d9adbd902 Lock the name field if any of the selected features should be locked (re: #7306) 2020-01-31 11:23:42 -05:00
Quincy Morgan b3262a71dc Use newlines instead of semicolons to separate mutliselection tag values in tooltips (re: #7306) 2020-01-31 10:49:31 -05:00
Quincy Morgan 103be60112 Add tactile_paving field to bus and trolleybus stops (close #7307) 2020-01-31 10:10:40 -05:00
Quincy Morgan 5cd65efd6e Update generic aerialway and aeroway preset names to include "Feature"
Add icon to generic power preset
2020-01-31 10:07:55 -05:00
Quincy Morgan 512d8974a6 Merge branch '2.x' into multiselection-field-editing 2020-01-30 17:20:04 -05:00
Bryan Housel 6e5cb45c17 Don't bundle the imagery anymore, fetch from dist/data at runtime
(re: #4994)
2020-01-30 17:10:41 -05:00
Quincy Morgan 15e9599ff7 Support editing the Name and Multilingual Name fields during multiselection 2020-01-30 17:09:19 -05:00
Quincy Morgan d57d660d1b Merge branch '2.x' into multiselection-field-editing 2020-01-30 14:42:11 -05:00
SilentSpike 9131514722 Create dist/data before building data 2020-01-30 18:53:39 +00:00
Quincy Morgan 1b331bb678 Add mechanism for fields to support editing during multiselection (re: #7276)
Add `utilCombinedTags` method and use it for the raw tag editor as well as fields
Pass `entityIDs` array into fields instead of single `entity` object
Give field revertion its own path separate from `change`
Add multiselection editing to fields in files: access, address, check, combo, cycleway, input, maxspeed, textarea, and wikidata
2020-01-30 13:53:29 -05:00
Bryan Housel 1e21eea745 Still actually need a devDependency on oci to build icons,translations 2020-01-30 10:00:50 -05:00
Bryan Housel 33a2dafc10 Fetch wmf-sitematrix from CDN.. No need to depend on it anymore. 2020-01-30 09:48:37 -05:00