f45e97d727
Variable cleanups
2018-12-12 16:13:32 -05:00
d28b269b4c
Speed up the scrolling on Firefox Linux too
...
(re: #5512 )
This just changes
`detected.os === 'win'` to `detected.os !== 'mac'`
2018-12-12 15:45:55 -05:00
17615da0ea
Listen to both change and blur for role switcher, compare old v new
...
(closes #5449 )
2018-12-12 15:27:14 -05:00
e08bfb2add
Simplify accept/cancel event dispatchers, store datum in _choice
2018-12-12 15:26:18 -05:00
84f96574d7
Add index property to cloned object, not actual member object
...
(closes #5458 )
This code was adding an `index` property to each member in the relation.
Although the `index` property is ignored by the code that saves to OSM,
the extra property would make the member changed when compared by
`coreDifference`.
2018-12-12 02:07:03 -05:00
c635389c1a
Fix handling of semicolon delimited values in numeric field
...
(closes #5438 )
2018-12-12 01:11:34 -05:00
fc1f7e4d46
Trigger a change event when accepting combo option with return, tab
...
(closes #4900 , closes #5449 )
Some browsers need an explicit `change` event triggered on the input field
when a value has been changed by the combo and accepted by pressing return
or tab. This was only an issue on combos that aren't part of uiFields,
since the uiFields are all setup to respond to `change`,`input`,`blur` etc.
2018-12-11 23:25:47 -05:00
ec51ebb026
Fix flexbox of raw membership editor new row
...
(closes #5589 )
2018-12-11 21:54:25 -05:00
3de03439e2
Use user's locale for fetching wikidata label/description
...
(closes #5563 )
2018-12-11 19:02:29 -05:00
9aceb8f725
Fix lazy instantiation of the fields
...
They are shown either if `_show=true` or `isPresent()`
2018-12-11 19:01:23 -05:00
13b1a9a629
If imagery becomes invalid, remove it from imagery_used
...
(closes #4827 )
2018-12-11 17:49:15 -05:00
577e0c6503
Don't add "None" to imagery_used tag when other imagery was used
...
(closes #5565 )
2018-12-11 16:37:52 -05:00
0d958f04c1
Don't try to render a field that's not yet shown
2018-12-11 16:37:36 -05:00
ddf10d00aa
Merge branch 'combobox-perf'
2018-12-11 16:12:00 -05:00
39b3f1df68
Avoid creating comboboxes
...
(closes #5568 )
Several strategies in here:
- Move uiCombobox() from inside the render function to class variable
- Don't render stuff like the raw tag editor when it's collapsed
- Don't show as many fields/combos on hover
- Don't instantiate fields (like universal/more) until they're actually shown
- Bind the combo on enter selection not on update selection
2018-12-11 16:07:00 -05:00
222b3f1b04
Don't render contents of collapsed sections
...
(speeds things up if raw tag editor is hidden)
2018-12-11 15:19:29 -05:00
5eaa3d0d44
chore(package): update mapillary-js to version 2.14.1
2018-12-11 09:19:51 -05:00
a868284aba
Merge pull request #5584 from RudyTheDev/traffic_calming_area_grass
...
Grass surface rendering for traffic calming areas
2018-12-11 01:22:44 -05:00
6732ca6eda
Comboboxes no longer show on focus.. update tests
2018-12-11 01:19:51 -05:00
ff646fa2c8
Dispatch a 'cancel' event if the user hits escape
2018-12-11 00:09:55 -05:00
6cf1d63b48
Make sure dropdown doesn't remain visible
...
(closes #5575 )
Also improves keyboard navigation, and adds some scrollintoview
workarounds to make sure that the selected option is visible
while also not causing the whole page to move.
2018-12-10 23:54:06 -05:00
15a54cab17
Use context.container instead of passing it in
2018-12-10 14:14:27 -05:00
e5dedeff8b
Move lib/d3.combobox.js -> ui/combobox.js
...
As with other things from this lib/ folder, little original code remains
and turning these things into reusable d3 plugins is not a priority.
2018-12-10 12:38:21 -05:00
54a4546306
WIP to avoid _wrapper state variable, move towards combobox singleton
2018-12-10 12:15:50 -05:00
34cdb129c6
Add grass surface rendering for traffic calming areas
2018-12-10 17:41:53 +02:00
3aa7dcfc0c
Allow some kinds of traffic calmings to be mapped as areas
...
(closes #5562 )
2018-12-10 10:23:29 -05:00
de59dd5d86
No padding needed for save count if it is being wrapped or narrow
2018-12-09 23:42:18 -05:00
5c9f9ac012
Always show save count 0.. makes responsivness easier
...
(closes #5576 )
2018-12-09 23:31:52 -05:00
4b3ce2c07c
Add basin=* Type and intermittent fields to Basin preset
...
(closes #5497 )
2018-12-09 23:13:15 -05:00
2c0e975955
Add basin=* Type and intermittent fields to Basin preset
...
(closes #5497 )
2018-12-09 23:11:14 -05:00
905f362317
Upgrade to maki v6.0.0
...
(closes #5559 )
2018-12-09 22:43:42 -05:00
5774226ebf
Update all fontawesome dependencies
...
(closes #5571 , closes #5572 )
2018-12-09 22:05:02 -05:00
c14ec72f5b
chore(package): update rollup-plugin-node-resolve to version 4.0.0
2018-12-09 22:02:31 -05:00
05c24c95df
Add an icon for grit bin
2018-12-09 21:32:01 -05:00
86085151e1
Fix misspelling - accidentally
2018-12-09 21:16:26 -05:00
f9552e6eea
Merge pull request #5582 from quincylvania/more-fields
...
Define additional preset-specific fields for the "Add field" dropdown
2018-12-09 14:19:37 -08:00
4285f2f5c0
Added "moreFields" property to the field schema
...
The "Add field" dropdown can now be used to add preset-specific fields in addition to universal fields
2018-12-09 13:51:57 -08:00
cbcafaee15
Make sure sidebar is expanded before entering walkthrough or saving
...
(closes #5574 )
2018-12-08 10:03:43 -05:00
49c53088c0
Merge branch 'field-updates'
2018-12-07 17:59:52 -05:00
7fd06f69b8
Use .select instead of .selectAll to propagate the bound data
...
(closes #5573 )
2018-12-07 17:46:14 -05:00
d574bfcd77
Disable autocomplete on the localized field
...
(closes #5558 )
2018-12-07 17:19:02 -05:00
247900f727
Change several of the event things, remove numeric index
...
re: https://github.com/openstreetmap/iD/issues/5558#issuecomment-445307568
2018-12-07 16:54:32 -05:00
f8f5b690b7
Merge pull request #5561 from quincylvania/wi-fi-hotspot-preset-matchscore
...
Lowers the match score for the Wi-Fi Hotspot preset
2018-12-05 19:36:09 -08:00
73d7f35afe
Lowered the match score for the Wi-Fi Hotspot preset
2018-12-05 19:34:18 -08:00
77a9dde6f7
Make sure combobox can always receive arrow and esc events
2018-12-05 15:59:06 -05:00
b494684e4f
v2.12.1
2018-12-05 01:58:18 -05:00
fe4a903df2
npm run translations
2018-12-05 01:53:51 -05:00
bee01d8497
Destroy all old background layer tooltips before making new ones
...
(closes #5551 )
2018-12-05 00:35:45 -05:00
4bfc78c69b
Merge pull request #5555 from quincylvania/walkthrough-crash-fix
...
Fixes an issue where the walkthrough would not display and cause an error
2018-12-04 17:33:52 -08:00
b366ace770
Switches from == to === in prior commit
2018-12-04 17:33:39 -08:00
Bryan Housel