Commit Graph

2056 Commits

Author SHA1 Message Date
Martin Raifer
f3e8852808 don't select option on ambiguous multi-key radio fields
this matches the behaviour of a multi-selection: all matching options are still highlighted, but the radio-option is not set.

also fixes a minor bug with multi-selections not taking `<key> = no` properly into account

closes #8796
2021-11-09 15:10:47 +01:00
Martin Raifer
2f9285e011 improve rendering of turn-restriction boxes in narrow sidebars
Previously the applied paddings were too large for narrow sidebars, causing the turn-restriction min-map view to be much more zoomed out than needed.
This tweaks the paddings such that even for the slimmest sidebar the rendering is still acceptable (i.e. no turn arrows to be rendered completely outside of the viewport) and at the same time allows generous margins for wider sidebars.

This also fixes a minor bug where the mini-map is not properly alligned vertically
2021-11-05 14:46:53 +01:00
Martin Raifer
a30856eb83 fix clipped tooltips on controls bar (#8791)
* controls: add wrapper div to not clip tooltips

* bind wheel to controlsWrap
minor z-index change

* scrollbar for ie/firefox

Co-authored-by: Milos Brzakovic (E-Search) <mbrzakovic@microsoft.com>
2021-11-05 11:41:23 +01:00
Minh Nguyễn
810ce60c18 Fixed roadheight placeholders
The standard field’s placeholder is no longer relevant because it is formatted as a list of raw tag values rather than of localized numbers.
2021-10-25 21:52:54 -07:00
Minh Nguyễn
5f58b533ff Added roadheight field with unit dropdowns 2021-10-25 17:38:41 -07:00
Kyle Hensel
d08c09f5ee show an error if local storage is full 2021-09-30 19:41:15 +13:00
Milos Brzakovic
bc75430528 Merge pull request #8288 from jleedev/preset-debounce
Debounce input events in the preset list.
2021-09-15 11:49:40 +02:00
Milos Brzakovic
e495c99102 Merge pull request #8685 from openstreetmap/mapControl-scroll
MapControl scroll
2021-09-14 11:35:42 +02:00
Milos Brzakovic
f08b89f4c3 Merge pull request #8663 from openstreetmap/issue_key_8655
More validator fixes
2021-09-14 11:34:58 +02:00
Milos Brzakovic
7e31120ec6 added scrol to mapControl 2021-09-10 15:26:37 +02:00
Bryan Housel
9e3df2c4aa Create an issue key property that changes when data needs refresh
(closes #8655)
2021-08-27 17:13:36 -04:00
Kyle Hensel
416c1af372 add link button next to website tag 2021-08-19 15:17:45 +12:00
Milos Brzakovic
d0577b0364 Merge pull request #8626 from openstreetmap/validator
Validator improvements
2021-08-09 18:07:01 +02:00
Milos Brzakovic
c8aedcbb79 minor trailing spaces 2021-08-05 18:36:25 +02:00
Milos Brzakovic
021d777c9d changelog instead of ideditor.blog 2021-08-03 20:02:37 +02:00
Bryan Housel
857b9c9adf Exclude 'fixme'/'help_request' warnings from changeset tags.
They still appear in the issue list and in the entity editor.
(closes #8603)
2021-08-02 14:34:18 -04:00
Josh Lee
effc8fed58 Debounce input events in the preset list.
On a slow machine, the preset list is painfully slow to search, as it
rerenders the list on every keystroke, which takes several hundred
milliseconds. By debouncing this, it is able to keep up.

Performance analysis:

Before: Typing the word 'stream' results in a 2.5s frame according to
Chrome's profiler. Each input event takes between 300 and 600 ms to run.

After: Typing the word 'stream' results in three 300ms frames. The first
and last input events take around 200ms, while the four in the middle
are ignored by the debouncer.
2021-07-06 11:12:34 +00:00
Milos Brzakovic (E-Search)
d2036996e3 Merge conflicts resolved 2021-07-05 10:26:44 +02:00
Milos Brzakovic
70b95e4fc8 Merge pull request #8341 from jleedev/fix-centroid
Fix centroid calculation in measurement panel.
2021-06-21 19:47:46 +02:00
Bryan Housel
b47952b369 Move the complicated linkification code from iD to resolveStrings
It's easier to insert the links there, and then the HTML strings are availble for anyone who wants them
2021-04-30 11:26:24 -04:00
Bryan Housel
25bf950458 Upgrade to osm-community-index (oci) v4
The main differences here is:
- oci now supports default strings and exports a "resolveStrings" function
- this makes linkifying any urls embedded in descriptions a bit more complicated
  because urls and descriptions might need resolution, we can't use iD's normal
  t() function to do the token replacement like before
2021-04-29 17:53:53 -04:00
Bryan Housel
a0b7f9f99f Pass d3_event to click handler 2021-03-12 09:55:38 -05:00
Bryan Housel
2b7adf89fa Remember user's preference for expanding issue-info section
This shows the tag diff, and other helpful information about the detected issues.
It is expanded by default now
(closes #6408, closes #8143)
2021-03-08 15:10:30 -05:00
Josh Lee
ac6251cf9e Fix centroid calculation in measurement panel.
Copy/paste of 0a0e2dcf75
2021-02-23 18:11:02 +00:00
Bryan Housel
90bbe38fe8 Remove the brand combo from the name field
This has caused problems going back a long time, and now that we have a validator
and very visible brand presets with logos, it's not necessary anymore.
(re: #5558, closes #8271, closes #8304)
2021-02-12 10:41:47 -05:00
Bryan Housel
f87c2d9357 Allow validators to return provisional results, revalidate after delay
Also add a ton of commments to validator.js
2021-01-27 10:38:48 -05:00
Bryan Housel
96298f2836 Preserve name value if this preset shows brand or operator field
This also fixes the logic for calculating whether the preset shows a
`brand` or `operator` field - it needs to use `fields()` to actually
resolve the fields, as these fields can be inherited from another preset.

This also includes a change to match "primary" names before
"alternate" names (aka the "Baby Gap" / "Gap" problem)
2021-01-19 13:15:16 -05:00
Bryan Housel
4228b65602 Support more *:wikidata tags for field locking and pin styling 2021-01-18 17:18:37 -05:00
Bryan Housel
868db8819f Have mergeLocationSets work on Objects, add locationSetID property
This means less work for the other parts of the code,
now they don't need to chain that extra step after the promise.
2021-01-09 10:34:58 -05:00
Bryan Housel
c4daf1b377 Use locationManager to resolve/query community index 2021-01-08 17:05:37 -05:00
Bryan Housel
271e1c2e19 Use locationManager to filter fields/presets/defaults 2021-01-08 16:06:57 -05:00
Quincy Morgan
e57793fab0 Use full width semicombo field for Via field (re: https://github.com/openstreetmap/id-tagging-schema/issues/104) 2021-01-05 11:07:00 -05:00
Quincy Morgan
c61924407d Add icon styling for Mountain Biking Route preset (re: https://github.com/openstreetmap/id-tagging-schema/issues/99) 2020-12-21 10:08:55 -05:00
Quincy Morgan
d57ed85e98 Merge branch develop 2020-12-16 11:43:36 -05:00
Bryan Housel
9e93701c58 Update osm-community-index to v3.0.1
The major version bump is because
- it no longer distributes index.js/index.mjs code bundles
   (which iD hasn't needed in a long time anyway)
- renamed dist/features.json -> dist/featureCollection.json
2020-12-16 09:25:11 -05:00
Quincy Morgan
c8c288d6a3 Support using delete/backspace on focused, readonly combo fields
Make custom combo field values lowercase if they're also made snake_case
2020-12-09 15:26:45 -05:00
Quincy Morgan
cb7f1c2b3c Update to id-tagging-schema v3.0.0
Add UI for translatable combo fields
2020-12-08 15:23:51 -05:00
Quincy Morgan
17cd39a6f7 Use addTags for preset category icon classes 2020-12-07 15:17:20 -05:00
Quincy Morgan
998f0c02b4 Use area fills for category icons (close #6986) 2020-12-07 14:55:09 -05:00
Quincy Morgan
7911152dec Merge branch 'develop' into unbundled-presets
# Conflicts:
#	dist/locales/en.json
2020-12-07 10:57:14 -05:00
Quincy Morgan
40362f1d08 Fix issue with removing multilingual name entries 2020-12-04 11:59:51 -05:00
Quincy Morgan
0bc2b1b6a0 Improve multilingual name UI updates, don't use blank tag values (re: #8164) 2020-12-04 10:22:18 -05:00
Quincy Morgan
0bd2351d68 Don't remove multilingual name list items when deleting the name value (close #8164)
Allow removing multilingual name list items that don't have full values
2020-12-03 16:26:58 -05:00
Quincy Morgan
a85ac34a35 Add tooltip to the review request checkbox (close #7227) 2020-12-03 13:50:56 -05:00
Quincy Morgan
9f6aaf2438 Add folder border to preset category icons (close #6085) 2020-12-03 13:13:08 -05:00
Quincy Morgan
07a59ba3a4 Break out some preset icon functions (re: #8117) 2020-12-03 12:23:09 -05:00
Quincy Morgan
2dd0b8449f Rewrite some confusing nested ternaries (close #8117) 2020-12-03 12:18:39 -05:00
Quincy Morgan
baabd81987 Unbundle id-tagging-schema data and translations
Update for id-tagging-schema 2.0.0
2020-12-01 11:14:14 -05:00
Quincy Morgan
ba48a861bc Enable curly and block-spacing eslint rules 2020-11-10 14:19:11 -05:00
Quincy Morgan
d247ec3aed Enable brace-style eslint rule 2020-11-10 13:49:48 -05:00