Commit Graph

412 Commits

Author SHA1 Message Date
Martin Raifer
6239cc0ccc Merge branch 'maxlength-indicator' into develop 2022-12-02 18:37:59 +01:00
Martin Raifer
dcd7fb4938 don't include misspelled taginfo suggestions in combo fields 2022-12-02 13:49:49 +01:00
Martin Raifer
d5872cca73 show prettier maxChars warning for changeset comments
from #9392
2022-11-28 19:08:37 +01:00
Martin Raifer
6c9ffdc854 lint 2022-11-26 10:28:20 +01:00
Martin Raifer
59b10b7974 add length indicator for semicombo fields as well 2022-11-25 18:52:13 +01:00
Martin Raifer
2c0ca277bf add max-length-indicator to combo fields 2022-11-25 18:18:51 +01:00
Martin Raifer
f931d447af add length indicator to regular text (and localized) fields 2022-11-25 18:10:14 +01:00
Martin Raifer
5091966056 [WIP] add string length indicator and max-length message 2022-11-25 17:48:33 +01:00
Martin Raifer
f573c374c2 number field: improve +/- buttons
* Clamp degree values in `direction` fields between 0 and 359 degrees, fixes #9386
* Only match cardinal values to numbers in `direction` fields
* Disable increment/decrement buttons on number fields if the input value is not numeric or when there is a multi-selection with conflicting values
* Fix/implement reverse operation for semicolon delimited `direction` values
2022-11-24 15:16:49 +01:00
Martin Raifer
d9a4d6cbde Fix crash when multiselection has differing values in combo field
closes #9369
2022-11-12 22:03:28 +01:00
Martin Raifer
9d8116ff6d don't indent combo content when there is no icon for tag value 2022-11-08 19:29:23 +01:00
Martin Raifer
635c498548 make tag value icons work for translatable strings, too 2022-11-08 19:20:47 +01:00
Martin Raifer
62113dcf74 improve icons in comboboxes: update while typing, fix spacings
also makes sure checkbox & radio are aligned with the left padding of the respective input fields
2022-11-08 18:48:06 +01:00
Martin Raifer
ef044cd17d Show icons depicting the different values of the crossing:markings field
for https://github.com/openstreetmap/id-tagging-schema/pull/590
2022-11-08 13:47:39 +01:00
Martin Raifer
501011ef4d use colour field type instead of relying on the tag key
see #9320
2022-11-08 13:16:08 +01:00
Martin Raifer
a6be05966b improve comboboxes: (#9344)
* pressing return/enter doesn't deselect the entity anymore
* predefined ("static") field options are always listed in the combobox dropdown, even if taginfo doesn't include them (because of low usage)
* (raw) tag values can also be entered for localized strings
* static localized strings can be used before taginfo response is received (useful when taginfo is slow or unavailable)
* fixes some bugs which can be triggered when taginfo is slow
* fixes a bug where the autocomplete dropdown doesn't work properly when tags have "few" values
* multiCombo fields can be case-sensitive now
2022-11-08 12:09:06 +01:00
Kyℓe Hensel
2bf92b42b9 fix the phone input field showing the wrong placeholder (#9316) 2022-11-01 18:56:48 +01:00
Martin Raifer
34a414ee18 make checkbox fields work with cross referenced string 2022-11-01 17:58:36 +01:00
Martin Raifer
e8b0c5c7cd fix leaking of localized strings in combo fields when taginfo is unavailable
fixes #9342

and fall back to populate such fields with "static" options if taginfo service is offline
2022-10-25 16:33:59 +02:00
Martin Raifer
cb1202883f fix export 2022-10-18 13:58:38 +02:00
Martin Raifer
b2b6cb5c19 add support for field type colour
see https://github.com/ideditor/schema-builder/pull/38
2022-10-18 11:56:05 +02:00
Martin Raifer
d349baad1e fix loading of non-auto-suggested combo options
this was a typo/regression in b5e987b75
2022-10-17 18:35:00 +02:00
Martin Raifer
b5e987b755 fetch options from referenced strings 2022-10-13 19:18:55 +02:00
Martin Raifer
674421eec7 implement fetching string references
see https://github.com/openstreetmap/id-tagging-schema/pull/598
2022-10-07 12:04:23 +02:00
Martin Raifer
a2cacaaf24 Don't auto-suggest undocumented tag values which have fewer than 100 uses
* previously, this check was based on the "fraction" of the respective tag value, which excluded more values for common tag keys, but fewer for less common ones.
* this sets a limit of 100 uses for undocumented tags (key=value pairs)
* tags with a wiki page are always allowed
* this harmonizes the heuristic of which tags to show between preset fields and the raw tag editor (previously, there was an additional `count > 10` filter present in combo fields, which is now uncessary)

closes #9227
2022-08-01 19:10:18 +02:00
Kyℓe Hensel
81f3b0666c support incrementing cardinal directions with the 🔼/🔽 buttons (#9141) 2022-07-15 16:48:47 +02:00
Martin Raifer
ac77289b4d refactor localized text rendering in tooltips, flash messages 2022-06-23 18:55:57 +02:00
Martin Raifer
edf711ca2b fix rendering of chip labels in localizable multiCombo fields
closes #9169
2022-06-22 14:57:58 +02:00
Martin Raifer
38dc298caa Merge remote-tracking branch '1ec5/1ec5-multicombo-raw-9164' into develop 2022-06-22 14:49:39 +02:00
Martin Raifer
5ce8eb139c add fallback values for access field for barriers 2022-06-20 19:03:50 +02:00
Minh Nguyễn
2433664063 Fixed tagging of localizable keys by multiCombo fields 2022-06-15 16:49:26 -07:00
CommanderRoot
76738daff8 Replace deprecated String.prototype.substr() (#8988)
String.prototype.substr() is deprecated (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr) so we replace it with slice() which works similarily but isn't deprecated.
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
2022-06-06 16:16:38 +02:00
Martin Raifer
c6a802b177 render lang attribute on combo field "chips" 2022-06-06 16:01:57 +02:00
Martin Raifer
8f79932ab1 prevent html injection in combobox dopdowns
and use returned wikidata label language for html `lang` metadata
2022-06-06 12:47:14 +02:00
Bryan Housel
b44c7e8741 Fix display of Wikidata combo field items 2022-06-06 12:44:58 +02:00
Minh Nguyễn
27f665b326 Ignore invalid units in field input 2022-06-03 08:04:57 -07:00
Martin Raifer
5810b61d5c Imply access=no for highway=construction objects, closes #9102 2022-05-24 14:39:02 +02:00
William Edmisten
67bd692bc0 Add multilingual field exceptions (#9124)
* Add multilingual field exceptions

* Add name:etymology

* Match language code in regex

* Restrict ISO 15924 code to 4 letters

* Allow country codes in name subkeys; match key case sensitively

Co-authored-by: Minh Nguyễn <mxn@1ec5.org>
2022-05-21 15:09:41 -07:00
Martin Raifer
cd4f4f37f1 clear "None" placehoder in fields, fixes #8984 2022-02-15 18:34:30 +01:00
Martin Raifer
4fb490abfa fix rendering of html content in turn restriction editor 2022-02-11 17:24:21 +01:00
Martin Raifer
f7d1459c97 Use value of vehicle tag as placeholder in derived access fields
see https://github.com/openstreetmap/id-tagging-schema/issues/378
2022-02-03 19:27:32 +01:00
Martin Raifer
fcd8a2b2e7 optimize order of values of access fields (closes #8945) 2022-02-03 18:46:42 +01:00
Martin Raifer
e9cf283447 Merge remote-tracking branch 'hodigabi/issue-8871' into develop 2022-01-28 12:34:39 +01:00
Martin Raifer
765e8e3448 activate new access values (#8876) 2022-01-25 20:41:23 +01:00
Gabor Hodi
2ecce0e47e [Issue8871] Do not open disabled localized combobox when clicking on it 2022-01-23 18:51:14 +01:00
Martin Raifer
cc6f16d480 Merge branch 'develop' into accessible_ui 2021-12-07 16:22:01 +01:00
Martin Raifer
250763882d fix code lint issues 2021-12-02 18:46:14 +01:00
Martin Raifer
a3e65e553b Merge branch 'colour-preview' into develop 2021-12-01 12:16:42 +01:00
Martin Raifer
e4008b4229 show native colour picker when clicking on colour preview
further tweaks:
* hide the box on invalid colours
* only affect field with a tag key that included "colour" separated by ":"
2021-12-01 12:11:13 +01:00
Martin Raifer
eec5032251 fix labeling of "reverse" button 2021-11-30 16:22:13 +01:00