Commit Graph

40 Commits

Author SHA1 Message Date
Ansis Brammanis 63f2df89b3 Fix drawing areas
the way that the vertex is being added to is the original one,
not the one with the 'end' node, so there is no need to remove it.

The new node de-dupe code was making this break area drawing.

Fixes #1322
2013-04-16 22:25:48 -04:00
John Firebaugh 5dda54ea52 Refine focus behavior for inspector (fixes #1277)
Auto-focus the search field only right after finishing drawing.
At that point, the radial menu isn't shown anyway. So then the
flow for correcting geometry before assigning a preset is:

 1. Draw.
 2. Finish drawing. The search field is focused, and no
    radial menu is open.
 3. Click again to reselect the feature and show menu.
    Now the search field is blurred.

In other words: when the menu is shown, search should not be
focused. When search is focused, the menu should not be shown.
2013-04-12 10:08:44 -04:00
Ansis Brammanis a8f41b8c57 Prevent creation of ways with duplicate nodes
Related to #1249
2013-04-05 16:35:51 -04:00
Ansis Brammanis acdc1b3824 add nodes to all of a segment's ways
when
- dragging a node to a way
- starting a line from a way
- starting an area from a way
- drawing a way
2013-04-04 17:58:53 -04:00
John Firebaugh f7fb12be76 Fix #1120, inconsistent undo for line/area drawing
Gulp!
2013-03-27 16:25:10 -07:00
Ansis Brammanis 63edc30922 Revert "Use a temporary area tag for drawing. Fixes #1014"
This reverts commit 4184b503f9.
2013-03-18 14:02:21 -04:00
Tom MacWright 4184b503f9 Use a temporary area tag for drawing. Fixes #1014 2013-03-15 18:27:06 -04:00
Ansis Brammanis 6129fbf4f5 prevent creation of ways with duplicate segments or repeated nodes 2013-03-11 16:00:24 -04:00
John Firebaugh 417e21ab05 Remove unused 2013-03-05 16:02:27 -08:00
Ansis Brammanis c74615fa83 Only re-enable dblclick after done drawing way 2013-03-05 16:54:33 -05:00
Tom MacWright 61d7ec45b5 Banish function ( style 2013-02-12 16:35:47 -05:00
Ansis Brammanis a60ed7f6e5 Remove pointer-events for area being drawn 2013-02-09 00:04:29 -05:00
Ansis Brammanis 14fc1d9c0d Fix flickering after redrawing active elems 2013-02-05 18:47:28 -05:00
Ansis Brammanis c8ab057f19 Remove unused midpoint code 2013-02-04 18:26:45 -05:00
Ansis Brammanis 3417a1639c Hide midpoints when drawing (no snapping) 2013-02-04 17:16:14 -05:00
Ansis Brammanis 1b70a68214 Revert "Don't snap to midpoints, snap to their parent way"
This reverts commit 13b0b540a7.

Conflicts:

	js/id/behavior/draw_way.js
2013-02-04 17:14:56 -05:00
Ansis Brammanis d756e3c2a2 Let ways be self-intersected 2013-02-04 16:30:19 -05:00
John Firebaugh 6dd1bebe89 Fix drawing in Firefox (fixes #628) 2013-02-04 12:26:57 -08:00
Ansis Brammanis e4a8fbd0f6 Eliminate flickering 2013-02-04 13:34:14 -05:00
Tom MacWright e5ad28feb7 JShint fixups 2013-02-04 12:10:23 -05:00
Ansis Brammanis 240d83c1fd Fix #623, get enitity from current graph 2013-02-04 10:54:39 -05:00
Ansis Brammanis 13b0b540a7 Don't snap to midpoints, snap to their parent way 2013-02-02 23:47:29 -05:00
John Firebaugh fe49e8fb77 Pass around context rather than map 2013-02-01 12:40:16 -05:00
John Firebaugh 7e68e8e114 Add iD.Context
This is a facade interface that ties together a bunch of
different internal objects and will make it easier to write
tests for behaviors, modes, and operations.
2013-02-01 12:40:15 -05:00
John Firebaugh 402a9424c0 Make selection an array of entity IDs
Should have no visible effect yet.
2013-01-31 13:51:12 -05:00
John Firebaugh 6f7079d11c AddWay/AddNode -> AddEntity 2013-01-31 12:06:21 -05:00
John Firebaugh 1bfe1359ec AddWayNode -> AddVertex 2013-01-31 12:06:21 -05:00
John Firebaugh 7e8126ded9 I18n for modes and operations 2013-01-31 11:20:41 -05:00
Saman Bemel-Benrud 1b495870c0 grammar for tooltips, keybinding hints, other tooltip fixes. 2013-01-30 19:09:10 -05:00
John Firebaugh e4c513ae87 midpoint = true -> type = 'midpoint'
Makes it more consistent with entities.
2013-01-30 16:24:33 -05:00
John Firebaugh 363cd53af1 Rearrange code 2013-01-30 16:17:30 -05:00
John Firebaugh 168a3b5e26 Fix drawing on midpoints (fixes #559) 2013-01-30 16:14:29 -05:00
John Firebaugh dbac370c71 More draw refactoring 2013-01-30 16:14:29 -05:00
John Firebaugh b37ef978f4 Snap to ways/vertices/midpoints when drawing (#240)
Also add anti-snapping behavior when option key is down.
2013-01-29 11:16:12 -05:00
John Firebaugh 5d73e45b50 Fix exiting draw mode via other means (fixes #503) 2013-01-28 17:26:14 -05:00
John Firebaugh 859ae1c1cc DrawWay#cancel shouldn't unconditionally delete the way
Fixes #514.
2013-01-28 16:39:31 -05:00
John Firebaugh e09666bbdc Fixing draw mode bugs
Disabling interactive draw undo for now. I know how to fix it
but it's a bit tricky. So undo will just drop you out to browse
mode for the time being.

Fixes #477.
Fixes #516.
2013-01-26 15:24:14 -05:00
John Firebaugh 50cfed4f3c Remove unused parameter
Follow up to deebe5.
2013-01-25 16:37:40 -05:00
John Firebaugh 0fef1a8cfd Drop -> undo 2013-01-24 18:14:40 -05:00
John Firebaugh 18c7267010 Extract Draw behavior
Fixed some bugs but introduced others.
2013-01-24 17:00:48 -05:00