CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-14 17:52:55 +00:00
Code Issues Packages Projects Releases Wiki Activity
10,483 Commits 2 Branches 0 Tags
fffdffead1cf33d9effb005524e135fed2ad5176
Commit Graph

1119 Commits

Author SHA1 Message Date
Bryan Housel
a5ffec5665 utilHighlightEntities accept an array instead of calling it in a loop 2019-02-11 12:40:23 -05:00
Quincy Morgan
0826050b55 Only zoom to the clicked issue in the entity sidebar if it isn't visible 2019-02-11 12:10:57 -05:00
Quincy Morgan
99e1203d46 Zoom to entity when opening an issue without a specific location in the entity editor 2019-02-11 11:48:21 -05:00
Quincy Morgan
149e1b3e4d Removed unused string 2019-02-11 11:41:18 -05:00
Quincy Morgan
47ec58e5fc Don't zoom to the end vertex when continuing a disconnected highway if it is already visible 
Add separate fixes for continuing a disconnected highway from the start and end vertices
Highlight the vertex that will be continued
 2019-02-11 11:29:34 -05:00
Quincy Morgan
01b0c618d1 Don't highlight the selected entity when hovering over issues in the entity editor 2019-02-11 10:58:47 -05:00
Quincy Morgan
83f8cd97f6 Add feature highlighting when hovering over their corresponding issues 2019-02-11 09:45:33 -05:00
Quincy Morgan
db319e8ff5 Merge branch 'master' into validation 2019-02-11 07:59:29 -05:00
Bryan Housel
ba44c80076 Force visible any entities related to a selected error 
(closes #5880)
 2019-02-10 23:29:49 -05:00
Bryan Housel
26368522c9 Batch changes from raw tag editor so blur/remove tag don't conflict 
(closes #5878)
 2019-02-10 22:08:13 -05:00
Bryan Housel
d64a4c5654 Don't pan map when resizing sidebar on right-to-left layout 
(closes #5881)
 2019-02-09 15:48:55 -05:00
Bryan Housel
29ce6cb30c Use proper errbacks 
(re: #5823)
 2019-02-09 14:51:37 -05:00
SilentSpike
24022416cb Fix negative number of trips in ImproveOSM issues 
See https://github.com/openstreetmap/iD/pull/5739#issuecomment-460786055
 2019-02-09 16:31:37 +00:00
Bryan Housel
fbe584c7ec Lookup docs for some presets on wikidata, not wikibase 
(re: #5823)

Now `uiTagReference` can accept a `qid` param for presets where we want this
(such as brands)
 2019-02-08 16:27:33 -05:00
Bryan Housel
b050c2f442 Avoid keeping focus on the documentation lookup button 2019-02-08 13:34:29 -05:00
Quincy Morgan
ff6860693a Merge branch 'master' into validation 2019-02-08 13:21:46 -05:00
Bryan Housel
e0459279bb Move implementation details from uiTagReference to wikibase service 2019-02-08 12:08:36 -05:00
Bryan Housel
71f2bd5900 Fix key sorting between hover/select 
(this is a better fix for #5857)
 2019-02-08 09:37:51 -05:00
Quincy Morgan
1564f73de6 Merge branch 'master' into validation 2019-02-07 20:51:21 -05:00
Bryan Housel
a363f5175f Fix tabbing beyond last row of raw tag editor in Firefox 
(closes #5847)

- removed the stopPropagation from the combobox keydown handler
  to make sure that the raw_tag_editor keydown handler will run

- increased timeout from 1ms to 10ms for Firefox
  This is related to Firefox's newish time budgeting approach that they
  started using around Firefox 55.  As a result, very fast timers (<4ms?)
  may run synchronously instead of yielding and running asynchronously
  https://blog.wanderview.com/blog/2017/03/13/firefox-52-settimeout-changes/

  (note similar code in ui/fields/combo.js to delay focus changes and
  redraws 10ms after the tag changes and other events have completed)
 2019-02-07 15:56:49 -05:00
Bryan Housel
02790fcc5c Also make sure you can delete the new row in the raw tag editor 
(re #5840)
 2019-02-07 15:04:16 -05:00
Bryan Housel
2aa409d5a9 Fix crash when deleting rows in raw tag editor 
(closes #5840)

This didn't always trigger a crash, but it can.  It attempted to remove the
row containing the key/value input fields, however this ilne is unnecessary
because the change event will trigger a redraw and d3 will handle the removing
milliseconds later.
 2019-02-07 14:10:04 -05:00
Bryan Housel
bb0a47b255 Remove kr and keepRight for styles used generically 
(it was weird to see these classes in improveOSM components)
 2019-02-07 10:35:50 -05:00
Bryan Housel
f4b9abe474 Merge pull request #5867 from SilentSpike/iOSM-comments 
Add comments to ImproveOSM issues
 2019-02-07 09:46:57 -05:00
Quincy Morgan
d3bbdfab7e Merge branch 'master' into validation 2019-02-07 07:01:36 -05:00
Quincy Morgan
a702281fb6 Add "remove" tooltip to raw tag editor remove button 2019-02-06 15:56:12 -05:00
Quincy Morgan
7036523bfc Merge branch 'master' into validation 2019-02-06 15:37:03 -05:00
Bryan Housel
e0a41656a1 Allow value to be entered before key in raw tag editor 
(closes #5872)

This commit also hardens the 'key=value' splitting behavior to actually
check the split result length and avoid overwriting a readonly key
(re: #5024)
 2019-02-06 15:03:03 -05:00
Quincy Morgan
703d560a94 Merge branch 'master' into validation 2019-02-06 12:49:59 -05:00
Bryan Housel
640730d38b Change focus to existing key instead of suffixing it with _1 
(re: #3625, re: #2896)
 2019-02-06 10:29:09 -05:00
Quincy Morgan
21967d2654 Show the area preset browser rather than editor upon selecting multipolygon from the relation preset browser 2019-02-06 09:48:45 -05:00
Quincy Morgan
0aa3ce2cee Fix issue with Issues section appearance if the sidebar was loaded with the section closed 2019-02-05 16:57:34 -05:00
SilentSpike
a566d58f81 Fix error on ImproveOSM issues with no comments 2019-02-05 21:48:06 +00:00
Quincy Morgan
2aa285c378 Merge branch 'master' into validation 2019-02-05 16:38:02 -05:00
Bryan Housel
b87ae4e98b Exclude existing keys from auto-completion in raw tag editor 
(closes #3625)
 2019-02-05 16:14:18 -05:00
SilentSpike
78111955dd Fix user URL on ImproveOSM comments 2019-02-05 21:06:19 +00:00
Quincy Morgan
1055c239ed Merge branch 'master' into validation 2019-02-05 16:03:19 -05:00
SilentSpike
c095600635 Use more appropriate new comment header string 2019-02-05 20:44:04 +00:00
SilentSpike
5fc87fb0a4 Pacify eslint 
(I really need to start running npm test more often before pushing)
 2019-02-05 20:23:02 +00:00
SilentSpike
f7bef29b92 Fix date conversion on ImproveOSM comments 2019-02-05 20:03:55 +00:00
SilentSpike
2c7b689b47 Add comments display to ImproveOSM issues 2019-02-05 19:52:44 +00:00
Bryan Housel
51af1f3b13 Don't re-sort the keys in the raw tag editor when tabbing 
(closes #5857)
 2019-02-05 14:52:13 -05:00
SilentSpike
448119324f Add ability to comment on ImproveOSM issues 2019-02-05 17:11:37 +00:00
Quincy Morgan
8771a33716 Merge branch 'master' into validation 2019-02-05 11:30:24 -05:00
Bryan Housel
e71eddd138 Merge branch 'unify' of https://github.com/SilentSpike/iD into SilentSpike-unify 2019-02-05 10:41:08 -05:00
Quincy Morgan
a23954d886 Fix issue where preset reset buttons would not initially work 2019-02-05 08:24:34 -05:00
Quincy Morgan
7329d1301a Fix issues where save button would not enable and save blocker tooltip would not disappear 2019-02-04 19:08:43 -05:00
Quincy Morgan
ca8c91563b Add issue count to section title in entity editor 
Remove redundant string
 2019-02-04 16:48:54 -05:00
SilentSpike
781558e56b Remove redundant source property 2019-02-04 18:40:06 +00:00
Quincy Morgan
ac7dba082f Merge branch 'master' into validation 2019-02-04 13:35:21 -05:00