582 Commits

Author SHA1 Message Date
Quincy Morgan
1e9021265c vA.B.C 2019-12-23 14:02:55 -05:00
Bryan Housel
ada4fb5814 Add privacy policy version check to context and splash screen
(closes #7040)

A few other minor things in this commit
- migrated several ui modal files to ES6 syntax
- switched the splash link from ideditor.org -> ideditor.blog
2019-12-19 00:11:40 -05:00
Quincy Morgan
9d936b4aea Rename rendererMap.editable function to more precise rendererMap.editableDataEnabled
Make coreContext.editable function also account for whether user is in modeSave
2019-12-12 16:06:28 -05:00
Quincy Morgan
96c8bcb152 Add tooltip to delete feature fix explaining if it's disabled (close #6588) 2019-11-13 14:52:57 -05:00
Quincy Morgan
24c72b64d1 Load issue fixes dynamically instead of cacheing them (close #7037) 2019-11-13 14:35:01 -05:00
Quincy Morgan
271a4cbac7 Update rbush to 3.0.1 (close #6359) 2019-11-08 18:17:17 +01:00
Bryan Housel
dbe016a399 v2.16.0 2019-10-23 23:34:00 -04:00
Quincy Morgan
56f31adcf1 Always sort the entity issues list deterministically
Don't skip validations just because a different validation produced issues
2019-10-12 17:01:03 +02:00
Quincy Morgan
7251a2ab90 Make "edited issues" mean "issues the user created" instead of "issues for features edited by the user"
Only include issues created by the user in the "warnings" changeset tags
Include counts of issues resolved by the user in the changeset tags (close #6459)
Don't include "fixme" issue counts in "warnings" changeset tags since they're not created by the user (close #6658)
Don't cache crossing ways issues at the rule level
2019-10-04 16:50:44 +02:00
Quincy Morgan
6a515576f1 Add an "Extract this point" quick fix for points-as-vertices validation warnings (re: #6319) 2019-10-01 18:21:03 +02:00
Quincy Morgan
525916da74 Recategorize tags_suggests_area validation rule into mismatched_geometry rule
Warn about points tagged as vertices and vertices tagged as points (close #6319)
2019-09-26 10:56:30 +02:00
Bryan Housel
590d557325 v2.15.5 2019-08-26 13:59:15 -04:00
Quincy Morgan
3bf3ecf560 Populate the default preset list with the presets parameter values, if any (close #6703) 2019-07-31 16:18:10 -04:00
Quincy Morgan
d5da5a601c Fix error upon revalidating after changing unsquare building threshold (close #6690) 2019-07-26 14:11:15 -04:00
Quincy Morgan
b730e903a4 v2.15.4 2019-07-26 12:28:41 -04:00
Quincy Morgan
eb49a367b4 Don't reuse changeset comment, sources, and hashtags from prior uploads (close #6642, re: #6279) 2019-07-22 16:12:20 -04:00
Bryan Housel
919f37a67c v2.15.3 2019-06-30 10:08:43 -04:00
Quincy Morgan
2ad2bac931 Limit addable presets via comma-separated IDs in the presets URL parameter (close #6553) 2019-06-24 12:38:32 -04:00
Bryan Housel
16d77a840c v2.15.2 2019-06-17 15:01:19 -04:00
Quincy Morgan
aa7bf74a7f Fix issue with deleting a member from a relation with a duplicate entity but different roles (close #6504) 2019-06-11 09:08:44 -04:00
Quincy Morgan
1ed73b6531 Convert validation rules to validate against a specific graph, not always the current graph (re: #6459) 2019-06-06 16:27:31 -04:00
Quincy Morgan
d42cb7b790 Fix issue where iD could crash upon save if user had edits stored before iD 2.15 (close #6496) 2019-06-06 09:20:57 -04:00
Bryan Housel
7074d48f2f v2.15.1 2019-05-24 22:10:21 -04:00
Bryan Housel
b7089675a1 v2.15.0 2019-05-21 13:07:58 -04:00
Bryan Housel
511f8ecc82 Allow user to adjust the threshold for the unsquare building warning 2019-05-18 15:44:29 -04:00
Bryan Housel
bdb454e1b3 Remove utilCallWhenIdle, use requestIdleCallback/cancelIdleCallback
Places where a reset or connection switch would be problematic,
we can now cancel the callbacks.
2019-05-16 22:28:56 -04:00
Bryan Housel
ec0145de3a Prevent accidental loading of many tiles at low zoom
This could happen because `editable` was checked before the call was scheduled
not before the `loadTiles`.  The user can zoom out more while the call is deferred.
2019-05-16 16:44:19 -04:00
Quincy Morgan
961a79e4f2 Add photo overlays used during editing to the "source" changeset tag (close #6279) 2019-05-16 14:52:41 -04:00
Quincy Morgan
409968dfc2 Add index of tags that positively identify points or vertices, derived from the presets
Delete nodes that can only be vertices when deleting parent ways (close #6230)
Allow snapping ways to nodes that cannot be positively identified as vertex-only
2019-05-14 12:09:44 -04:00
Quincy Morgan
b4b91dcb9e Revalidate the related entities of deleted entities when revalidating (close #6345) 2019-05-10 15:46:04 -04:00
Quincy Morgan
7a6949aa2e Account for the width of open panes when centering the map on issues 2019-05-10 11:33:59 -04:00
Quincy Morgan
1bbd496dfe When selecting an issue in the Issues pane, highlight the issue after selecting the feature
Use the same behavior when selecting an issue in the commit sidebar as in the issues pane
2019-05-10 10:18:46 -04:00
Quincy Morgan
f264cc47f0 Don't flag almost junctions when endpoint is building or parking entrance
Include issues for disabled rules in entity issues
2019-05-09 14:38:19 -04:00
Quincy Morgan
1d797b8fc6 Validate connected ways when validating a way to avoid stale connectivity issues (close #6335) 2019-05-08 14:56:49 -04:00
Bryan Housel
86c6805cf7 Optionally include ids members of modified relations in extantIDs
(closes #6273)
2019-05-08 13:53:48 -04:00
Bryan Housel
41f3bb9c07 Only include relation members that are visible, if extent supplied
followup to b0d5f0dd4
2019-05-08 09:23:04 -04:00
Bryan Housel
b0d5f0dd48 Include multipolygon members in complete()
(closes #3613)
2019-05-08 00:49:33 -04:00
Quincy Morgan
97cb90b562 Make issue messages dynamic (close #6331) 2019-05-07 14:48:30 -04:00
Bryan Housel
59c34e2537 Perform orthagonalization fixes without a transition
We can just set `action.transitionable = false` to make the action instant.
Also removes the `onCompletion` handlers. They shouldn't really be needed,
because the validator will run after the fix is applied (and at other times).
2019-05-06 10:23:30 -04:00
Quincy Morgan
bfc944e30a Fix two potential exceptions and one lint warning 2019-05-02 16:26:33 -07:00
Quincy Morgan
424f6ca72d Don't skip other validations even if there are missing tag issues 2019-05-02 11:51:01 -07:00
Quincy Morgan
b4dacdad2a Reduce very close nodes validation threshold (close #6292)
Use spherical distances for very close nodes validation
Don't flag very close nodes from different ways
Don't flag very close nodes if both have interesting tags
Update very close nodes validation reference string
2019-05-02 11:39:12 -07:00
Quincy Morgan
d061ec6b61 Don't add ignore fix more than once
Tweak hidden issues text
2019-05-01 20:21:47 -07:00
Quincy Morgan
eeaad79cb1 Display info about hidden issues in the "no issues" UI 2019-05-01 14:50:56 -07:00
Quincy Morgan
52d92f125c Add button to reset ignored issues
Don't cache issue extent
2019-04-30 16:32:36 -07:00
Quincy Morgan
a4ebbaf7f5 Don't use the issue loc as a differentiator for all issues 2019-04-30 13:16:03 -07:00
Quincy Morgan
375779882d Add ability to ignore warnings
Replace issue's array of entities with array of entity IDs
Improve issue ID hashing
2019-04-29 17:52:32 -07:00
Bryan Housel
fceb1a86f7 Merge pull request #6245 from openstreetmap/d3-v5
d3 v5
2019-04-29 15:46:08 -04:00
Quincy Morgan
228af9a000 Move areaKeys and setAreaKeys to modules/osm/tags 2019-04-26 12:53:05 -07:00
Quincy Morgan
ecc217f5d8 Add validation rule to flag impossible oneway highways and waterways (close #6216) 2019-04-26 12:04:43 -07:00