640730d38b
Change focus to existing key instead of suffixing it with _1
...
(re: #3625 , re: #2896 )
2019-02-06 10:29:09 -05:00
21967d2654
Show the area preset browser rather than editor upon selecting multipolygon from the relation preset browser
2019-02-06 09:48:45 -05:00
33d02cdba0
Add different messages for no tags vs. no descriptive tags warnings
...
Add warning for relation without a "type" tag
2019-02-06 09:38:33 -05:00
0aa3ce2cee
Fix issue with Issues section appearance if the sidebar was loaded with the section closed
2019-02-05 16:57:34 -05:00
a566d58f81
Fix error on ImproveOSM issues with no comments
2019-02-05 21:48:06 +00:00
0346d8060f
Retrieve ImproveOSM comments only once
...
This additionally fixes the comment box not clearing on submission as I
wasn't updating the error in the cache (to remove the newComment
property).
2019-02-05 21:46:17 +00:00
2aa285c378
Merge branch 'master' into validation
2019-02-05 16:38:02 -05:00
26dd7a4148
Use error for missing tags on all newly added features
2019-02-05 16:19:43 -05:00
b87ae4e98b
Exclude existing keys from auto-completion in raw tag editor
...
(closes #3625 )
2019-02-05 16:14:18 -05:00
78111955dd
Fix user URL on ImproveOSM comments
2019-02-05 21:06:19 +00:00
1055c239ed
Merge branch 'master' into validation
2019-02-05 16:03:19 -05:00
beab323b20
Use warning severity for missing_tag validation if the user has not edited the feature
2019-02-05 15:58:20 -05:00
c095600635
Use more appropriate new comment header string
2019-02-05 20:44:04 +00:00
5fc87fb0a4
Pacify eslint
...
(I really need to start running npm test more often before pushing)
2019-02-05 20:23:02 +00:00
f7bef29b92
Fix date conversion on ImproveOSM comments
2019-02-05 20:03:55 +00:00
fa87ed75ae
Display ImproveOSM comments oldest to newest
2019-02-05 19:57:22 +00:00
2c7b689b47
Add comments display to ImproveOSM issues
2019-02-05 19:52:44 +00:00
51af1f3b13
Don't re-sort the keys in the raw tag editor when tabbing
...
(closes #5857 )
2019-02-05 14:52:13 -05:00
28bb12b7ae
Add function to retrieve ImproveOSM comments
...
Just need to have the UI make this call and use the data next.
2019-02-05 19:31:30 +00:00
bfefea422b
Use iD's area tag logic for the tag_suggests_area validation
2019-02-05 13:55:59 -05:00
4f68e71094
Merge endpoints rather than add segment if ends are close together in tag_suggest_area fix
2019-02-05 13:21:39 -05:00
7dd337383a
Add quick fix for connecting the endpoints of a line where tags suggest area if it won't create self-intersection
2019-02-05 12:16:46 -05:00
448119324f
Add ability to comment on ImproveOSM issues
2019-02-05 17:11:37 +00:00
a80aaf65db
Improve performance when checking way for self-intersection when drawing
2019-02-05 11:42:45 -05:00
8771a33716
Merge branch 'master' into validation
2019-02-05 11:30:24 -05:00
e71eddd138
Merge branch 'unify' of https://github.com/SilentSpike/iD into SilentSpike-unify
2019-02-05 10:41:08 -05:00
0934db48dd
Don't count vertices toward many deletions warnings
...
Lower threshold for triggering many deletions warnings
2019-02-05 09:12:43 -05:00
a23954d886
Fix issue where preset reset buttons would not initially work
2019-02-05 08:24:34 -05:00
7329d1301a
Fix issues where save button would not enable and save blocker tooltip would not disappear
2019-02-04 19:08:43 -05:00
c39c584b52
Fix false positive for deprecated tag validation
2019-02-04 18:36:42 -05:00
b55830485d
Fix use of old variable name
2019-02-04 22:55:47 +00:00
ca8c91563b
Add issue count to section title in entity editor
...
Remove redundant string
2019-02-04 16:48:54 -05:00
d3946894e8
Standardize deprecated_tag and missing_tag rule type ids
...
Run crossing_ways before disconnected_way
Break out crossing_ways issue creation into a separate function
2019-02-04 16:29:29 -05:00
01c4c46918
Improve crossing ways validation performance by reducing garbage collection
2019-02-04 15:41:22 -05:00
4921a32be1
Improve performance of crossing ways validation
2019-02-04 15:22:07 -05:00
451704ca7b
Remove check to see if ways were already checked in the crossing ways validation
2019-02-04 15:07:37 -05:00
781558e56b
Remove redundant source property
2019-02-04 18:40:06 +00:00
ac7dba082f
Merge branch 'master' into validation
2019-02-04 13:35:21 -05:00
bfb5285dc9
Fix tests and lint warnings
2019-02-04 13:34:27 -05:00
ddf44377e8
Fix errors without templates not working
2019-02-04 18:12:21 +00:00
7fe0380d7d
Make sure icon fill colors can be overridden
2019-02-04 13:01:35 -05:00
d7147996ed
Merge remote-tracking branch 'upstream/master' into unify
2019-02-04 17:17:17 +00:00
b3d49f0978
Merge branch 'master' into validation
2019-02-04 12:10:45 -05:00
190fc4f434
Add message to the issues pane for when there are no issues
2019-02-04 12:06:25 -05:00
450c549ea5
Remove old error type files
2019-02-04 16:54:07 +00:00
40af841d53
Fix sidebar preview for new generic errors
2019-02-04 16:54:07 +00:00
3ed13e9a4a
Convert KeepRight to use generic error type
2019-02-04 16:54:07 +00:00
20ed8b50c9
Add generic QA error
...
I've converted the improveOSM errors to use this new generic QA error
structure which should allow for more general code to be used in
behaviour and UI.
Sidebar preview is currently broken, but will be fixed shortly.
2019-02-04 16:53:59 +00:00
c2d72cf434
Make sure the vertex is visible when using the "continue this feature" quick fix for disconnected way
2019-02-04 11:30:48 -05:00
977e667453
Remove non-functional issue options from UI
2019-02-04 11:15:05 -05:00
Bryan Housel