CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-03-07 11:51:35 +00:00
Code Issues Packages Projects Releases Wiki Activity
14,441 Commits 2 Branches 0 Tags
08c765236fbf697a969923ca964c09cdfef2af10
Commit Graph

14441 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Bryan Housel
08c765236f Force tests to use mouse events instead of pointer events 
The pointer events use a different mechanism for counting clicks that doesn't
work when the tests are run in a real browser like Chrome. This change forces
iD to always use mouse events during testing, even in a real browser.
 2021-08-18 18:58:30 -04:00
Bryan Housel
b2d18d1ebe Fix hash tests in Chrome, avoid loading imagery tiles 2021-08-18 12:51:13 -04:00
Bryan Housel
003628d6b0 Try not to load imagery when running tests 
By default, the `rendererBackground` code will choose an initial imagery based on what
sources are available at the given map location. It looks like this code will fallback
to "custom" _before_ "none", and I noticed that in some cases it was trying to fetch
whatever source happened to be stored in the "custom" template in localStorage.

This commit adds an explicit window.location.hash in a few places to encourage the
background layer to be "none". Some tests do change the hash, so this isn't perfect.
 2021-08-16 22:51:39 -04:00
Bryan Housel
33fab5580b Before calling init() make sure the assetPath is set 
init kicks off building the ui, which can fetch spritesheets for the <defs>
The assetPath needs to be set otherwise these files will not be found
 2021-08-16 22:06:42 -04:00
Bryan Housel
4f1d5f0851 Similar to e7ad3845f, avoid using finally(done) as it swallows errors 2021-08-16 15:34:26 -04:00
Bryan Housel
e7ad3845f9 Fix file fetcher tests that touch the intro_graph 
- Before it wasn't actually loading the intro graph because assetPath not set
- The test for Three Rivers City Hall was using the wrong nodeid
- All these test errors were being ignored because of the use of .finally(done)
- To actually make an error happen, we can call `done(err)` with the Error
 2021-08-16 15:23:31 -04:00
Bryan Housel
1282d3b059 Don't use a util function for a thing that exists 1x in the code 2021-08-16 14:23:24 -04:00
Bryan Housel
746417e1f4 Fix coreLocations tests access of locationSetID property 2021-08-16 14:11:36 -04:00
Bryan Housel
5aee120a86 Prefill the locale_tagging_en with fake string data 
This avoids the numerous "missing translation" errors filling up the console
 2021-08-16 14:02:25 -04:00
Bryan Housel
bb84962e5d Only insert sources into the fileMap if not already there 
This allows us to setup the fileMap correctly for testing so
that it never tries to fetch assets from the CDN.
 2021-08-16 13:28:55 -04:00
Milos Brzakovic
99cad0b7a4 Merge pull request #8638 from openstreetmap/redraw_while_transformed 
Can't redraw while transformed
 2021-08-16 16:59:54 +02:00
Bryan Housel
a962c6f96c Can't redraw while transformed 2021-08-13 17:36:45 -04:00
Milos Brzakovic
1fb42bc852 Merge pull request #8636 from openstreetmap/togeojson_package_switch 
Switch to more maintained @tmcw/togeojson
 2021-08-13 17:13:45 +02:00
Milos Brzakovic
2270b5dd9c fixes mac os firefox scroll. closes #8595 2021-08-13 16:51:02 +02:00
Milos Brzakovic
05d0d04222 Merge pull request #8635 from openstreetmap/noteTest-BuildFailures 
AddNote test fix
 2021-08-12 15:05:11 +02:00
Milos Brzakovic
25e2050bcb switched to more maintained @tmcw/togeojson 
Solves few security issues
 2021-08-12 13:38:56 +02:00
Milos Brzakovic
21b0fc4f36 semi 2021-08-11 19:57:40 +02:00
Milos Brzakovic
ee072772c2 addNote test fix 2021-08-11 19:27:37 +02:00
Milos Brzakovic
5ff84a8efd bump svg-sprite to 1.5.1 2021-08-11 18:38:53 +02:00
Milos Brzakovic
a2a3a53cf4 Merge pull request #8523 from artembert/declare-missed-dependencies-in-package-json 
Declare missed but used dependencies in package.json
 2021-08-11 18:30:37 +02:00
Milos Brzakovic
b0e3c3c56b Merge pull request #8627 from openstreetmap/nsi_route_master 
Treat route_master relations like route relations for matching to NSI
 2021-08-09 19:27:38 +02:00
Milos Brzakovic
d0577b0364 Merge pull request #8626 from openstreetmap/validator 
Validator improvements
 2021-08-09 18:07:01 +02:00
Artem Beresnev
43b8aeafae Declare missed but used dependency in package.json 2021-08-06 23:23:19 +03:00
Bryan Housel
0f913113c7 Match a 'route_master' as if it were a 'route' 
This code just treats `type=route_master` relations as if they were `type=route`
so they will match the transit networks in NSI.

(closes https://github.com/osmlab/name-suggestion-index/issues/5184)
 2021-08-05 22:05:11 -04:00
Bryan Housel
15ee63e875 Improve code for keeping only interesting key/value pairs 
Before it was not actually checking that the osmvalue was in the vmap,
so we were testing a bunch of pairs like `highway/crossing` and
`highway/residential` that would never match a NSI category.
 2021-08-05 16:59:07 -04:00
Bryan Housel
a46a345647 Only expand a validation set to include parent multipolygon relations 
The previous code was grabbing _all_ parent relations, which is too much.
For example: if a user changed a road, the validator was treating it like
the user had changed bus and highway routes along that road.

(closes #8613)
(helps a lot #8612)
 2021-08-05 14:49:14 -04:00
Bryan Housel
3b0a850400 If undo'd back to the base graph, don't show head issues as user issues 2021-08-05 12:47:52 -04:00
Bryan Housel
9f58f1fb5c Improve code for focusing a validation issue on a relation 
The "center" of the issue might be a spot of map that doesn't contain the relation.
This code chooses a piece of the relation that has been downloaded and focuses on that.
 2021-08-05 12:47:40 -04:00
Milos Brzakovic
c8aedcbb79 minor trailing spaces 2021-08-05 18:36:25 +02:00
Milos Brzakovic
bc0c1895f7 bing imagery fallback url template update 2021-08-05 18:17:58 +02:00
Milos Brzakovic
0e2d97c008 Merge pull request #8623 from openstreetmap/maxarimagery_update 
Maxar Premium imagery template url
 2021-08-05 17:50:25 +02:00
Milos Brzakovic
65274e51fc Merge pull request #8625 from openstreetmap/crossing_ways_make_fix_crossingNode 
Crossing_ways fixing - specially handle crossing nodes
 2021-08-05 17:49:51 +02:00
Milos Brzakovic
3d24736b8f trailing spaces 2021-08-05 17:36:48 +02:00
Milos Brzakovic
750b4e023f crossing_ways fixing - specially handle crossing nodes 2021-08-05 14:50:38 +02:00
Milos Brzakovic
4c72faeb3d Maxar Premium imagery connectid update 2021-08-04 18:10:42 +02:00
Milos Brzakovic
057891643c Merge pull request #8622 from openstreetmap/splash-link-change 
Splash change - Changelog instead of ideditor.blog
 2021-08-04 12:06:42 +02:00
Milos Brzakovic
021d777c9d changelog instead of ideditor.blog 2021-08-03 20:02:37 +02:00
Milos Brzakovic
21f42b1290 2 new svg fontawesome 2021-08-03 14:26:49 +02:00
Milos Brzakovic
cf611bd5d2 Display name - network but no ref edge case 2021-08-03 14:24:34 +02:00
Bryan Housel
0085c41876 Store whether a result is provisional before filtering it 
Filtering returns a new array, which was clobbering the "provisional" flag.
This was causing provisionally results to not be reprocessed later,
which meant that certain "outdated_tags" results would not be in the baseCache.
(cache of issues _before_ user edits).
 2021-08-02 17:15:25 -04:00
Bryan Housel
857b9c9adf Exclude 'fixme'/'help_request' warnings from changeset tags. 
They still appear in the issue list and in the entity editor.
(closes #8603)
 2021-08-02 14:34:18 -04:00
Milos Brzakovic
5c3da3549d Merge pull request #8618 from openstreetmap/nsi_fixes 
NSI related fixes
 2021-08-02 20:27:46 +02:00
Bryan Housel
1d5c8253be NSI matcher shouldn't treat old_name like a name tag 
(closes #8617)
 2021-08-02 12:21:34 -04:00
Bryan Housel
bd97df6aac In general, preserve existing values for tags that can be toplevel 
We'll only _replace_ the tag value if this tag is the toplevel/defining tag for the matched item (`k`)
(closes #8615)
 2021-08-02 12:07:13 -04:00
Milos Brzakovic
6b1180f116 release instructions - Release title small update 2021-07-23 16:50:29 +02:00
Milos Brzakovic
c6df2a0a6c Set development version number 2021-07-23 16:30:56 +02:00
Milos Brzakovic
33a012e007 v2.20.0 2021-07-23 15:53:43 +02:00
Milos Brzakovic
aa7f912a29 Merge pull request #8591 from openstreetmap/changelog-v2.20.0 
Changelog v2.20.0
 2021-07-23 15:51:22 +02:00
Milos Brzakovic
18741e7e9e changelog - very minor v2.20.0 2021-07-23 15:48:29 +02:00
Milos Brzakovic
b004875d71 changelog - very minor v2.20.0 fix 2021-07-23 11:16:08 +02:00