Commit Graph

5029 Commits

Author SHA1 Message Date
Martin Raifer
5c721808c6 change variables for better readability, closes #11022 2025-05-06 11:25:32 +02:00
Martin Raifer
39d2201e6e fix hover-highlight of changed features in upload dialog
fixes #10030
2025-05-06 11:17:53 +02:00
McLaynV
61670beb1d remove empty line from drag_note.js (#11015) 2025-05-06 09:19:00 +02:00
Martin Raifer
6bfcc17e2d simplify/streamline rendering of set photo id button
using d3 patterns instead of complicated manual add/remove
2025-04-29 17:21:51 +02:00
Martin Raifer
d5118b0fd6 make sure photos is properly highlighted when switching providers
previously, when the photo was already loaded in the mapillary viewer, then another photo from a different provider was displayed and the previous mapillary photo selected again, the "highlighted photo" marker was not drawn correctly, and the "set mapillary id from photo" button not properly updated
2025-04-29 17:19:55 +02:00
Martin Raifer
b78a1ac27e clean up onclick logic 2025-04-29 16:53:19 +02:00
Martin Raifer
4a9c0b4be9 properly clean up / remove "set photo id" button for unsupported providers
closes #10992
2025-04-29 16:48:37 +02:00
Martin Raifer
68c3babb9a remove old workaround of a Chrome/V8 bug
see
* https://github.com/openstreetmap/iD/issues/3973#issuecomment-309637397
* https://bugs.chromium.org/p/chromium/issues/detail?id=731193&can=1&q=prototype%20inheritance&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified
2025-04-29 15:04:23 +02:00
Martin Raifer
96746c2f7d fix crash when feature is deleted while map-panning and photoviewer is open
closes #10994
2025-04-29 15:03:14 +02:00
Martin Raifer
6798f33598 link label of address field to housenumber input element
this makes the most sense, as it should be almost always present in the address field and be the most "unique/important" value to edit for an address

closes #11004
2025-04-29 14:40:35 +02:00
Martin Raifer
7385654df1 change walkthrough imagery to Bing
the old esri layer does not seem to be available anymore
2025-04-29 14:26:00 +02:00
Martin Raifer
d4e56259fb render points over vertices, fixes #11006 2025-04-29 14:13:25 +02:00
Martin Raifer
ab7df6e040 disable keyboard controls for pannellum viewer, fixes #11001
this makes it similar to how the non 360° viewer and mapillary's 360° viewer work, allowing regular iD keyboard shortcuts to be used even when the focus is on the photo viewer
2025-04-29 13:52:59 +02:00
Martin Raifer
ef1068c257 more robuse detection of active photo service
fixes a glitch where sometimes the _pick photo id_ button would be overlapping the zoom buttons on panoramax
2025-04-29 13:43:50 +02:00
Martin Raifer
0e6ca91727 fix initial loading of pannellum viewer for vegbilder photos 2025-04-29 12:54:59 +02:00
Martin Raifer
81d94a138b fix mapillary's panorama viewer from loading properly
this was a regression from the previous commit (19957d0e3)

also, harmonize code slightly between different services
2025-04-29 11:50:37 +02:00
Martin Raifer
19957d0e39 keep photo viewer state on reset, properly clean up active marker
when switching between photos from different providers

fixes #10987
2025-04-29 09:38:18 +02:00
Martin Raifer
4dc4e7dbdc fix split operation from creating 1-node ways when 2+ nodes selected
fixes #10997

Also change the split operation to only split the ways which contain all selected nodes (when thare are more than one node selected). This is more likely what the person performing the splitting intends to do
2025-04-28 12:20:04 +02:00
Martin Raifer
19adc5cd54 consistently round non-integer initial zoom when zooming in/out
…when using the zoom buttons or +/- keyboard shortcuts (i.e. does not affect the mouse-wheel/pinch zooming)

Also: make zoom in/out transition slightly faster.

In sum, this allows to zoom in/out multiple levels in quick succession, and using the zoom buttons should be more intuive: they don't snap to very-close zoom levels anymore (e.g. hitting `+` when the current zoom was 15.97 would previously result in a final zoom of 16.00, which is not really what a user would need. Now the zooming in results in a final zoom level of 17.00, which is "actually properly zoomed in".

initial zoom | operation | final zoom (new) | final zoom (old code)
----- | --- | ----- | -----
16.00 | `+` | 17.00 | 17.00
16.00 | `-` | 15.00 | 15.00
16.10 | `+` | 17.00 | 17.00
16.10 | `-` | 15.00 | 15.00
15.90 | `+` | 17.00 | 16.00
15.90 | `-` | 15.00 | 14.00
2025-04-26 21:10:16 +02:00
Martin Raifer
fa91fe7c0d fix zoom resetting wrongly when switching background mid-transition
see https://github.com/openstreetmap/iD/issues/10700#issuecomment-2832010049
2025-04-26 21:10:16 +02:00
Martin Raifer
b05be80e53 only show outdated tags warning if there are tags to upgrade, fixes #10980 2025-04-23 12:36:57 +02:00
Chaitanya Kadu
552c6b6148 preserve step_count/… while joining ways (#10926)
* preserve the sum of certain tags (`step_count`, `parking:*:capacity`) during _join_ operation
* preserve total value of `parking:*:capacity` tags during _split_ operation by distributing it proportionally to the resulting ways
* the abstract osm entity now accepts a list of tags to override during the merging, but otherwise is agnostic about how tags can be merged: the concrete merging resolution might depend on the concrete action that was performed
2025-04-17 14:13:53 +02:00
Martin Raifer
666583d516 add hover text for relation labels in membership editor (#10942)
* append relation id as hovertext in membership editor as last-resort disambiguation in case multiple relations have otherwise the exact same label (and type)
* show regular relation label also as hover text, which is useful to see the full name in case it is cut off with an ellipisis (…) for long-ish labels
2025-04-17 12:52:32 +02:00
Martin Raifer
afce723b74 only consider proper lifecycle tagging in "past/futures" layer (#10943)
fixes #10186, where features with e.g. `intermittent=yes` were incorrectly sorted into the past/futures layer

now only features with correct tagging are included in the "past/futures" layer:
* either the "legacy" lifecycle tagging (e.g. `highway=construction`)
* or proper lifecycle prefix tags (e.g. `disused:shop=convenience`)
2025-04-17 12:47:10 +02:00
Martin Raifer
95143219a2 suggest housenumber/housename values from surrounding features (#10949)
housenumber/housename are taken from surrounding areas, as well as address points that are inside (or on the perimeter of) the same building as the selected feature
2025-04-17 12:40:30 +02:00
Martin Raifer
f5eb4d2a51 don't de-select map feature when clicking on a street level photo 2025-04-15 18:14:59 +02:00
Martin Raifer
654c13ce08 keep photo viewer open when disabling Panoramax overlay, fixes #10966 2025-04-15 17:05:09 +02:00
Martin Raifer
10030bb4ae display explicit "context" tags of deprecation rules, closes #10104 2025-04-15 11:52:45 +02:00
Martin Raifer
6a88fe3d40 fix removed tooltops from re-appearing on keyboard focus, closes #9873 2025-04-13 18:40:52 +02:00
Martin Raifer
03a5aa5058 sync dropdown keys with address tags from id-tagging-schema 2025-04-09 21:46:28 +02:00
Martin Raifer
ade83ba6e0 extend kartaview's domain hotpatching, use full resolution images, fixes #10927 2025-04-04 13:57:20 +02:00
Kyℓe Hensel
fd49a10f1c consider language scripts when determining the locale to use (#10910) 2025-03-24 14:27:18 +01:00
Martin Raifer
e4d34c2203 improve sorting search results categories:
1. direct OSM id results (e.g. `node/123`)
2. local osm data matches
3. lat/lon coordinate
4. geocoded results
5. other results (currently: only guessed OSM ids if the search looks like a number)
2025-03-21 17:58:23 +01:00
Martin Raifer
c6ad3e9a33 drop unneeded duplicate test; lint code 2025-03-21 17:58:22 +01:00
dragoon
a9832c88c3 CTRL+SHIFT+I should not trigger CTRL+I (#10818) 2025-03-20 15:07:18 +01:00
Martin Raifer
8e8c5a8621 Render oneway markers inline in dashed lines (#10849) 2025-03-20 14:01:26 +01:00
Martin Raifer
7d933f3875 add default implied access values for ways with "motorroad=yes"
see https://wiki.openstreetmap.org/wiki/OSM_tags_for_routing/Access_restrictions
addresses https://github.com/openstreetmap/id-tagging-schema/issues/609
2025-03-20 13:54:51 +01:00
Martin Raifer
771ad4dbd9 fix calculation of access field placeholder on multiselections 2025-03-20 13:54:47 +01:00
MOHAMED ALI FAWZI
9590c88646 Panoramax: Adopt "copy id" feature from mapillary (#10856) 2025-03-19 20:13:46 +01:00
Mattia Pezzotti
d1e5c2910c add date slider for street level photos, and more (#10394)
full list of enhancements:

* year slider to filter photos by freshness
* toggle active streetlevel layers with shortcut `shift+P`
* hfov, pitch and direction is now held between sequences and images as asked in #10392
* fix for #10361 (only panoramax)
* added tests and jsdoc
* add ticks for existing photos on slider
* general bug fixes
* rudimentary support for toDate in date slider (only when iD is started with a "to" date in the hash parameter: show a second slider to visualize and set the "to" date)

---------

Co-authored-by: Martin Raifer <martin@raifer.tech>
2025-03-18 21:09:37 +01:00
Martin Raifer
6bae24fa94 hotpath URL for kartaview photos ¯_(ツ)_/¯ 2025-03-18 20:47:00 +01:00
Martin Raifer
f4230785e1 fix squaring operation on vertices, closes #10401
* only calculate `motion` for the selected vertex
* don't treat vertex as "closed way" when checking disabled/enabled state of operation
2025-03-18 12:00:35 +01:00
Martin Raifer
79362ea7a8 filter empty strings from preset aliases 2025-03-17 14:01:11 +01:00
Martin Raifer
6ec6917dbc add ignore-list for presets which should not be checked for suspicious names
closes #10884
2025-03-17 13:51:20 +01:00
Martin Raifer
58cb5a0b80 also check preset aliases in suspicious names validation
see #9522
2025-03-17 13:31:26 +01:00
Martin Raifer
74dc459a4a drop unused import 2025-03-17 12:12:26 +01:00
Martin Raifer
b2e4d81767 fix infoboxes for NSI presets, fixes #10885
(which had regressed in c1ca888)
2025-03-17 12:11:51 +01:00
Martin Raifer
8b1c37bdaf take location into account for default values from regional fields 2025-03-17 11:33:42 +01:00
Martin Raifer
78f94632d7 don't inherit fields for tags that the preset already has a field for
this is useful if a preset wants to inherit some fields from another preset, but wants to replace some of the fields with special versions of the field (e.g. a `…_yes` field for an added default value), or to change the `fields`/`moreFields` classification of a field
2025-03-17 11:33:42 +01:00
dragoon
e6c379053e fix coordinate search with / symbol (#10879) 2025-03-14 19:31:04 +01:00