Commit Graph

10405 Commits

Author SHA1 Message Date
Quincy Morgan 7036523bfc Merge branch 'master' into validation 2019-02-06 15:37:03 -05:00
Quincy Morgan 5b8fea9e87 Use existing nodes where possible in the crossing ways connection fix
Fix a lint warning
2019-02-06 15:03:29 -05:00
Bryan Housel e0a41656a1 Allow value to be entered before key in raw tag editor
(closes #5872)

This commit also hardens the 'key=value' splitting behavior to actually
check the split result length and avoid overwriting a readonly key
(re: #5024)
2019-02-06 15:03:03 -05:00
Quincy Morgan 50fcff6ec9 Only check the edge nodes for almost junction merge fix 2019-02-06 14:12:19 -05:00
Quincy Morgan 7765baf03b Make merge threshold consistent for almost_junction and tag_suggests_area connection fixes 2019-02-06 13:12:58 -05:00
Quincy Morgan 88ecbcc069 Make the tag_suggests_area connection fix always use the location of the first node 2019-02-06 13:10:22 -05:00
Quincy Morgan 703d560a94 Merge branch 'master' into validation 2019-02-06 12:49:59 -05:00
Quincy Morgan b25d75a6cc Use existing nodes where possible in almost junction connection fix 2019-02-06 12:47:12 -05:00
Bryan Housel 601524c47c Use color instead of fill for the badge icon
re: 7fe0380d7

Now that the icons are all using `fill=currentColor` this is the way to do it
2019-02-06 11:54:45 -05:00
Quincy Morgan 8545ebde8e Add self-intersection check before flagging almost junction issues 2019-02-06 11:29:58 -05:00
greenkeeper[bot] d958844bc0 chore(package): update mapillary-js to version 2.16.0 2019-02-06 10:42:24 -05:00
Bryan Housel 640730d38b Change focus to existing key instead of suffixing it with _1
(re: #3625, re: #2896)
2019-02-06 10:29:09 -05:00
Quincy Morgan 4595a822dc Add code tests for more missing_tag cases 2019-02-06 10:08:28 -05:00
Quincy Morgan 21967d2654 Show the area preset browser rather than editor upon selecting multipolygon from the relation preset browser 2019-02-06 09:48:45 -05:00
Quincy Morgan 33d02cdba0 Add different messages for no tags vs. no descriptive tags warnings
Add warning for relation without a "type" tag
2019-02-06 09:38:33 -05:00
Quincy Morgan 6383fa7ea0 Merge branch 'master' into validation 2019-02-06 08:58:13 -05:00
Quincy Morgan 011f82239b Add new icons for Butcher, Cheese Shop, Copy Store, Dairy Shop, and Mexican Restaurant presets
Add Chess Table and Mexican Fast Food presets
2019-02-06 08:55:59 -05:00
Quincy Morgan c1df48ce0f Simplify crossing ways warning message 2019-02-05 17:25:34 -05:00
Quincy Morgan 0aa3ce2cee Fix issue with Issues section appearance if the sidebar was loaded with the section closed 2019-02-05 16:57:34 -05:00
Quincy Morgan 2aa285c378 Merge branch 'master' into validation 2019-02-05 16:38:02 -05:00
Quincy Morgan 26dd7a4148 Use error for missing tags on all newly added features 2019-02-05 16:19:43 -05:00
Bryan Housel b87ae4e98b Exclude existing keys from auto-completion in raw tag editor
(closes #3625)
2019-02-05 16:14:18 -05:00
Quincy Morgan 1055c239ed Merge branch 'master' into validation 2019-02-05 16:03:19 -05:00
Quincy Morgan beab323b20 Use warning severity for missing_tag validation if the user has not edited the feature 2019-02-05 15:58:20 -05:00
Bryan Housel 51af1f3b13 Don't re-sort the keys in the raw tag editor when tabbing
(closes #5857)
2019-02-05 14:52:13 -05:00
Quincy Morgan bfefea422b Use iD's area tag logic for the tag_suggests_area validation 2019-02-05 13:55:59 -05:00
Quincy Morgan 4f68e71094 Merge endpoints rather than add segment if ends are close together in tag_suggest_area fix 2019-02-05 13:21:39 -05:00
Quincy Morgan 7dd337383a Add quick fix for connecting the endpoints of a line where tags suggest area if it won't create self-intersection 2019-02-05 12:16:46 -05:00
Quincy Morgan a80aaf65db Improve performance when checking way for self-intersection when drawing 2019-02-05 11:42:45 -05:00
Quincy Morgan 8771a33716 Merge branch 'master' into validation 2019-02-05 11:30:24 -05:00
Quincy Morgan 3808685ee3 Rewrote tag as disconnected fix undo message to be more consistent 2019-02-05 11:29:09 -05:00
Bryan Housel 13e9e99c4a Allow "Monitoring Station" preset on vertex geometry
(closes #5827)
2019-02-05 11:21:37 -05:00
Quincy Morgan d09e76ccad Merge branch 'master' into validation 2019-02-05 11:18:59 -05:00
Bryan Housel 5c10aa397f Merge branch 'SilentSpike-unify' 2019-02-05 11:18:19 -05:00
Quincy Morgan 23ab1b66fb Revert "Update places of worship to use field inheritance"
This reverts commit 44d4f2378d.
2019-02-05 11:06:31 -05:00
Bryan Housel e71eddd138 Merge branch 'unify' of https://github.com/SilentSpike/iD into SilentSpike-unify 2019-02-05 10:41:08 -05:00
Quincy Morgan 7763626b02 Add access_simple field to library preset
Update Website field placeholder to use https
2019-02-05 10:22:43 -05:00
Quincy Morgan 44d4f2378d Update places of worship to use field inheritance
Add website to defaults fields for places of worship
Add presets for common place of worship denominations
2019-02-05 10:16:22 -05:00
greenkeeper[bot] 91285bc4f0 chore(package): update esm to version 3.2.1 2019-02-05 10:00:15 -05:00
Quincy Morgan 0934db48dd Don't count vertices toward many deletions warnings
Lower threshold for triggering many deletions warnings
2019-02-05 09:12:43 -05:00
Quincy Morgan a23954d886 Fix issue where preset reset buttons would not initially work 2019-02-05 08:24:34 -05:00
Quincy Morgan 7329d1301a Fix issues where save button would not enable and save blocker tooltip would not disappear 2019-02-04 19:08:43 -05:00
Quincy Morgan c39c584b52 Fix false positive for deprecated tag validation 2019-02-04 18:36:42 -05:00
SilentSpike b55830485d Fix use of old variable name 2019-02-04 22:55:47 +00:00
Quincy Morgan ca8c91563b Add issue count to section title in entity editor
Remove redundant string
2019-02-04 16:48:54 -05:00
Quincy Morgan d3946894e8 Standardize deprecated_tag and missing_tag rule type ids
Run crossing_ways before disconnected_way
Break out crossing_ways issue creation into a separate function
2019-02-04 16:29:29 -05:00
Quincy Morgan 01c4c46918 Improve crossing ways validation performance by reducing garbage collection 2019-02-04 15:41:22 -05:00
Quincy Morgan 4921a32be1 Improve performance of crossing ways validation 2019-02-04 15:22:07 -05:00
Quincy Morgan 451704ca7b Remove check to see if ways were already checked in the crossing ways validation 2019-02-04 15:07:37 -05:00
Quincy Morgan fae9d603eb Match commit errors section background color to primary error color 2019-02-04 13:45:12 -05:00