34c3ea472d
Credit user with a fix if they touched any involved entity
...
This can occur if there are several ways disconnected from the graph and
the user fixes these, but then partially undoes their fixes.
The current diff might not contain the entity that fixed the issue
(reconnected the disconnected graph), but they did fix the issue elsewhere.
2021-08-13 15:56:08 -04:00
93b868d95f
Fix how resolved issues are counted across undo, simplify code
...
(re: #8632 )
2021-08-13 14:47:38 -04:00
b5d7cdb6fa
Use utilHashcode to generate reasonable ids for crossing_ways issues
...
The ones before were a giant blob of json
2021-08-13 12:56:50 -04:00
f58ddb21fb
Remove old entityIDsToValidate() code
2021-08-13 12:32:13 -04:00
bb0b5786d9
Use context.graph()/context.hasEntity() here, not cache.graph,
...
because that is the graph that the calling code will be using.
2021-08-13 12:02:38 -04:00
2434e5edaa
In the head cache, only validate features that the user is responsible for
...
(closes #8632 )
For example, a user can undo some work and an issue will still present in the
head graph, but we don't want to credit the user for causing that issue.
2021-08-13 11:25:36 -04:00
1fb42bc852
Merge pull request #8636 from openstreetmap/togeojson_package_switch
...
Switch to more maintained @tmcw/togeojson
2021-08-13 17:13:45 +02:00
3e8d33a668
Use coreDifference.complete() instead of entityIDsToValidate()
...
From what I can tell, this code is nearly the same as what the "complete"
difference already gives us - combined nodes from both previous and current,
multipolygon members, parents of nodes/relations
2021-08-13 10:53:57 -04:00
2270b5dd9c
fixes mac os firefox scroll. closes #8595
2021-08-13 16:51:02 +02:00
96c5dd1c7c
Store graph with validation cache, give them names, es6 some things
2021-08-12 11:37:57 -04:00
25e2050bcb
switched to more maintained @tmcw/togeojson
...
Solves few security issues
2021-08-12 13:38:56 +02:00
b0e3c3c56b
Merge pull request #8627 from openstreetmap/nsi_route_master
...
Treat route_master relations like route relations for matching to NSI
2021-08-09 19:27:38 +02:00
d0577b0364
Merge pull request #8626 from openstreetmap/validator
...
Validator improvements
2021-08-09 18:07:01 +02:00
0db99fe530
When adding not:* tag, remove the old wikipedia and wikidata tags
2021-08-07 00:42:07 -04:00
97ddf125d2
Adjust wording of "Tag as not the same thing"
2021-08-06 17:14:32 -04:00
52e8555a8f
Add a validator fix option to tag as not: a matched item
...
(re: #6577 )
2021-08-06 12:26:19 -04:00
0f913113c7
Match a 'route_master' as if it were a 'route'
...
This code just treats `type=route_master` relations as if they were `type=route`
so they will match the transit networks in NSI.
(closes https://github.com/osmlab/name-suggestion-index/issues/5184 )
2021-08-05 22:05:11 -04:00
15ee63e875
Improve code for keeping only interesting key/value pairs
...
Before it was not actually checking that the osmvalue was in the vmap,
so we were testing a bunch of pairs like `highway/crossing` and
`highway/residential` that would never match a NSI category.
2021-08-05 16:59:07 -04:00
a46a345647
Only expand a validation set to include parent multipolygon relations
...
The previous code was grabbing _all_ parent relations, which is too much.
For example: if a user changed a road, the validator was treating it like
the user had changed bus and highway routes along that road.
(closes #8613 )
(helps a lot #8612 )
2021-08-05 14:49:14 -04:00
3b0a850400
If undo'd back to the base graph, don't show head issues as user issues
2021-08-05 12:47:52 -04:00
9f58f1fb5c
Improve code for focusing a validation issue on a relation
...
The "center" of the issue might be a spot of map that doesn't contain the relation.
This code chooses a piece of the relation that has been downloaded and focuses on that.
2021-08-05 12:47:40 -04:00
c8aedcbb79
minor trailing spaces
2021-08-05 18:36:25 +02:00
bc0c1895f7
bing imagery fallback url template update
2021-08-05 18:17:58 +02:00
3d24736b8f
trailing spaces
2021-08-05 17:36:48 +02:00
750b4e023f
crossing_ways fixing - specially handle crossing nodes
2021-08-05 14:50:38 +02:00
021d777c9d
changelog instead of ideditor.blog
2021-08-03 20:02:37 +02:00
0085c41876
Store whether a result is provisional before filtering it
...
Filtering returns a new array, which was clobbering the "provisional" flag.
This was causing provisionally results to not be reprocessed later,
which meant that certain "outdated_tags" results would not be in the baseCache.
(cache of issues _before_ user edits).
2021-08-02 17:15:25 -04:00
857b9c9adf
Exclude 'fixme'/'help_request' warnings from changeset tags.
...
They still appear in the issue list and in the entity editor.
(closes #8603 )
2021-08-02 14:34:18 -04:00
1d5c8253be
NSI matcher shouldn't treat old_name like a name tag
...
(closes #8617 )
2021-08-02 12:21:34 -04:00
bd97df6aac
In general, preserve existing values for tags that can be toplevel
...
We'll only _replace_ the tag value if this tag is the toplevel/defining tag for the matched item (`k`)
(closes #8615 )
2021-08-02 12:07:13 -04:00
c6df2a0a6c
Set development version number
2021-07-23 16:30:56 +02:00
33a012e007
v2.20.0
2021-07-23 15:53:43 +02:00
f9804bd1ca
Small reverting on bing imagery api
...
- Reasoning: concern on traffic amount for p2/josm key
- next release will resolve this properly
2021-07-22 19:03:19 +02:00
416799ceb6
selectChild as standalone.
...
Keyboard shortcuts new section - way selected
Moved 'help' section to left in keyboard section
2021-07-14 17:43:54 +02:00
c8f162b8f0
select - differentiate parent/child selection
...
introduce more accessible shortcuts
2021-07-13 19:51:32 +02:00
49abb78251
bing imagery template to https
2021-07-12 20:29:57 +02:00
70a8a1df25
Merge pull request #8570 from openstreetmap/bingImagery-EnsureFreshness
...
Bing imagery - ensure freshness
2021-07-12 18:56:03 +02:00
a64e49b064
small fix - whitespace
2021-07-12 18:44:22 +02:00
b135da504d
oci v5.1 + get package version for file_fetcher
2021-07-08 20:05:29 +02:00
c248aece7b
typo
2021-07-07 20:57:54 +02:00
887938c406
some bing imagery docs comments
2021-07-07 20:56:04 +02:00
81ce43e055
minor revert catch log
2021-07-07 19:23:20 +02:00
3f9fee0c05
Merge branch 'develop' into validation_queryparams_conflict_resolve
2021-07-06 19:07:07 +02:00
effc8fed58
Debounce input events in the preset list.
...
On a slow machine, the preset list is painfully slow to search, as it
rerenders the list on every keystroke, which takes several hundred
milliseconds. By debouncing this, it is able to keep up.
Performance analysis:
Before: Typing the word 'stream' results in a 2.5s frame according to
Chrome's profiler. Each input event takes between 300 and 600 ms to run.
After: Typing the word 'stream' results in three 300ms frames. The first
and last input events take around 200ms, while the four in the middle
are ignored by the debouncer.
2021-07-06 11:12:34 +00:00
358335cf4e
bingImagery strict n param.
...
Fallback url tempalate to latest
2021-07-05 14:06:57 +02:00
d2036996e3
Merge conflicts resolved
2021-07-05 10:26:44 +02:00
2d2ec4a9c3
Bing imagery - Ensure freshness
2021-07-02 17:25:07 +02:00
ba016762ca
Remove unnecessary context argument
2021-07-02 10:32:45 -04:00
8db1c1f7f5
Construct URL to match version number that package.json has
...
https://github.com/openstreetmap/iD/pull/8305#discussion_r663037548
2021-07-02 10:27:50 -04:00
bfb36d572d
If locationSet is missing include, default to worldwide include
...
https://github.com/openstreetmap/iD/pull/8305#discussion_r662344647
2021-07-02 10:03:44 -04:00
Bryan Housel