c083d1d0af
More nitpicky code formatting issues
...
- no multiline var declarations
- avoid lodash unless necessary
- linefeeds for readability
2019-02-11 14:51:21 -05:00
d457a0a31b
Merge remote-tracking branch 'iD/validation' into validation
2019-02-11 14:21:06 -05:00
aca699ecca
add osmose Items 4010 and 3030 to deprecated.json
2019-02-11 14:20:59 -05:00
9d58c4d0a2
Alphabetic
2019-02-11 14:11:35 -05:00
251a83ff7a
Nitpicky code formatting stuff
...
- no multiline var declaration
- squish together and alphabatize imports
- linebreaks for readability
2019-02-11 13:55:58 -05:00
a6e05b8ac5
Rename for consistency - these are called "annotations" elsewhere
2019-02-11 13:36:02 -05:00
ac23ac8fd2
Periods in non-sentence message headings look strange
2019-02-11 13:30:28 -05:00
b34dceeeb1
Tooltips should not receive pointer events
...
It was possible to scroll through a list of issues quickly and end up
with the mouse over a stale tooltip, then tooltip would not dismiss.
2019-02-11 13:13:26 -05:00
70cafda8ba
Group issues in a container like fields
...
(we should probably do this for all the sidebar things)
2019-02-11 13:08:59 -05:00
a5ffec5665
utilHighlightEntities accept an array instead of calling it in a loop
2019-02-11 12:40:23 -05:00
0826050b55
Only zoom to the clicked issue in the entity sidebar if it isn't visible
2019-02-11 12:10:57 -05:00
6a9bb2d138
Add crossing tags when connecting paths crossing roads with the quick fix
2019-02-11 12:03:56 -05:00
99e1203d46
Zoom to entity when opening an issue without a specific location in the entity editor
2019-02-11 11:48:21 -05:00
149e1b3e4d
Removed unused string
2019-02-11 11:41:18 -05:00
47ec58e5fc
Don't zoom to the end vertex when continuing a disconnected highway if it is already visible
...
Add separate fixes for continuing a disconnected highway from the start and end vertices
Highlight the vertex that will be continued
2019-02-11 11:29:34 -05:00
01b0c618d1
Don't highlight the selected entity when hovering over issues in the entity editor
2019-02-11 10:58:47 -05:00
ceee3c1a4b
Merge branch 'master' into validation
2019-02-11 10:23:50 -05:00
151e2685d4
Force selectedIDs to be visible
...
(re: #5880 )
2019-02-11 10:01:54 -05:00
11dc86ca9b
Add check for entity geometry type in allowsVertex function (re: #5875 )
2019-02-11 09:59:43 -05:00
83f8cd97f6
Add feature highlighting when hovering over their corresponding issues
2019-02-11 09:45:33 -05:00
db319e8ff5
Merge branch 'master' into validation
2019-02-11 07:59:29 -05:00
ba44c80076
Force visible any entities related to a selected error
...
(closes #5880 )
2019-02-10 23:29:49 -05:00
6e45796be7
Merge pull request #5875 from openstreetmap/dont-snap-non-vertices
...
Dont snap to non-vertices
2019-02-10 22:13:09 -05:00
26368522c9
Batch changes from raw tag editor so blur/remove tag don't conflict
...
(closes #5878 )
2019-02-10 22:08:13 -05:00
d64a4c5654
Don't pan map when resizing sidebar on right-to-left layout
...
(closes #5881 )
2019-02-09 15:48:55 -05:00
65fc1437dc
Fix wiki image float and margins on rtl layout
2019-02-09 15:30:57 -05:00
d055f34be8
Add sitelinks to result from wikidata getDocs
2019-02-09 15:18:32 -05:00
29ce6cb30c
Use proper errbacks
...
(re: #5823 )
2019-02-09 14:51:37 -05:00
fac9c2dadc
Merge pull request #5879 from SilentSpike/3rd-party
...
Fix negative number of trips in ImproveOSM issues
2019-02-09 14:13:32 -05:00
24022416cb
Fix negative number of trips in ImproveOSM issues
...
See https://github.com/openstreetmap/iD/pull/5739#issuecomment-460786055
2019-02-09 16:31:37 +00:00
48d001dcb9
Don't capitalize first letter of error message in Persian
...
(closes #5877 , re: #5679 )
2019-02-09 10:21:13 -05:00
6ff381cb28
Drop "from this key" jargon
2019-02-08 17:01:54 -05:00
a2b140e92b
Remove unnecessary ternary
2019-02-08 16:38:40 -05:00
fbe584c7ec
Lookup docs for some presets on wikidata, not wikibase
...
(re: #5823 )
Now `uiTagReference` can accept a `qid` param for presets where we want this
(such as brands)
2019-02-08 16:27:33 -05:00
2a7fec46fe
Fetch somewhat higher resolution images
...
(100x100 was really too small)
2019-02-08 13:36:39 -05:00
b050c2f442
Avoid keeping focus on the documentation lookup button
2019-02-08 13:34:29 -05:00
32c42073c6
Add support for Relation type documentation lookups from wikibase
...
(closes #5860 )
2019-02-08 13:24:58 -05:00
ff6860693a
Merge branch 'master' into validation
2019-02-08 13:21:46 -05:00
e0459279bb
Move implementation details from uiTagReference to wikibase service
2019-02-08 12:08:36 -05:00
71f2bd5900
Fix key sorting between hover/select
...
(this is a better fix for #5857 )
2019-02-08 09:37:51 -05:00
d70c02ee6d
Replace use of Set object in validator
2019-02-08 09:33:17 -05:00
55f71f5a7d
Replace Set objects in crossing ways validation
2019-02-08 09:20:41 -05:00
1564f73de6
Merge branch 'master' into validation
2019-02-07 20:51:21 -05:00
a363f5175f
Fix tabbing beyond last row of raw tag editor in Firefox
...
(closes #5847 )
- removed the stopPropagation from the combobox keydown handler
to make sure that the raw_tag_editor keydown handler will run
- increased timeout from 1ms to 10ms for Firefox
This is related to Firefox's newish time budgeting approach that they
started using around Firefox 55. As a result, very fast timers (<4ms?)
may run synchronously instead of yielding and running asynchronously
https://blog.wanderview.com/blog/2017/03/13/firefox-52-settimeout-changes/
(note similar code in ui/fields/combo.js to delay focus changes and
redraws 10ms after the tag changes and other events have completed)
2019-02-07 15:56:49 -05:00
02790fcc5c
Also make sure you can delete the new row in the raw tag editor
...
(re #5840 )
2019-02-07 15:04:16 -05:00
2aa409d5a9
Fix crash when deleting rows in raw tag editor
...
(closes #5840 )
This didn't always trigger a crash, but it can. It attempted to remove the
row containing the key/value input fields, however this ilne is unnecessary
because the change event will trigger a redraw and d3 will handle the removing
milliseconds later.
2019-02-07 14:10:04 -05:00
d2735ab40c
Fix misspelling
2019-02-07 13:41:06 -05:00
492bb5b37e
Eliminate magic scale numbers from tests, add loadNotes test xml
2019-02-07 11:31:32 -05:00
3875ea565b
Remove mvt querystring parameter that we never used
2019-02-07 10:48:19 -05:00
8ec426bd9d
Increase contrast between waterways and ski pistes
...
we can do:
- waterways are more on the green/teal side of blue,
- pistes are more on the red/magenta side of blue
2019-02-07 10:36:44 -05:00
Bryan Housel