Commit Graph

10317 Commits

Author SHA1 Message Date
Quincy Morgan ea3a85e88e Merge pull request #5888 from openstreetmap/dynamic-line-icon-lines
Dynamic line previews in line preset icons
2019-02-14 12:27:02 -05:00
Quincy Morgan 7c34a85eed Fix rtl layout for line preset icons 2019-02-14 10:33:26 -05:00
Quincy Morgan d0c29f8554 Tweak line icon display 2019-02-14 10:06:50 -05:00
Quincy Morgan d63430e66a Line preset icons:
- Render vertices with SVG
- Add viewBox to SVG
- Don't reload static parts of the SVG on every update
- Use dimensions that are friendly for low-res displays
- Use nicer-looking stroke dash patterns for ferry routes and railways
2019-02-14 09:40:17 -05:00
Bryan Housel 6525bbf154 Exclude current entity's value from address nearby values lookup
re: https://github.com/openstreetmap/iD/issues/5887#issuecomment-463385328
2019-02-14 00:27:32 -05:00
Bryan Housel 9e2acd836c Use case sensitive combos in address fields
(closes #5887)

This allows users to correct mistyped address parts
2019-02-14 00:20:38 -05:00
Quincy Morgan ed95fafac9 Add endpoint vertices to the preset icon line 2019-02-13 16:12:29 -05:00
Quincy Morgan 1e7d37c54a Make preset icon lines visible on the light background 2019-02-13 15:41:01 -05:00
Quincy Morgan a3099fadf5 Tweak line preset icon css 2019-02-13 14:18:36 -05:00
Quincy Morgan 09ec7ea802 Remove redundant line preset icons
Fix lint errors
2019-02-13 13:28:34 -05:00
Quincy Morgan f443144fc6 Update preset icons to use same tag classes as map SVG 2019-02-13 13:11:27 -05:00
Quincy Morgan 041e05ec90 Make the line component of the line preset icons dynamic and match the line styling in the map 2019-02-13 12:01:40 -05:00
Bryan Housel 46ab561724 Merge pull request #5885 from SilentSpike/forced
Persist forced visible entities on move/rotate
2019-02-12 21:21:12 -05:00
SilentSpike a7e0c779b3 Persist forced visible entities on move/rotate 2019-02-12 22:25:47 +00:00
Quincy Morgan 393bb7f5e3 Fix several bugs with arrow key navigation in preset list 2019-02-12 17:17:13 -05:00
Quincy Morgan 5e586419fa Remove unnecessary float styles and cleanup CSS in the preset list 2019-02-12 16:29:52 -05:00
Quincy Morgan d16dd2f182 Flexbox the preset list items
Make the category arrow the same color as the content background
Make the preset list item border radius the same for all corners
2019-02-12 16:04:52 -05:00
Quincy Morgan 24341ddb1e Merge pull request #5884 from openstreetmap/disable-preset-buttons-for-hidden-layers
Disable preset buttons for hidden layers
2019-02-12 15:17:50 -05:00
Quincy Morgan 82f6bd73ae Account for all tags added upon choosing a preset, not just those in the preset's tags property 2019-02-12 15:16:02 -05:00
Quincy Morgan 2efe2adec9 Restore previous behavior of features hidden and autoHidden but accounting for 0 count features 2019-02-12 15:05:02 -05:00
Quincy Morgan 9007ccb8fd Disable preset buttons for hidden layers 2019-02-12 14:43:04 -05:00
Quincy Morgan a46fb8043b Add terms to various shop presets (close #5849) 2019-02-12 09:31:08 -05:00
Quincy Morgan bc5912881b Add code tests for hidden boundary relation members (re: #5601) 2019-02-11 16:31:51 -05:00
Quincy Morgan 7dc1328f6d Revert "Add field for bridge:structure key that requires bridge not equal to no in order to appear"
This reverts commit 28a353f1fa.
2019-02-11 15:33:14 -05:00
Quincy Morgan 28a353f1fa Add field for bridge:structure key that requires bridge not equal to no in order to appear
Update railway presets to use field inheritance
2019-02-11 15:19:45 -05:00
Quincy Morgan 19e262643d Fix issue where "other" ways were not sorted into the "other" category for hiding purposes 2019-02-11 13:38:37 -05:00
Quincy Morgan e1da28bcd6 Hide lines that are members of boundary relations when boundaries are hidden (close #5601) 2019-02-11 13:22:20 -05:00
Bryan Housel 151e2685d4 Force selectedIDs to be visible
(re: #5880)
2019-02-11 10:01:54 -05:00
Quincy Morgan 11dc86ca9b Add check for entity geometry type in allowsVertex function (re: #5875) 2019-02-11 09:59:43 -05:00
Bryan Housel ba44c80076 Force visible any entities related to a selected error
(closes #5880)
2019-02-10 23:29:49 -05:00
Bryan Housel 6e45796be7 Merge pull request #5875 from openstreetmap/dont-snap-non-vertices
Dont snap to non-vertices
2019-02-10 22:13:09 -05:00
Bryan Housel 26368522c9 Batch changes from raw tag editor so blur/remove tag don't conflict
(closes #5878)
2019-02-10 22:08:13 -05:00
Bryan Housel d64a4c5654 Don't pan map when resizing sidebar on right-to-left layout
(closes #5881)
2019-02-09 15:48:55 -05:00
Bryan Housel 65fc1437dc Fix wiki image float and margins on rtl layout 2019-02-09 15:30:57 -05:00
Bryan Housel d055f34be8 Add sitelinks to result from wikidata getDocs 2019-02-09 15:18:32 -05:00
Bryan Housel 29ce6cb30c Use proper errbacks
(re: #5823)
2019-02-09 14:51:37 -05:00
Bryan Housel fac9c2dadc Merge pull request #5879 from SilentSpike/3rd-party
Fix negative number of trips in ImproveOSM issues
2019-02-09 14:13:32 -05:00
SilentSpike 24022416cb Fix negative number of trips in ImproveOSM issues
See https://github.com/openstreetmap/iD/pull/5739#issuecomment-460786055
2019-02-09 16:31:37 +00:00
Bryan Housel 48d001dcb9 Don't capitalize first letter of error message in Persian
(closes #5877, re: #5679)
2019-02-09 10:21:13 -05:00
Bryan Housel 6ff381cb28 Drop "from this key" jargon 2019-02-08 17:01:54 -05:00
Bryan Housel a2b140e92b Remove unnecessary ternary 2019-02-08 16:38:40 -05:00
Bryan Housel fbe584c7ec Lookup docs for some presets on wikidata, not wikibase
(re: #5823)

Now `uiTagReference` can accept a `qid` param for presets where we want this
(such as brands)
2019-02-08 16:27:33 -05:00
Bryan Housel 2a7fec46fe Fetch somewhat higher resolution images
(100x100 was really too small)
2019-02-08 13:36:39 -05:00
Bryan Housel b050c2f442 Avoid keeping focus on the documentation lookup button 2019-02-08 13:34:29 -05:00
Bryan Housel 32c42073c6 Add support for Relation type documentation lookups from wikibase
(closes #5860)
2019-02-08 13:24:58 -05:00
Bryan Housel e0459279bb Move implementation details from uiTagReference to wikibase service 2019-02-08 12:08:36 -05:00
Bryan Housel 71f2bd5900 Fix key sorting between hover/select
(this is a better fix for #5857)
2019-02-08 09:37:51 -05:00
Bryan Housel a363f5175f Fix tabbing beyond last row of raw tag editor in Firefox
(closes #5847)

- removed the stopPropagation from the combobox keydown handler
  to make sure that the raw_tag_editor keydown handler will run

- increased timeout from 1ms to 10ms for Firefox
  This is related to Firefox's newish time budgeting approach that they
  started using around Firefox 55.  As a result, very fast timers (<4ms?)
  may run synchronously instead of yielding and running asynchronously
  https://blog.wanderview.com/blog/2017/03/13/firefox-52-settimeout-changes/

  (note similar code in ui/fields/combo.js to delay focus changes and
  redraws 10ms after the tag changes and other events have completed)
2019-02-07 15:56:49 -05:00
Bryan Housel 02790fcc5c Also make sure you can delete the new row in the raw tag editor
(re #5840)
2019-02-07 15:04:16 -05:00
Bryan Housel 2aa409d5a9 Fix crash when deleting rows in raw tag editor
(closes #5840)

This didn't always trigger a crash, but it can.  It attempted to remove the
row containing the key/value input fields, however this ilne is unnecessary
because the change event will trigger a redraw and d3 will handle the removing
milliseconds later.
2019-02-07 14:10:04 -05:00