Commit Graph

236 Commits

Author SHA1 Message Date
John Firebaugh
3e082bb20e Fix typos 2021-10-24 11:01:44 -07:00
Kyle Hensel
3f12dd5107 keep the oldest Way when merging 2021-10-01 10:31:21 +13:00
John Firebaugh
1457759994 Add support for connectivity relations 2021-09-08 20:30:38 -07:00
John Firebaugh
a14cf49710 Disable merge operation when it would damage relations
The operation is disabled when attempting to join ways which don't belong to identical sets of relations. Restriction relations are excluded, because they are already handled with slightly different logic.

Fixes #8674
Fixes #8645
Fixes #3825
Fixes #1512
2021-09-04 15:42:07 -07:00
Quincy Morgan
af4acaec79 Don't clear power output tag when changing between power presets (close #8159) 2020-12-21 13:17:18 -05:00
Quincy Morgan
0a0e2dcf75 Fix issue where extracting points could results in off placements (close #8246) 2020-12-11 12:50:32 -05:00
Quincy Morgan
ba48a861bc Enable curly and block-spacing eslint rules 2020-11-10 14:19:11 -05:00
Quincy Morgan
ba4c1ef014 Account for instances where d3.geoCentroid returns incorrect results 2020-10-29 14:28:21 -04:00
Quincy Morgan
4059ee5118 Enable block-scoped-var eslint rule 2020-10-23 13:38:36 -04:00
Quincy Morgan
04b3a788f9 Add lint:fix script
Enable no-trailing-space eslint rule
2020-10-23 13:24:44 -04:00
Quincy Morgan
1a6e1b97cb Merge pull request #8083 from teymour-aldridge/develop
Tidy some things up.
2020-10-21 09:43:46 -04:00
teymour-aldridge
c259b32fbc Undo unnecessary formatting change. 2020-10-16 17:35:38 +01:00
teymour-aldridge
444c2c2c15 Apply further suggestions from code review. 2020-10-16 17:26:10 +01:00
Quincy Morgan
eaf6ff874e Support the Relations editor for multiple selected features (close #7753) 2020-10-15 11:31:32 -04:00
teymour-aldridge
b966ac318e Add back (and fix) an assignment. 2020-10-14 20:48:30 +01:00
teymour-aldridge
371a5dde0e Make a variable inline 2020-10-14 19:00:39 +01:00
teymour-aldridge
90d3f59aa6 Remove some unneeded variables.
These should theoretically actually slow down the JIT (if very marginally) so performance-wise it's better not to have them.
2020-10-14 19:00:10 +01:00
Quincy Morgan
bebd7db214 Fix potential JavaScript error 2020-10-09 10:24:53 -04:00
Quincy Morgan
d43fc62994 Divide up the step_count tag value proportionally when splitting ways (close #8069) 2020-10-09 09:48:52 -04:00
Quincy Morgan
476e929eec Support splitting areas at nodes connected to lines if the lines can't be split (close #6047) 2020-09-29 15:49:42 -04:00
Quincy Morgan
4ddd4a358b Deprecate vending=parcel_mail_in;parcel_pickup -> vending=parcel_pickup;parcel_mail_in (close #7988)
Enable upgrading of entire semicolon-delimited values
2020-09-28 16:07:11 -04:00
Quincy Morgan
c940d827e6 Enable the Split operation for multiple selected nodes (close #7990) 2020-09-24 15:13:05 -04:00
Quincy Morgan
45decdb54c Enable scaling the selection via hotkeys 2020-09-21 14:02:41 -04:00
Quincy Morgan
5ddcfb0ced Add parameter to specify which way should keep the history when splitting ways (re: #7795)
Fix code tests
2020-09-14 11:27:20 -04:00
Quincy Morgan
99c75b8f65 Keep the way history on the longer result when splitting a way (close #7795) 2020-09-14 10:01:47 -04:00
Quincy Morgan
484f54f982 Don't copy building part or indoor tags to node when extracting point from a way or relation (close #7862) 2020-08-16 17:18:16 -04:00
Peter Newman
4205ca1d07 Fix the seemingly safe spellings found by codespell
Untested, only checked by inspection.

(cherry picked from commit 2c47a11008)
2020-08-10 17:32:37 +01:00
Quincy Morgan
22df464e0d Fix issue where valid merge operations could be blocked
Disable merge when it'd create a redundant multipolygon or add a redundant membership
2020-06-29 10:51:12 -04:00
Quincy Morgan
0c95b12964 Fix issue with extracting relations 2020-06-28 14:46:49 -04:00
Quincy Morgan
e476321818 Use loops instead of functions in actionDisconnect.connections, for performance (re: #7706) 2020-06-16 13:18:59 -04:00
Quincy Morgan
8b258d2cbd Load the maximum nodes per way value from the OSM API and add a getter to the service object
Disable the Merge operation if the resultant way would have more than the maximum number of nodes (close #6030)
Simplify some code in operationMerge
2020-06-08 14:38:49 -04:00
Quincy Morgan
2e5e3791c5 Disable the straighten operation for selections that are already straight (close #7658) 2020-06-08 11:58:10 -04:00
Quincy Morgan
fcc21ce856 Update node-diff3 API calls for v2.0.0 2020-06-04 19:16:49 -04:00
Quincy Morgan
6128c6514f Enable the Extract operation for multiple selected extractable features (close #7600)
Allow extracting vertices that are `via` or `location_hint` relation members
2020-06-04 16:35:25 -04:00
Quincy Morgan
4515363779 Fix issue where merging adjacent points in a loop could disconnect the loop from itself (close #7553) 2020-05-19 15:41:38 -04:00
Quincy Morgan
e0a23723da Enable extracting lines to POIs (close #7598) 2020-05-13 11:59:55 -04:00
Quincy Morgan
04bdc4da1c Make the extract operation a single step instead of immediately entering modeMove (close #6674) 2020-05-13 10:58:53 -04:00
Quincy Morgan
a1af118f0e Ensure locales and presets are loaded before the UI loads (close #7406)
Consolidate localization behavior and init to a coreLocalizer function and singleton
Explicitly support `en-US` locale
Rename coreData to coreFileFetcher and export a singleton rather than using a property of coreContext
Add `apiConnections` property of coreContext to simplify adding a source switcher
Replace some init functions with re-callable, promise-supporting `ensureLoaded` functions
Make coreContext itself load the UI if a container has been specified at init time
Fix code tests
2020-03-31 12:23:31 -07:00
Quincy Morgan
6b096eda64 Check to remove just area=yes after merging, not any area value 2020-03-23 12:54:14 -07:00
Quincy Morgan
5125c04a58 Fix issue where merging a point matching a fallback preset into an area could discard tag values (close #7446) 2020-03-23 12:47:14 -07:00
Bryan Housel
567eeac587 Make several data external instead of bundled:
Also dist/data/* contains minified files now

These are now external and will fetch as needed:
-export { dataAddressFormats } from './address-formats.json';
-export { dataDeprecated } from './deprecated.json';
-export { dataDiscarded } from './discarded.json';
-export { dataLanguages } from './languages.json';
-export { dataPhoneFormats } from './phone-formats.json';
-export { dataShortcuts } from './shortcuts.json';
-export { dataTerritoryLanguages } from './territory-languages.json';
2020-01-28 22:21:31 -05:00
Quincy Morgan
f02c0cc4a7 Don't include area tag on the point when extracting a point from an area (close #7057) 2019-11-21 10:20:54 -05:00
Quincy Morgan
5640d7867a Simplify some "add bridge or tunnel" fix code (re: #7055)
Add endpoint to actionSplit to get the created ways after running the action
Change "Use bridge" or "tunnel" fix labels to "Add a bridge" or "tunnel"
Add layer tags on structure feature when adding a bridge or tunnel via a fix
Select all components of the split way when adding a bridge or tunnel via a fix
Don't recommend adding a bridge to a waterway
Don't show "change layers" fixes along with "add structure" fixes
Don't split or change the tags of coincident ways when adding a bridge or tunnel
2019-11-20 13:09:27 -05:00
Quincy Morgan
f7d8c51bd3 Convert single-member multipolygons to simple areas when merging ways (close #5085) 2019-11-19 12:48:51 -05:00
Katarzyna Król
48ccc7900e improve checking circularity and unit tests 2019-10-29 22:51:05 +01:00
Katarzyna Król
3feb20c764 disable circularize if object is already circular 2019-10-29 01:56:49 +01:00
Quincy Morgan
0e48627ee3 Fix issue with reversing nodes with absolute directions of 0 degrees 2019-09-18 13:39:20 -04:00
Quincy Morgan
516570739c Fix node reverse code test
Add more code tests for reversing nodes
2019-09-18 13:13:44 -04:00
Quincy Morgan
0c503768c6 Fix typo/lint error 2019-09-17 18:51:44 -04:00
Quincy Morgan
5c1bbfbbdc Add support for reversing secondary intercardinal directions on points 2019-09-17 17:02:34 -04:00