CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-13 17:23:02 +00:00
Code Issues Packages Projects Releases Wiki Activity
10,279 Commits 2 Branches 0 Tags
fac9c2dadcb05ca4fe06219a32032359bd1aaa72
Commit Graph

10279 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Bryan Housel
fac9c2dadc Merge pull request #5879 from SilentSpike/3rd-party 
Fix negative number of trips in ImproveOSM issues
 2019-02-09 14:13:32 -05:00
SilentSpike
24022416cb Fix negative number of trips in ImproveOSM issues 
See https://github.com/openstreetmap/iD/pull/5739#issuecomment-460786055
 2019-02-09 16:31:37 +00:00
Bryan Housel
48d001dcb9 Don't capitalize first letter of error message in Persian 
(closes #5877, re: #5679)
 2019-02-09 10:21:13 -05:00
Bryan Housel
6ff381cb28 Drop "from this key" jargon 2019-02-08 17:01:54 -05:00
Bryan Housel
a2b140e92b Remove unnecessary ternary 2019-02-08 16:38:40 -05:00
Bryan Housel
fbe584c7ec Lookup docs for some presets on wikidata, not wikibase 
(re: #5823)

Now `uiTagReference` can accept a `qid` param for presets where we want this
(such as brands)
 2019-02-08 16:27:33 -05:00
Bryan Housel
2a7fec46fe Fetch somewhat higher resolution images 
(100x100 was really too small)
 2019-02-08 13:36:39 -05:00
Bryan Housel
b050c2f442 Avoid keeping focus on the documentation lookup button 2019-02-08 13:34:29 -05:00
Bryan Housel
32c42073c6 Add support for Relation type documentation lookups from wikibase 
(closes #5860)
 2019-02-08 13:24:58 -05:00
Bryan Housel
e0459279bb Move implementation details from uiTagReference to wikibase service 2019-02-08 12:08:36 -05:00
Bryan Housel
71f2bd5900 Fix key sorting between hover/select 
(this is a better fix for #5857)
 2019-02-08 09:37:51 -05:00
Bryan Housel
a363f5175f Fix tabbing beyond last row of raw tag editor in Firefox 
(closes #5847)

- removed the stopPropagation from the combobox keydown handler
  to make sure that the raw_tag_editor keydown handler will run

- increased timeout from 1ms to 10ms for Firefox
  This is related to Firefox's newish time budgeting approach that they
  started using around Firefox 55.  As a result, very fast timers (<4ms?)
  may run synchronously instead of yielding and running asynchronously
  https://blog.wanderview.com/blog/2017/03/13/firefox-52-settimeout-changes/

  (note similar code in ui/fields/combo.js to delay focus changes and
  redraws 10ms after the tag changes and other events have completed)
 2019-02-07 15:56:49 -05:00
Bryan Housel
02790fcc5c Also make sure you can delete the new row in the raw tag editor 
(re #5840)
 2019-02-07 15:04:16 -05:00
Bryan Housel
2aa409d5a9 Fix crash when deleting rows in raw tag editor 
(closes #5840)

This didn't always trigger a crash, but it can.  It attempted to remove the
row containing the key/value input fields, however this ilne is unnecessary
because the change event will trigger a redraw and d3 will handle the removing
milliseconds later.
 2019-02-07 14:10:04 -05:00
Bryan Housel
d2735ab40c Fix misspelling 2019-02-07 13:41:06 -05:00
Bryan Housel
492bb5b37e Eliminate magic scale numbers from tests, add loadNotes test xml 2019-02-07 11:31:32 -05:00
Bryan Housel
3875ea565b Remove mvt querystring parameter that we never used 2019-02-07 10:48:19 -05:00
Bryan Housel
8ec426bd9d Increase contrast between waterways and ski pistes 
we can do:
- waterways are more on the green/teal side of blue,
- pistes are more on the red/magenta side of blue
 2019-02-07 10:36:44 -05:00
Bryan Housel
bb0a47b255 Remove kr and keepRight for styles used generically 
(it was weird to see these classes in improveOSM components)
 2019-02-07 10:35:50 -05:00
Bryan Housel
f4b9abe474 Merge pull request #5867 from SilentSpike/iOSM-comments 
Add comments to ImproveOSM issues
 2019-02-07 09:46:57 -05:00
Bryan Housel
043b827cc7 Remove linear water_hazard and lateral_water_hazard presets 
From reviewing wiki, these seem like not a thing - they are always areas.
re: https://wiki.openstreetmap.org/wiki/Tag:leisure%3Dgolf_course
 2019-02-06 22:07:07 -05:00
Bryan Housel
ce3b33e374 Add style for golf walking paths and cartpaths 
Also
- use field inheritance to simplify presets
- rename multipurpose to "Golf Cartpath / Service Road"
  (I think users would understand this better)
- add `maxspeed` to "Golf Cartpath / Service Road"
 2019-02-06 21:56:22 -05:00
Bryan Housel
e045c0f178 Merge pull request #5862 from chadrockey/golf_paths 
Presets for golf paths and cartpaths and driving ranges
 2019-02-06 21:17:30 -05:00
Chad Rockey
90115b55ca Update track to service 2019-02-06 14:31:11 -08:00
Quincy Morgan
a702281fb6 Add "remove" tooltip to raw tag editor remove button 2019-02-06 15:56:12 -05:00
Bryan Housel
e0a41656a1 Allow value to be entered before key in raw tag editor 
(closes #5872)

This commit also hardens the 'key=value' splitting behavior to actually
check the split result length and avoid overwriting a readonly key
(re: #5024)
 2019-02-06 15:03:03 -05:00
Bryan Housel
601524c47c Use color instead of fill for the badge icon 
re: 7fe0380d7

Now that the icons are all using `fill=currentColor` this is the way to do it
 2019-02-06 11:54:45 -05:00
greenkeeper[bot]
d958844bc0 chore(package): update mapillary-js to version 2.16.0 2019-02-06 10:42:24 -05:00
Bryan Housel
640730d38b Change focus to existing key instead of suffixing it with _1 
(re: #3625, re: #2896)
 2019-02-06 10:29:09 -05:00
Quincy Morgan
011f82239b Add new icons for Butcher, Cheese Shop, Copy Store, Dairy Shop, and Mexican Restaurant presets 
Add Chess Table and Mexican Fast Food presets
 2019-02-06 08:55:59 -05:00
Chad Rockey
31a5264c37 Add Golf Cartpath Multipurpose 2019-02-05 22:55:38 -08:00
Chad Rockey
25cc522333 Update to avoid connectivity errors 2019-02-05 22:20:16 -08:00
SilentSpike
a566d58f81 Fix error on ImproveOSM issues with no comments 2019-02-05 21:48:06 +00:00
SilentSpike
0346d8060f Retrieve ImproveOSM comments only once 
This additionally fixes the comment box not clearing on submission as I
wasn't updating the error in the cache (to remove the newComment
property).
 2019-02-05 21:46:17 +00:00
Bryan Housel
b87ae4e98b Exclude existing keys from auto-completion in raw tag editor 
(closes #3625)
 2019-02-05 16:14:18 -05:00
SilentSpike
78111955dd Fix user URL on ImproveOSM comments 2019-02-05 21:06:19 +00:00
SilentSpike
c095600635 Use more appropriate new comment header string 2019-02-05 20:44:04 +00:00
SilentSpike
5fc87fb0a4 Pacify eslint 
(I really need to start running npm test more often before pushing)
 2019-02-05 20:23:02 +00:00
SilentSpike
f7bef29b92 Fix date conversion on ImproveOSM comments 2019-02-05 20:03:55 +00:00
SilentSpike
fa87ed75ae Display ImproveOSM comments oldest to newest 2019-02-05 19:57:22 +00:00
SilentSpike
2c7b689b47 Add comments display to ImproveOSM issues 2019-02-05 19:52:44 +00:00
Bryan Housel
51af1f3b13 Don't re-sort the keys in the raw tag editor when tabbing 
(closes #5857)
 2019-02-05 14:52:13 -05:00
SilentSpike
28bb12b7ae Add function to retrieve ImproveOSM comments 
Just need to have the UI make this call and use the data next.
 2019-02-05 19:31:30 +00:00
Chad Rockey
c34f010e05 Remove golf tags 2019-02-05 10:44:20 -08:00
Chad Rockey
0bc5c13b88 Cleanup according to comments 2019-02-05 09:14:07 -08:00
SilentSpike
448119324f Add ability to comment on ImproveOSM issues 2019-02-05 17:11:37 +00:00
Bryan Housel
13e9e99c4a Allow "Monitoring Station" preset on vertex geometry 
(closes #5827)
 2019-02-05 11:21:37 -05:00
Bryan Housel
5c10aa397f Merge branch 'SilentSpike-unify' 2019-02-05 11:18:19 -05:00
Quincy Morgan
23ab1b66fb Revert "Update places of worship to use field inheritance" 
This reverts commit 44d4f2378d.
 2019-02-05 11:06:31 -05:00
Bryan Housel
e71eddd138 Merge branch 'unify' of https://github.com/SilentSpike/iD into SilentSpike-unify 2019-02-05 10:41:08 -05:00