Quincy Morgan
0934db48dd
Don't count vertices toward many deletions warnings
...
Lower threshold for triggering many deletions warnings
2019-02-05 09:12:43 -05:00
Quincy Morgan
c39c584b52
Fix false positive for deprecated tag validation
2019-02-04 18:36:42 -05:00
Quincy Morgan
d3946894e8
Standardize deprecated_tag and missing_tag rule type ids
...
Run crossing_ways before disconnected_way
Break out crossing_ways issue creation into a separate function
2019-02-04 16:29:29 -05:00
Quincy Morgan
01c4c46918
Improve crossing ways validation performance by reducing garbage collection
2019-02-04 15:41:22 -05:00
Quincy Morgan
4921a32be1
Improve performance of crossing ways validation
2019-02-04 15:22:07 -05:00
Quincy Morgan
451704ca7b
Remove check to see if ways were already checked in the crossing ways validation
2019-02-04 15:07:37 -05:00
Quincy Morgan
bfb5285dc9
Fix tests and lint warnings
2019-02-04 13:34:27 -05:00
Quincy Morgan
c2d72cf434
Make sure the vertex is visible when using the "continue this feature" quick fix for disconnected way
2019-02-04 11:30:48 -05:00
Quincy Morgan
a0558102d6
Add correct tags to crossing highway/railway and highway/waterway connection during quick fix
...
Remove unused fix text
2019-02-04 09:57:47 -05:00
Quincy Morgan
9785021f44
Rename simpleMultipolygon functions to oldMultipolygon
...
Return old_multipolygon validation issues for the relations as well as the outer ways
Remove console logging
Don't run missing_tag validation for relations with old_multipolygon issues
2019-02-01 15:19:28 -05:00
Quincy Morgan
973697b8ba
Run all validators in the validations folder if not manually run
...
Remove ValidationIssueType and ValidationIssueSeverity objects
2019-02-01 13:38:17 -05:00
Quincy Morgan
46f3cea33a
Reorganize validation code
...
Rename IssueManager to coreValidator
Rename disconnected highway to disconnected way
Rename highway almost junction to almost junction
Rename mapcss checks to maprules
Rename deprecated tags to deprecated tag
2019-02-01 11:20:51 -05:00
Bryan Housel
e60dafa540
Fix crossing ways validation - geoChooseEdge takes projected loc
2019-01-30 23:40:17 -05:00
Quincy Morgan
957eb28242
Don't run other validators if feature is missing tags
...
Don't run disconnected highway check if there is an almost junction issue already
Only run way validators on ways
2019-01-30 17:59:23 -05:00
Quincy Morgan
6aea578f92
Make validation functions take a single entity rather than an array of them
...
Pass context into validation functions directly rather than initializer
Don't initiate validation functions for every pass
2019-01-30 16:39:37 -05:00
Quincy Morgan
49d62721d8
Fix background layer UI bugs
...
Add semicolon
2019-01-30 16:10:01 -05:00
Quincy Morgan
77c4d41855
Restore many deletions warning with tooltip and nicer message
...
Add tooltips back to issues pane list
Fix crash when restoring without having loaded the edited area
2019-01-30 15:48:06 -05:00
Quincy Morgan
19a2a60bf4
Add tooltip to disabled upload button to specify what is blocking the upload
2019-01-30 13:20:56 -05:00
Quincy Morgan
6df2c24b14
Add Continue and Delete quick fixes for disconnected highway issue
2019-01-29 16:45:28 -05:00
Quincy Morgan
fedad280b4
Use different messages for crossing tunnels and bridges if they are connectable
2019-01-29 14:30:42 -05:00
Quincy Morgan
ccfba8ba0d
Don't validate crossing ways with area tags
...
Don't show connection fix for highway/waterway intersection if the highway is a major road
2019-01-29 13:44:37 -05:00
Quincy Morgan
742147c62b
Don't validate water areas or specific highway, waterway, or railway features
2019-01-29 13:31:02 -05:00
Quincy Morgan
b1e5b4f3ec
Check to see if ways can be connected before offering that quick fix
2019-01-29 13:05:11 -05:00
Quincy Morgan
907c4d9616
Rename fix function from action to onClick
2019-01-29 12:18:02 -05:00
Quincy Morgan
fcc7606089
Update crossing_ways fix to not use the context within the action
2019-01-29 11:47:24 -05:00
Quincy Morgan
2051dc4ca8
Update id of remove generic name fix
2019-01-29 10:45:48 -05:00
Quincy Morgan
f89c18e65d
Added quick fix for tag_suggest_area validation to remove the suggesting tags
2019-01-29 10:40:08 -05:00
Quincy Morgan
62ac471808
Improve message and add tooltip to tag_suggeset_area validation
2019-01-25 14:24:53 -05:00
Quincy Morgan
6fff896169
Ignore uninteresting tags and type=multipolygon for missing tags validation
2019-01-25 13:27:49 -05:00
Quincy Morgan
3886ce2ba8
Update issue tooltips and messages
2019-01-25 12:49:02 -05:00
Quincy Morgan
b5a106eab7
Validate paths for edited nodes and relations for edited geometry
2019-01-25 11:29:57 -05:00
Quincy Morgan
6302975ed2
Re-add multipolygon crossing validation
2019-01-25 10:58:57 -05:00
Quincy Morgan
298a53562d
Add issue display when selecting any feature, even if not edited
2019-01-24 17:22:34 -05:00
Quincy Morgan
ffe4aa09f4
Pass entity array into validators instead of changes object
2019-01-24 15:26:19 -05:00
Quincy Morgan
a259a9acf1
Add more deprecated tag data from https://wiki.openstreetmap.org/wiki/Deprecated_features
...
Run deprecated_tag validation on modified as well as created features
2019-01-24 15:09:02 -05:00
Quincy Morgan
b21dd1d5d6
Add tooltip and updated message to deprecated_tags validation issue
...
Add a quick fix to upgrade deprecated tags
Add more deprecated tag data
2019-01-24 14:09:12 -05:00
Quincy Morgan
33ae009936
Clarify wording of old_multipolygon issue and tooltip
...
Add quick fix for old_multipolygon issue
2019-01-24 11:01:41 -05:00
Quincy Morgan
981ed9ef8c
Integrate the generic_name validation into the new validations framework
2019-01-24 09:28:59 -05:00
Quincy Morgan
01e2370cbd
Add background color to the issue pane list
2019-01-24 08:37:46 -05:00
Quincy Morgan
7b288ef95d
Add basic zoom-to-clicked-issue behavior
2019-01-23 15:25:55 -05:00
Xiaoming Gao
aa5f1aec5b
add auto-fix for almost junction by creating connection nodes
2019-01-16 20:02:25 -05:00
Quincy Morgan
1bfb9ac0c0
Updated almost junction issue message and tooltip to be better aligned with other issues
...
Added a quick fix for setting the almost junction node as noexit
2019-01-16 10:02:05 -05:00
Quincy Morgan
11b2102761
Merge branch 'master' into validation
...
# Conflicts:
# data/core.yaml
# dist/locales/en.json
# modules/ui/commit_warnings.js
# modules/ui/entity_editor.js
# modules/util/index.js
# modules/util/util.js
# modules/validations/index.js
# modules/validations/many_deletions.js
# modules/validations/missing_tag.js
2019-01-14 10:13:56 -05:00
Xiaoming Gao
ecacab3ffe
add validation for almost junction
...
but avoid connect when the edge goes in parallel to the other road.
also added tests for the validation.
2019-01-08 15:44:55 -05:00
Bryan Housel
6c5ea96ab6
Adjust generic name validation to better check tag values
...
e.g. "name=Fast Food" should match "amenity=fast_food"
2019-01-08 13:43:40 -05:00
Bryan Housel
5f20218f1f
Add validation warning for generic names
...
(closes #5590 )
2019-01-08 02:15:28 -05:00
Quincy Morgan
70d5529a58
Added initial implementation of quick fix for connecting crossing features (still has some bugs)
2018-12-21 17:39:20 -05:00
Quincy Morgan
90bc7bf6a5
Changed crossing ways issue severity from error to warning
2018-12-21 17:21:29 -05:00
Andrew Wong
958d918bbe
Merge pull request #5639 from wonga00/more_tests
...
Added more validation tests
2018-12-21 16:49:11 -05:00
Quincy Morgan
67e585e4c5
Crossing ways issues now use the relevant parent relation when the offending way itself does not have relevant tags
2018-12-21 16:10:48 -05:00
