(closes#5847)
- removed the stopPropagation from the combobox keydown handler
to make sure that the raw_tag_editor keydown handler will run
- increased timeout from 1ms to 10ms for Firefox
This is related to Firefox's newish time budgeting approach that they
started using around Firefox 55. As a result, very fast timers (<4ms?)
may run synchronously instead of yielding and running asynchronously
https://blog.wanderview.com/blog/2017/03/13/firefox-52-settimeout-changes/
(note similar code in ui/fields/combo.js to delay focus changes and
redraws 10ms after the tag changes and other events have completed)
(closes#5840)
This didn't always trigger a crash, but it can. It attempted to remove the
row containing the key/value input fields, however this ilne is unnecessary
because the change event will trigger a redraw and d3 will handle the removing
milliseconds later.
(closes#5872)
This commit also hardens the 'key=value' splitting behavior to actually
check the split result length and avoid overwriting a readonly key
(re: #5024)
I've converted the improveOSM errors to use this new generic QA error
structure which should allow for more general code to be used in
behaviour and UI.
Sidebar preview is currently broken, but will be fixed shortly.
As per my last commit, this icon differentiates errors from points and
still allows us to specifiy icons for errors to differentiate them amongst
eachother.
I learned quite a bit about SVGs and using them in HTML while
implementing this 😝Had some issues getting the icon to center in the
header so resorted to using a flexbox instead of absolute positioning
being used elsewhere.
(closes#5769)
This change allows pointer events to flow to the caret, and forwards
them back to the combo input. Also renames several event handlers
for clarity, and increases the double-click detection threshold.
