Quincy Morgan
fedad280b4
Use different messages for crossing tunnels and bridges if they are connectable
2019-01-29 14:30:42 -05:00
Quincy Morgan
ccfba8ba0d
Don't validate crossing ways with area tags
...
Don't show connection fix for highway/waterway intersection if the highway is a major road
2019-01-29 13:44:37 -05:00
Quincy Morgan
742147c62b
Don't validate water areas or specific highway, waterway, or railway features
2019-01-29 13:31:02 -05:00
Quincy Morgan
b1e5b4f3ec
Check to see if ways can be connected before offering that quick fix
2019-01-29 13:05:11 -05:00
Quincy Morgan
907c4d9616
Rename fix function from action to onClick
2019-01-29 12:18:02 -05:00
Quincy Morgan
80c7aedb39
Fix bug with issues pane
2019-01-29 11:59:01 -05:00
Quincy Morgan
fcc7606089
Update crossing_ways fix to not use the context within the action
2019-01-29 11:47:24 -05:00
Quincy Morgan
226c4f88e1
Re-run validation automatically upon merging fetched remote data into the history
2019-01-29 11:10:12 -05:00
Quincy Morgan
2051dc4ca8
Update id of remove generic name fix
2019-01-29 10:45:48 -05:00
Quincy Morgan
f89c18e65d
Added quick fix for tag_suggest_area validation to remove the suggesting tags
2019-01-29 10:40:08 -05:00
Quincy Morgan
b48445b29a
Make the first issue's fix list appear by default
2019-01-29 09:56:44 -05:00
Quincy Morgan
0866110d77
Merge branch 'master' into validation
2019-01-29 09:16:06 -05:00
Quincy Morgan
02ccd7cfd6
v2.13.1
2019-01-28 17:38:05 -05:00
Bryan Housel
af8fb1d758
Show combobox if we are moving from a different active combobox
...
(closes #5752 )
Previously it would go down the `hide()` branch anytime an existing combobox
was active.
2019-01-28 16:22:37 -05:00
Bryan Housel
49442afe0c
In raw member editor, cancel combobox on blur if it hasn't been accepted
2019-01-28 15:41:50 -05:00
Bryan Housel
d0021f77ca
Handle possibility of combobox blurring without dispatching accept
2019-01-28 13:43:40 -05:00
Quincy Morgan
f25a80c48c
Merge branch 'master' into validation
2019-01-28 12:14:04 -05:00
Bryan Housel
87ddfa68dc
Revert 55715a482 - caused raw_tag_editor combos to not blur in Safari
2019-01-28 11:20:32 -05:00
Quincy Morgan
4ef46a4b1d
Fix issue where Chrome would attempt to autofill fields ( close #5818 )
2019-01-28 11:15:59 -05:00
Quincy Morgan
1066f8f788
Fix issue where preset browser would show after continuing a line ( close #5770 )
2019-01-28 08:52:20 -05:00
Bryan Housel
b9444ab991
Restore hand cursor on dropdown carat
...
(closes #5769 )
This change allows pointer events to flow to the caret, and forwards
them back to the combo input. Also renames several event handlers
for clarity, and increases the double-click detection threshold.
2019-01-26 13:22:31 -05:00
Bryan Housel
18d71448be
pacify eslint
2019-01-25 16:23:46 -05:00
Bryan Housel
5d6e331635
Don't erase name field when tabbing from it
...
(closes #5760 )
2019-01-25 16:16:07 -05:00
Bryan Housel
55715a4827
Try to dispatch an accept event on blur
...
(re: #5752 - but does not close it)
2019-01-25 14:47:17 -05:00
Quincy Morgan
62ac471808
Improve message and add tooltip to tag_suggeset_area validation
2019-01-25 14:24:53 -05:00
Quincy Morgan
6fff896169
Ignore uninteresting tags and type=multipolygon for missing tags validation
2019-01-25 13:27:49 -05:00
Quincy Morgan
3886ce2ba8
Update issue tooltips and messages
2019-01-25 12:49:02 -05:00
Quincy Morgan
b5a106eab7
Validate paths for edited nodes and relations for edited geometry
2019-01-25 11:29:57 -05:00
Quincy Morgan
6302975ed2
Re-add multipolygon crossing validation
2019-01-25 10:58:57 -05:00
Quincy Morgan
314e822a84
Merge master into validation
2019-01-25 10:03:40 -05:00
Quincy Morgan
f2f4c2d9c7
Make optional multiCombo fields appear if a value exists ( closes #5764 )
2019-01-25 09:43:07 -05:00
Quincy Morgan
decba8f215
Fix cycleway field to appear if "cycleway" tag present but not "cycleway:left" nor "cycleway:right" ( close #5756 )
2019-01-25 08:39:15 -05:00
Quincy Morgan
298a53562d
Add issue display when selecting any feature, even if not edited
2019-01-24 17:22:34 -05:00
Quincy Morgan
ffe4aa09f4
Pass entity array into validators instead of changes object
2019-01-24 15:26:19 -05:00
Quincy Morgan
a259a9acf1
Add more deprecated tag data from https://wiki.openstreetmap.org/wiki/Deprecated_features
...
Run deprecated_tag validation on modified as well as created features
2019-01-24 15:09:02 -05:00
Quincy Morgan
b21dd1d5d6
Add tooltip and updated message to deprecated_tags validation issue
...
Add a quick fix to upgrade deprecated tags
Add more deprecated tag data
2019-01-24 14:09:12 -05:00
Quincy Morgan
33ae009936
Clarify wording of old_multipolygon issue and tooltip
...
Add quick fix for old_multipolygon issue
2019-01-24 11:01:41 -05:00
Quincy Morgan
981ed9ef8c
Integrate the generic_name validation into the new validations framework
2019-01-24 09:28:59 -05:00
Quincy Morgan
01e2370cbd
Add background color to the issue pane list
2019-01-24 08:37:46 -05:00
Quincy Morgan
7b288ef95d
Add basic zoom-to-clicked-issue behavior
2019-01-23 15:25:55 -05:00
Quincy Morgan
4389bd8741
Merge pull request #5723 from gaoxm/almostJunctAutoFix
...
add auto-fix for almost junction by creating connection nodes
2019-01-23 13:24:48 -05:00
Quincy Morgan
e69f2a0389
Merge branch 'master' into validation
2019-01-23 13:15:33 -05:00
Quincy Morgan
24b6e9aeec
v2.13.0
2019-01-23 11:33:23 -05:00
Bryan Housel
a873c0f2ca
Remove unused, add maprules documentation
2019-01-23 11:08:19 -05:00
Bryan Housel
fa1edc86a1
Another place where we should delimit name suggestion on en-dash
...
see 20bcfc573
2019-01-23 09:57:43 -05:00
Bryan Housel
20bcfc5730
Delimit name-suggestion-preset names on en-dash, not hyphen
...
To avoid conflicts with hyphenated names, or bilingual names
with hyphens in them (like used in Brussels)
2019-01-23 09:44:24 -05:00
Bryan Housel
b3953e4a31
Don't mix up inflight tile requests with inflight keepright updates
...
(closes #5748 )
2019-01-22 23:20:17 -05:00
Bryan Housel
4583e2d4d7
Make sure all combo event listeners can handle accept/cancel w/o datum
...
(re: #5637 , re: #5618 )
This can happen if the user enters a value that is not matched to
one of the combo suggestions.
Also make sure to set `this` to the input field. It might not be
already if the event was triggered from a keypress instead of a click.
2019-01-22 23:14:34 -05:00
Bryan Housel
0c7b9a631e
Improve combobox event handling and avoid overwriting typed data
...
(closes #5722 , re: #5637 , re: #5618 )
dispatched with a value() string instead of a datum, which
causes issues for code expecting a datum always.
(such as localized.js brand picker or "Add Field" combo)
Fix for this coming in next commit.
2019-01-22 22:26:27 -05:00
Quincy Morgan
949337249b
Improved performance of multipolygon line-as-area rendering check
2019-01-22 14:10:42 -05:00
